From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Bhupesh Sharma <bhsharma@redhat.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Bhupesh SHARMA <bhupesh.linux@gmail.com>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH 1/1] ArmVirtPkg/ArmVirtQemu: Install BGRT ACPI table
Date: Mon, 16 Jan 2017 17:08:07 +0000 [thread overview]
Message-ID: <CAKv+Gu8Br-63c62c6AT=1MvYxS77JVnrbvFM9XFCP64bfEGQcw@mail.gmail.com> (raw)
In-Reply-To: <1484579178-887-1-git-send-email-bhsharma@redhat.com>
On 16 January 2017 at 15:06, Bhupesh Sharma <bhsharma@redhat.com> wrote:
> While debugging OS for ACPI BGRT support (especially on VMs),
> it is very useful to have the EFI firmware to export the
> ACPI BGRT table.
>
> This patch tries to add this support in ArmVirtPkg.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed as 13a50a6fe1dc
When booting in graphical mode, acpidump gives me
BGRT @ 0x000000013BC90000
0000: 42 47 52 54 38 00 00 00 01 70 49 4E 54 45 4C 20 BGRT8....pINTEL
0010: 45 44 4B 32 20 20 20 20 02 00 00 00 20 20 20 20 EDK2 ....
0020: 13 00 00 01 01 00 01 00 00 30 FF FF 00 00 00 00 .........0......
0030: 2F 01 00 00 0F 01 00 00 /.......
which looks close enough to me (I haven't attempted to decode the
contents to figure out whether they make sense or not)
Thanks!
> ---
> ArmVirtPkg/ArmVirtQemu.dsc | 1 +
> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 1 +
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 0cae9968f4ea..8fe3c3816961 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -390,6 +390,7 @@
> #
> # ACPI Support
> #
> + MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf {
> <LibraryClasses>
> NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> index a2e82b3179e8..cc5d12aaefea 100644
> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> @@ -145,6 +145,7 @@ READ_LOCK_STATUS = TRUE
> # ACPI Support
> #
> INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
> + INF MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
> INF OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf
>
> #
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index fe76c2263faa..aa40374745af 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -379,6 +379,7 @@
> #
> # ACPI Support
> #
> + MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf {
> <LibraryClasses>
> NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-01-16 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 15:06 [PATCH 1/1] ArmVirtPkg/ArmVirtQemu: Install BGRT ACPI table Bhupesh Sharma
2017-01-16 17:08 ` Ard Biesheuvel [this message]
2017-01-16 19:47 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu8Br-63c62c6AT=1MvYxS77JVnrbvFM9XFCP64bfEGQcw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox