From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D006A81DC2 for ; Mon, 16 Jan 2017 09:08:08 -0800 (PST) Received: by mail-io0-x22b.google.com with SMTP id j18so96037575ioe.2 for ; Mon, 16 Jan 2017 09:08:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=CgkSzGqRksUg1jMChF6oBY5IfdLJnVRFSTWINJ3foPY=; b=izOBxXpMWtHnzPX80V/ZF/SY/7HJdNvzNfII2F8A+I8GvtAo2FVntB0DoRmeDAfjq/ Qj6aCWV+fakG5uA15tPC+bx+gY5mhyaBNNhTH7TMe4GQWM4brZZ3Rjsl+4rSBz4ehdOc 3jJijTADkLizy5NctFNvDlQMT3F3A4O2RW1/E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=CgkSzGqRksUg1jMChF6oBY5IfdLJnVRFSTWINJ3foPY=; b=QGi+gjLyhlmJg3lv1uzyikJEvbnZ/iLIJO0SeRXskkEid+j3W1rETJEm0fgZ4UWSX6 zq3rLoJyn2PlGB6MySQBG+rATRpKvrvFeiQFsbCJEXUT0faYqsVEiu2YgOm/yxYqWIga edjjexkxGi+XizGFtxca1P7yEeO/iZr/eEjZFWf9CSKGJEYqsQ3nkK6xynJBhKHyoj3c 6prjIGRrXY2MgQRAKr+h5KuAem8NUq8TTB4Qsn5MS4Q0eGfqTZXluWiKiAXXi3fZnShN 2ezJc8yTle/2jAmXxmE63NCQ+iR7UFzvB1rEi3Hqg/Kec0HQWZRRxemXKERv8w0jznbI q74g== X-Gm-Message-State: AIkVDXKGjsghbdIfmMHjBec6paCwAE5wp7fXYhDiPrAUB5855hO0BVqXF01sCjfz4Lak/u4GT6EDSS1U3hFiPLIn X-Received: by 10.107.18.230 with SMTP id 99mr30355064ios.45.1484586488425; Mon, 16 Jan 2017 09:08:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.144.135 with HTTP; Mon, 16 Jan 2017 09:08:07 -0800 (PST) In-Reply-To: <1484579178-887-1-git-send-email-bhsharma@redhat.com> References: <1484579178-887-1-git-send-email-bhsharma@redhat.com> From: Ard Biesheuvel Date: Mon, 16 Jan 2017 17:08:07 +0000 Message-ID: To: Bhupesh Sharma Cc: "edk2-devel@lists.01.org" , Bhupesh SHARMA , Laszlo Ersek Subject: Re: [PATCH 1/1] ArmVirtPkg/ArmVirtQemu: Install BGRT ACPI table X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2017 17:08:09 -0000 Content-Type: text/plain; charset=UTF-8 On 16 January 2017 at 15:06, Bhupesh Sharma wrote: > While debugging OS for ACPI BGRT support (especially on VMs), > it is very useful to have the EFI firmware to export the > ACPI BGRT table. > > This patch tries to add this support in ArmVirtPkg. > > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Signed-off-by: Bhupesh Sharma > Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Ard Biesheuvel Pushed as 13a50a6fe1dc When booting in graphical mode, acpidump gives me BGRT @ 0x000000013BC90000 0000: 42 47 52 54 38 00 00 00 01 70 49 4E 54 45 4C 20 BGRT8....pINTEL 0010: 45 44 4B 32 20 20 20 20 02 00 00 00 20 20 20 20 EDK2 .... 0020: 13 00 00 01 01 00 01 00 00 30 FF FF 00 00 00 00 .........0...... 0030: 2F 01 00 00 0F 01 00 00 /....... which looks close enough to me (I haven't attempted to decode the contents to figure out whether they make sense or not) Thanks! > --- > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 1 + > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index 0cae9968f4ea..8fe3c3816961 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -390,6 +390,7 @@ > # > # ACPI Support > # > + MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf { > > NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf > diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > index a2e82b3179e8..cc5d12aaefea 100644 > --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > @@ -145,6 +145,7 @@ READ_LOCK_STATUS = TRUE > # ACPI Support > # > INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf > + INF MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf > INF OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf > > # > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index fe76c2263faa..aa40374745af 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -379,6 +379,7 @@ > # > # ACPI Support > # > + MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf { > > NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf > -- > 2.7.4 >