From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::141; helo=mail-it1-x141.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x141.google.com (mail-it1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0F0F0211A2D8B for ; Thu, 13 Dec 2018 23:22:16 -0800 (PST) Received: by mail-it1-x141.google.com with SMTP id x19so7633365itl.1 for ; Thu, 13 Dec 2018 23:22:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N4TUBjCPe6TXsPSVK/qKwlnh7pHC9FzrE2jSkpTZgZ8=; b=FYC4kGzi3BIfK4LU8tMfjdkOuFQO86Hzt8mjD4pVtNoGdKtzX9gIcjNUtci0eJr4jb bZIynqRFZsh/oEYtywhJk1QDK6GiwZAfliK+mOo4kTiM+W+lzVJTNAXyHCPpAnoibpw7 ecYQD5kQSYRME56s9pFqHoXaijXTrfTdcyLYo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N4TUBjCPe6TXsPSVK/qKwlnh7pHC9FzrE2jSkpTZgZ8=; b=krWWMMj13RfQt4tNtjuvr6gqBvgyXtEz6H95hjuDI7Zs5wUR7lrAPHt/A1HsEi/P64 FnuHHS8QR0n9fPuZ3xzWiRxy6+Byq7JFgoa+EEtEKh/jaqiqt4u3rU4mJxwjdFpCeZK+ It5u4r1aF8bsdeR8Rwic9m5SQqgevXzoVBQvX1Qr9oI1VFNod5yQzYtf5HN898dz57qV PkVnBbjSZUbfm1AZ69VxMOD9TT4zppl0wkj+wNSQWrZWKzOryKuhnWoERnGgrNGtw7gh VwIsdkCVQ9KHh2HfryMTf2BU4lYyuwYL4LCw3nNZNrS4Ixrg5yn93O4LJQSRGZodOngA eBuQ== X-Gm-Message-State: AA+aEWaa0ZTBYkexSIWuUY72W9LbPYEtIr7EMm5U5rKT3u91y/vnSQ0M zgOxGqw6V2MIkwVpDDbe+BZ1uEXKniJ9dmW1L4tcbg== X-Google-Smtp-Source: AFSGD/WeSN33TCyEg7Li1AjrGsfTWMmS314kQs0/7CRGrgTxa2WPOHh8KCx/YrfRH/dC4LGHf4yrdX1TmB4260fIv3Y= X-Received: by 2002:a24:edc4:: with SMTP id r187mr2433193ith.158.1544772136042; Thu, 13 Dec 2018 23:22:16 -0800 (PST) MIME-Version: 1.0 References: <20181106012403.84760-1-siyuan.fu@intel.com> <20181106012403.84760-2-siyuan.fu@intel.com> <7ab7d41e-ec48-3fb2-28a7-83c7471d7d0e@redhat.com> In-Reply-To: From: Ard Biesheuvel Date: Fri, 14 Dec 2018 08:22:05 +0100 Message-ID: To: "Fu, Siyuan" Cc: "edk2-devel@lists.01.org" , Julien Grall , Laszlo Ersek Subject: Re: [PATCH v3 1/1] ArmVirtPkg: Replace obsoleted network drivers from platform DSC/FDF. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 07:22:17 -0000 Content-Type: text/plain; charset="UTF-8" On Fri, 14 Dec 2018 at 07:11, Fu, Siyuan wrote: > > Hi, Arb > > Do you think if it's ok to commit this patch to ArmVirtPkg now? > Sure, please go ahead > > -----Original Message----- > > From: Fu, Siyuan > > Sent: Wednesday, November 7, 2018 8:59 AM > > To: Ard Biesheuvel > > Cc: edk2-devel@lists.01.org; Julien Grall ; Laszlo > > Ersek > > Subject: RE: [PATCH v3 1/1] ArmVirtPkg: Replace obsoleted network drivers from > > platform DSC/FDF. > > > > Hi, Arb > > > > > -----Original Message----- > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > Sent: Wednesday, November 7, 2018 12:39 AM > > > To: Laszlo Ersek > > > Cc: Fu, Siyuan ; edk2-devel@lists.01.org; Julien > > > Grall > > > Subject: Re: [PATCH v3 1/1] ArmVirtPkg: Replace obsoleted network drivers > > > from platform DSC/FDF. > > > > > > On 6 November 2018 at 16:24, Laszlo Ersek wrote: > > > > On 11/06/18 13:32, Ard Biesheuvel wrote: > > > >> On 6 November 2018 at 02:24, Fu Siyuan wrote: > > > >>> V3: > > > >>> Remove duplicate library added in v2 patch, since ArmVirtPkg.dsc.inc > > > >>> already have them. Just remove the if...end there is enough. > > > >>> > > > >>> V2: > > > >>> Add missing library instance for NetworkPkg iSCSI driver. > > > >>> > > > >> > > > >> Please don't put the patch revision history in the commit log. Put it > > > >> below the --- > > > >> > > > >>> This patch replaces the MdeModulePkg TCP, PXE and iSCSI driver with > > > those > > > >>> ones in NetworkPkg. These 3 drivers in MdeModulePkg are not being > > > actively > > > >>> maintained and will be removed from edk2 master soon. > > > >>> > > > >>> Cc: Laszlo Ersek > > > >>> Cc: Ard Biesheuvel > > > >>> Cc: Julien Grall > > > >>> Contributed-under: TianoCore Contribution Agreement 1.1 > > > >>> Signed-off-by: Fu Siyuan > > > >>> --- > > > >> > > > >> ... here ... > > > >> > > > >> The patch looks fine to me > > > >> > > > >> Reviewed-by: Ard Biesheuvel > > > >> > > > >> but please don't merge it until after the next stable tag has been > > > created > > > > > > > > This is not a bad idea (see also your discussion with Leif); however it > > > > does create a bit of inconsistency with how the other platform DSC/FDF > > > > files have been handled. (The changes have been pushed for those.) > > > > > > > > Again, I don't disagree, and I don't mind if ArmVirt is handled > > > > differently. It's just that we should have handled this more uniformly, > > > > I believe. > > > > > > > > > > Yes - as I replied to Leif, I am not going to obsess about this. But > > > the point of stable tags is not to rush things in at the last minute. > > > > OK I will not commit this change to ArmVirt until the stable tag is made. > > Sorry for the last minute notification of this change, and I can fully > > understand your concern, that's why we accepted Leif that still keep > > these MdeModulePkg drivers in this stable tag. > > > > Thanks for review. > > Siyuan > > > > > > > > > > > > > In retrospect, I would have also appreciated if the patches had > > > > referenced , even > > > > though they only implement "prep" work for now, on the platform DSC/FDF > > > > level, and not the actual driver removal. > > > > > > > > For example, the important explanation about MdeModulePkg's iSCSI driver > > > > implementing its own MD5 algo cannot be connected to the OVMF commit now > > > > (d2f1f6423bd1). I have copied the most relevant passage from the cover > > > > letter of this series into TianoCore BZ#1278, but the commit in question > > > > doesn't reference any BZ, so the link cannot be established. > > > > > > > > Thanks > > > > Laszlo