From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9A9B8803B1 for ; Wed, 22 Mar 2017 06:16:27 -0700 (PDT) Received: by mail-io0-x236.google.com with SMTP id l7so65117126ioe.3 for ; Wed, 22 Mar 2017 06:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=32XJzWCLlkyK9/QnsCm3WWrDUreGvh6Epmj50ovwIIs=; b=ZpYY8trxj2FlXv4vwuN1Qz43L2/g1/mJz9Dy9eQjQ16ASc0chVLXfNFbVXE2LLtvbZ j/lqq60liu2gWVKgFQTF1GrKrTiK8w29n2r3fo7rQvM4+PZt3FvcH2zR+yTbShBQBNbV 2iX0StTFvsvAcJSNLsn8YcN+YqrEld+PXNMms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=32XJzWCLlkyK9/QnsCm3WWrDUreGvh6Epmj50ovwIIs=; b=eTjZBjF14iSbXTzpnWjt4nSD7ZgpDJgZ024jfLdj6YWDD3bbOOaF4xDMoz97kzsmlF 0QUtjH0gHD3TjRqCWH70/DMtUwmCoZkiGYGWBYuopmtMFQoMmjAN1ufkxtuXMK3imE3P e8mobtfotM/0RqoQii7eS4w5tK/0fONuUwUvLf6zhe3ieAXCH65Fn+r4fIQMTXNmudc3 rx6+RGpORUeLgJ6I8pN2/KFqQ1UgPCtissYJoE3KA3DFxHuCWurr4y27MnFcKAbVGJKn zKkGj0ZlYYDzwYeVeqI3Q7BFxU+8QyzMQkk4MWyBQ8PtqM07h4AT29YpDac4/GJuYCLC ZQlw== X-Gm-Message-State: AFeK/H3k9LqowkYyhmGfrJfboz7Jr0q1X8oiDIOHaqsoNl9mn46bQNhdgKIbhIZrHSs6oSxvdYmJpeIB1/ddfA5X X-Received: by 10.107.141.134 with SMTP id p128mr27902885iod.83.1490188587005; Wed, 22 Mar 2017 06:16:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Wed, 22 Mar 2017 06:16:26 -0700 (PDT) In-Reply-To: <20170322125308.GT16034@bivouac.eciton.net> References: <1490042145-19509-1-git-send-email-ard.biesheuvel@linaro.org> <1490042145-19509-3-git-send-email-ard.biesheuvel@linaro.org> <20170322125308.GT16034@bivouac.eciton.net> From: Ard Biesheuvel Date: Wed, 22 Mar 2017 13:16:26 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Ryan Harkin Subject: Re: [PATCH 2/3] ArmPkg/PlatformBootManagerLib: refer to Shell FILE_GUID directly X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 13:16:27 -0000 Content-Type: text/plain; charset=UTF-8 On 22 March 2017 at 12:53, Leif Lindholm wrote: > On Mon, Mar 20, 2017 at 08:35:44PM +0000, Ard Biesheuvel wrote: >> Instead of indirecting the reference to the Shell binary via a PCD >> that is defined in IntelFrameworkModulePkg, and which invariably >> gets set to the same value by all users of this library, move the >> reference into the code, and drop the reference to the PCD entirely. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel >> --- >> ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 7 +++++-- >> ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 - >> 2 files changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >> index cc5a4d1ff9b3..d479c28775fb 100644 >> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >> @@ -33,6 +33,9 @@ >> >> #define DP_NODE_LEN(Type) { (UINT8)sizeof (Type), (UINT8)(sizeof (Type) >> 8) } >> >> +STATIC CONST EFI_GUID mUefiShellFileGuid = { >> + 0x7C04A583, 0x9E3E, 0x4f1c, { 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } >> +}; > > Surely this ought to be defined in a shared header file rather than > replicated across the tree? (And yes, used in QuarkPlatformPkg as > well.) > > Otherwise, looks like a good change. > Yes, it would make the most sense to add this to the [Guid] section of ShellPkg itself. I will propose it as a separate series, and replace the quark reference as well