From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::143; helo=mail-it1-x143.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x143.google.com (mail-it1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 02373208AE36D for ; Fri, 15 Feb 2019 02:07:40 -0800 (PST) Received: by mail-it1-x143.google.com with SMTP id z131so12397403itf.5 for ; Fri, 15 Feb 2019 02:07:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+FIt5LS2BZi1EuYsDB3XuIS1PdC3bgW5ESaoyiXBr74=; b=ASzpU499Vf5rjMLkkDO1V4fJSmT2/aZ1nxBPtkUrVyUwSV6OtYEgfkwH4ux2WB5SOA rv+TekkHE3w2jmhh3IXm/4UVOx4Uomn9c+M8hMgcTAQismmfEh9atAfAe1JB+1c7ouAr EL+QltYWsbyZgaMiPYUUPDQoAcgR8UujeMU8aPZseoQnYuEILcYlCZlW1Ede+Kdzf2y2 p/nkgUrujOpFXEME4XjbbKT3+jrHehQBQ4BffJXlU09/XiNev8cxAaNqjTV3WyzuF7fl z101P6CWkZ9u4asUEqPXkKJ+nP02beGmmokiJWEGJ4wU876ZBZDMwInT7ifWK7BWXLAX BS6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+FIt5LS2BZi1EuYsDB3XuIS1PdC3bgW5ESaoyiXBr74=; b=bi4WYTpU11SD5GiHc8f6SlwHTNT7wT7sWqhKPv8qMMZMNz8WedHx6/pAbv68ovH0As maeyxSGcqJP68/owocNpgjbJaDhHkm3BkyYNNR7uFrqjw1u14ixhnhIqZr8TCk2xj2QF q+e1amnS2ad3uImpaOGlJEFt1lGsIYQOtn+QMgIsWJRx0AtPIKC73835JmzNrVVHEwl6 ec2mowznGNgKnMPOPWUpy6tju13v2Z1RWKDW+/lMZ33N/lpyAqEb3GcT8EuaiVkKoq+z sxAZurOPZnEWXHGnfaR67cFT14SvTtnhwWjHatg8KMxE4/zqiq3w+MLiiqzBrOS4v5s1 eaWg== X-Gm-Message-State: AHQUAubTQQc+3c6rbr4QY2YPo8+FOQVlnbpn6ZLYIBwHZxvMNV+S61Xh NeKWsrit+SYpTnslxkx/CtFOkvM/GCvQfmdcQLHu9g== X-Google-Smtp-Source: AHgI3IY3HqK8rdfkegnihy3GOwNLLGfY/wVpK5Og2uhWa5ZN1xxZ/z2HE/tIJtv18LFFnSrNyYUvhHfGjvbTQ6DBe6E= X-Received: by 2002:a5e:9704:: with SMTP id w4mr5646659ioj.60.1550225259973; Fri, 15 Feb 2019 02:07:39 -0800 (PST) MIME-Version: 1.0 References: <20190204124736.124-1-pete@akeo.ie> <20190204124736.124-2-pete@akeo.ie> <20190212181430.oji2fxzfpeq5lm4t@bivouac.eciton.net> In-Reply-To: <20190212181430.oji2fxzfpeq5lm4t@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 15 Feb 2019 11:07:28 +0100 Message-ID: To: Leif Lindholm Cc: Pete Batard , "edk2-devel@lists.01.org" Subject: Re: [PATCH 1/1] EmbeddedPkg/Library: Add VirtualRealTimeClockLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2019 10:07:41 -0000 Content-Type: text/plain; charset="UTF-8" On Tue, 12 Feb 2019 at 19:14, Leif Lindholm wrote: > > On Mon, Feb 04, 2019 at 12:47:36PM +0000, Pete Batard wrote: > > This is designed to be used on platforms where a a real RTC is not > > available and relies on an RtcEpochSeconds variable having been set or, > > if that is not the case, falls back to using the epoch embedded at > > compilation time. > > > > Note that, in order to keep things simple for the setting of the > > compilation time variable, only GCC environments with UNIX-like shells > > and where a 'date' command is available are meant to be supported for > > now. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Pete Batard > > On the whole, this looks good to me. > One addition we'll need, so that we can build this library standalone > is an entry in EmbeddedPkg.dsc: > > diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc > index 4d9e6399d5..dc5040e611 100644 > --- a/EmbeddedPkg/EmbeddedPkg.dsc > +++ b/EmbeddedPkg/EmbeddedPkg.dsc > @@ -218,6 +218,7 @@ [Components.common] > EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.inf > EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.inf > EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf > + EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf > EmbeddedPkg/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter.inf > EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > > I don't have any strong opinions on either of Phil's suggestions, but > if you could give some feedback on those and fold the above in, this > could go in. > WIth this addition Reviewed-by: Ard Biesheuvel Pushed as 1b261a705f94..64a17fadcb79