From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d44; helo=mail-io1-xd44.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1BE662119C8B0 for ; Wed, 12 Dec 2018 06:03:04 -0800 (PST) Received: by mail-io1-xd44.google.com with SMTP id o13so480266ioh.2 for ; Wed, 12 Dec 2018 06:03:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E9NGcQtnrzvZ0efqDwBx0jba/BdcH85EMTfceLtTJ9U=; b=BNyXEH8zyZd8P8bb1+oGmwUYbPY6MzFutGRLSNkpEMcTWK2khvyFxkf5qbZoVlb5c/ 8IFapiHME4T6jWt7jPM/llEaAQygUOYgIRaW19aCCz9r6E0ovaVk49JbPxZnVSz/7Iyy aS+cV8aYHLOoEuBAu6M/Ut33GP16yUlmbiZo4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E9NGcQtnrzvZ0efqDwBx0jba/BdcH85EMTfceLtTJ9U=; b=DReQrtvQUF51FOcK32YE6+ICf8YMLqPO8qylbroAlQ2VSbe/7Gkw6tqUDopDxsFHvK 3AsOYTubfsdZgvOFSHl7Hz8xCduVeBBPE8pDvZ/Z7ZfWVocPUVp1jmLDMvRCV2CKmxmC YfxNC27mB7sDdvqUyvqWzjFbojFOzAhwrZ8romV+Tlx5hOi44Kkd4fcnTodRj2WkRBI9 CluZeqEdIds69b8yxwTOdV1dTZxWeXQilVLp8iyHkOcbzJfec5K3tiTTQ3DczcTt8nPW byiQIMP9d/3IWcf9LboaLK9kSuWob4dXTBXa18n/dIVxcUMPbE5iSNmQ3fOkpvSEyHm1 feqg== X-Gm-Message-State: AA+aEWbBQQ5IvvfXbW52tvYlWdsSIhEIZufCehS/Nlo+SqU81xEWTMDe xJjCAO3JAmqx91hhWqWlXuioBCcy17MPCus5mTg3xQ== X-Google-Smtp-Source: AFSGD/UNdNfqV5BKIIkqWo9/suzHdLByK2TaUAeY5I11ZSyJAkrslY5fuJclPP9vS4rB2QwT5OZ15c1BNri/400snmg= X-Received: by 2002:a5d:8415:: with SMTP id i21mr16715843ion.173.1544623383971; Wed, 12 Dec 2018 06:03:03 -0800 (PST) MIME-Version: 1.0 References: <20181212103308.8099-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E38B9CB@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E38B9CB@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Wed, 12 Dec 2018 15:02:52 +0100 Message-ID: To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" , "Kinney, Michael D" , "Feng, Bob C" , Leif Lindholm , Laszlo Ersek Subject: Re: [PATCH 0/3] fixes for CLANG35 on ARM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 14:03:05 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 12 Dec 2018 at 15:01, Gao, Liming wrote: > > Ard: > I have no comments on this patch. So, CLANG38 has no issue. If so, could you recommend use CLANG38? > Yes, the latest is always preferred. However, since CLANG38 enables LTO, you need the LLVMgold plugin, which is not shipped for all versions of Clang by the distros. So it is good to keep CLANG35 as a fallback. > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Wednesday, December 12, 2018 6:33 PM > > To: edk2-devel@lists.01.org > > Cc: Ard Biesheuvel ; Kinney, Michael D ; Gao, Liming > > ; Feng, Bob C ; Leif Lindholm ; Laszlo Ersek > > > > Subject: [PATCH 0/3] fixes for CLANG35 on ARM > > > > Building with Clang 3.5 for ARM may result in build breakage, due to the > > fact that it may emit non-adjacent movw/movt instructions pairs which > > cannot be relocated in PE/COFF. We pass -mno-movt in some places to > > work around a related issue in the relocatable PrePi in ArmVirtPkg, but > > we need to disable movw/movt entirely to really address this issue. > > > > So first, fix some breakage that results from building with -mlong-calls > > in the optimized BaseMemoryLib code (#1) > > > > Patch #2 switches to -mkernel, which disables movw/movt generation (and > > enabled -mlong-calls as a side effect) > > > > Patch #3 removes the now redundant, and incompatible command line > > overrides for the relocatable PrePi. > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Bob Feng > > Cc: Leif Lindholm > > Cc: Laszlo Ersek > > > > Ard Biesheuvel (3): > > MdePkg/BaseMemoryLibOptDxe ARM: add missing function annotations > > BaseTools/tools_def ARM CLANG35: work around -mno-movt option name > > change > > ArmVirtPkg/PrePi ARM CLANG35: drop incompatible command line option > > > > ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ----- > > ArmVirtPkg/ArmVirtXen.dsc | 5 ----- > > BaseTools/Conf/tools_def.template | 2 +- > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.S | 1 + > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareMem.S | 1 + > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CopyMem.S | 1 + > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/SetMem.S | 5 +++++ > > 7 files changed, 9 insertions(+), 11 deletions(-) > > > > -- > > 2.19.2 >