From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65])
 by mx.groups.io with SMTP id smtpd.web09.2774.1581151950539544455
 for <devel@edk2.groups.io>;
 Sat, 08 Feb 2020 00:52:31 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=tIKmFAvU;
 spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wr1-f65.google.com with SMTP id y17so1588684wrh.5
        for <devel@edk2.groups.io>; Sat, 08 Feb 2020 00:52:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=146Th0rgZFeV/S+KQmHRDIegVz/HGhbi3CZ5ou052f4=;
        b=tIKmFAvUncxFDyzlMDf7r0Ob+7ij8t+kMmpPJeDO+fmmCatwlV1t3S3wjNoGYxgSDs
         GsnwnwwbmqM/I1eub01nbDe8jmC7U1Jmbmg5RBEu9c/wJXmSFxiMglAd7Kgp45T3GTI3
         HJOH1ZcMV3OdwboueGKw6YVXtqO8rA2djuQPAAOyGKPcHU/+G3yTBfWSygh1vmmq80Qy
         0DQdAWqOcigzLpz8rtklP7SRnNQEEGVRjAeJIQbBDwGl+mOInbuLUZHoXHdI6uxI5oKs
         2Hi3BTJRTkNcy1tmC9XGbxCi2Sj0ts9irfiXkZ3NH/EWAUTJFs19ta11Yiwtz8r5IhFo
         dJjQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=146Th0rgZFeV/S+KQmHRDIegVz/HGhbi3CZ5ou052f4=;
        b=BT1HWKG7C5hY+BqOAhKMdqkN3HC3s5m4EK8F6WkpWLmjHR7mqUFliVQZYwYOu5teo6
         W8x3j+MLpTg6128lkzfXk6pDRJukaSr3W07rRD15I21Tjp5p1O6U5uLEQbZA07dgCIP9
         O6PNUTnmDZm3dkFoxVVb9A3/Xw4P47exPpSEgORe6tRgQrjKQu7DRSpRSmo7zpP7EuxQ
         enCaOuRWZ6eG+hBBe18nxI2uKoxvc9xqQUpJrCINtGbrm3Jvrhdal8lBCzx0ka5mSNw5
         lA+Ese3ANjldU4Hk+o+IsHsut8bd2tKeVrG9rQxG5cdA/j6BYr8gAFa1VMBvOKI1Sgxr
         J/wQ==
X-Gm-Message-State: APjAAAWFRXGdRd6ZA5yMZmzgXSNNtV/jtQv1EVgRbHLiiRsqaNMjEIF8
	BLK1TNK3xjz85naBTAvZrfS+BHGfS2vQ4tgEyQtnlw==
X-Google-Smtp-Source: APXvYqw7NUBkJ3XaFn0G3lAQyQxr2X/Wu218BRJwTjxsK+YoP+KQmzF7vyk0Nef2h6VON1vRPCzb9qGy+lPqeYrPmW0=
X-Received: by 2002:a5d:65cf:: with SMTP id e15mr4305007wrw.126.1581151948951;
 Sat, 08 Feb 2020 00:52:28 -0800 (PST)
MIME-Version: 1.0
References: <20200203134010.12144-1-pete@akeo.ie>
In-Reply-To: <20200203134010.12144-1-pete@akeo.ie>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Sat, 8 Feb 2020 08:52:18 +0000
Message-ID: <CAKv+Gu8EKvWPqRs=4U3GDJz-Z8LkEpNUv6e_oGz_p1St7w_5gA@mail.gmail.com>
Subject: Re: [edk2-platforms][PATCH 1/1] Platform/RPi4: Add ACPI entry for Genet network interface
To: Pete Batard <pete@akeo.ie>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif@nuviainc.com>, 
	=?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= <philmd@redhat.com>, 
	Jeremy Linton <lintonrjeremy@gmail.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 3 Feb 2020 at 13:40, Pete Batard <pete@akeo.ie> wrote:
>
> The Raspberry Pi 4 platforms uses a Broadcom Genet network interface, for
> which we need ACPI entries in order to make it usable under Linux.
>
> This patch adds these entries, including a max-dma-burst-size DSD attribute
> aimed at simplifying support for Genet on distros that use older kernels,
> such as Debian.
>
> Note that we ran these settings through someone working for Broadcom, who
> okayed the proposed values including ownership of max-dma-burst-size (which
> we expect to also require for Device Tree usage on older kernels, hence the
> requirement for a designated owner).
>
> Signed-off-by: Pete Batard <pete@akeo.ie>
> ---
>  Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl | 29 ++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl b/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl
> index b2f1d3439211..12c3967fa9e1 100644
> --- a/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl
> +++ b/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl
> @@ -267,6 +267,35 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 5, "MSFT", "EDK2", 2)
>        }
>      }
>
> +    Device (ETH0)
> +    {
> +      Name (_HID, "BCM6E4E")
> +      Name (_CID, "BCM6E4E")

What is the point of having identical _HID and _CID? Is that a Windows thing?

> +      Name (_UID, 0x0)
> +      Name (_CCA, 0x0)
> +      Method (_STA)
> +      {
> +        Return (0xf)
> +      }
> +      Method (_CRS, 0x0, Serialized)
> +      {
> +        Name (RBUF, ResourceTemplate ()
> +        {
> +          Memory32Fixed (ReadWrite, 0xfd580000, 0x10000, )

We could grab that base address from a PCD as well, no?

> +          Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0xBD }
> +          Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0xBE }

Why not

Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0xBD, 0xBE }

?

> +        })
> +        Return (RBUF)
> +      }
> +      Name (_DSD, Package () {
> +        ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> +        Package () {
> +          Package () { "brcm,max-dma-burst-size", 0x08 },
> +          Package () { "phy-mode", "rgmii" },
> +        }
> +      })
> +    }
> +
>      // Description: I2C
>      Device (I2C1)
>      {
> --
> 2.21.0.windows.1
>