From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d44; helo=mail-io1-xd44.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2A57D21191F3D for ; Fri, 23 Nov 2018 07:17:25 -0800 (PST) Received: by mail-io1-xd44.google.com with SMTP id x6so9026102ioa.9 for ; Fri, 23 Nov 2018 07:17:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NOx1pJJiNA2VTPP10B+e2u7WQ3646cF26FRglN4pgLQ=; b=N1k9S2if7iBKinwxqb2LRAkVhHRXvO12Tk97JDc0qadR+UZ9MtOKwGId3ePYUqEriz U23eyOIKoTPkY1TBnz2XIYrmgSOkRwbtY4S+i5vof/UVSP+XpbVLdJnPpQWgd3kF34Tp +KqZ11ZsUsM6QSI1IWNuUQtMRJfxJthULGwBM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NOx1pJJiNA2VTPP10B+e2u7WQ3646cF26FRglN4pgLQ=; b=i6nhbA8/9Mr35vZi1Ly0znY/U6btix9/nTValCIYwr8jgCBGDtg7IhxXDRHgRhqv1n KjJWqB3RZwvPjaH0QgWwOJWtyE0gQfymCXQEPxw/bCcFhtu5YejkJyLKaGRblOyb/uYM n+AbCbEizMS1bbTv6qCniBtYEwqA64y6PWr67rGXRmZCH385T4xdx3uPSWqP2ew9XBXD hlGkdKta6cT87VRCUZ3LMDJyAy247yV0Uh5l7986Cw0wMaHlPWKp8a5u1GSOgIahu2Mq sd/mGzmXOA7D8Z3HnXQ6Tp9YNFVHHhJhHlFg11qcFYbW7/eKFcXdp9XQk/jC2te+/7wj YUCQ== X-Gm-Message-State: AA+aEWZcAo0Oa2xQGgWToryJ71Uf85DubCzAbfD9s0vqLBMiyyjMxX2m /IffKfAojO3hMTWzqiTjV0uwcUO2/GZP5hEDeI4xqnh9 X-Google-Smtp-Source: AFSGD/V70ukDS3f57fiXnhsVjQv/SdHgpa5jlSAAb9gFpHFP/CfJU2wT5v2suBmDu9JAlTQ6dUjhNxvXEBVZxX+EOY0= X-Received: by 2002:a6b:7a46:: with SMTP id k6mr12427271iop.60.1542986244165; Fri, 23 Nov 2018 07:17:24 -0800 (PST) MIME-Version: 1.0 References: <20181123084406.27192-1-ard.biesheuvel@linaro.org> In-Reply-To: From: Ard Biesheuvel Date: Fri, 23 Nov 2018 16:17:12 +0100 Message-ID: To: Thomas Panakamattam Abraham Cc: "edk2-devel@lists.01.org" , Laszlo Ersek , Nariman Poushin Subject: Re: [PATCH v2 edk2-platforms 0/3] Platform/ARM: fix DevicePath mishandling in BdsLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 15:17:25 -0000 Content-Type: text/plain; charset="UTF-8" On Fri, 23 Nov 2018 at 15:16, Thomas Abraham wrote: > > Hi Ard, > On Fri, Nov 23, 2018 at 2:16 PM Ard Biesheuvel > wrote: > > > > The deprecated BdsLib library class in ArmPkg is still depended upon, but > > only a single implementation exists, which now resides in edk2-platforms. > > > > This implementation has some issues in how it deals with Device Paths, > > so let's fix those, but first move over the library interface declaration > > and get rid of the parts that are no longer used. This will permit dropping > > it from ArmPkg in EDK2. > > > > Changes since v1: > > - add Laszlo's ack to #1 > > - update #2 to remove everything we no longer need from BdsLib > > - drop #3 which was bogus > > - update #4 to ensure that we only duplicate the device path when we > > are about to return EFI_SUCCESS > > > > Ard Biesheuvel (3): > > Platform/ARM: import ARM platform specific BdsLib header > > Platform/ARM/BdsLib: drop unused functions > > Platform/ARM/BdsLib: maintain alignment for DevicePaths > > > > Platform/ARM/ARM.dec | 3 + > > .../Drivers/FdtPlatformDxe/FdtPlatformDxe.inf | 2 +- > > Platform/ARM/Include/Library/BdsLib.h | 26 ++ > > Platform/ARM/Library/BdsLib/BdsAppLoader.c | 253 ---------------- > > Platform/ARM/Library/BdsLib/BdsFilePath.c | 95 +----- > > Platform/ARM/Library/BdsLib/BdsHelper.c | 122 -------- > > Platform/ARM/Library/BdsLib/BdsInternal.h | 16 +- > > Platform/ARM/Library/BdsLib/BdsLib.inf | 4 +- > > Platform/ARM/Library/BdsLib/BdsLoadOption.c | 272 ------------------ > > 9 files changed, 52 insertions(+), 741 deletions(-) > > create mode 100644 Platform/ARM/Include/Library/BdsLib.h > > delete mode 100644 Platform/ARM/Library/BdsLib/BdsAppLoader.c > > delete mode 100644 Platform/ARM/Library/BdsLib/BdsLoadOption.c > > Tested this patch series with the following two patch series applied > on the Juno board. > - [PATCH v2 0/5] ArmPlatformPkg, ArmVirtPkg: discover NOR flash banks from DTB > - [PATCH edk2-platforms 0/3] drop GUIDs from NOR flash bank descriptors > > Boot on Juno board works fine. > > For this and the other two patch series > Tested-by: Thomas Abraham > Thanks Thomas!