From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B27DE2118F784 for ; Mon, 11 Jun 2018 02:40:51 -0700 (PDT) Received: by mail-it0-x242.google.com with SMTP id 188-v6so9108622ita.5 for ; Mon, 11 Jun 2018 02:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nCVrw6c4/EOYg2b8j85pjiRWIXFN4UaHK+Q0ZBt+qF0=; b=IPPaFiCZHUR80/S8iusJ/sFKCrZykmdrHsW1/iNSh409JUiMTDNLuw2b7UcNub6fQT KZKFbF0Wiw6665wzTt+OEWGqzrsBojt04HuHjqEjNW1mooDfUaKx6jR+O4VBM7/vcNjJ E2twnOBHb3n4vY4+E6LQeQ9NoWeNFcrcAI1DM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nCVrw6c4/EOYg2b8j85pjiRWIXFN4UaHK+Q0ZBt+qF0=; b=NlZfKn5JwP+i7z0rtTwJShpaW+WDgfSEdg1Y8LtqZmN8HtOjMqlIf8KdaDDDrDU2Y2 hvTO39eIfau2TkFe2gNtNK5jZfp1NGd9qCAx9LkrfAj1DLlN8qb6ghcq9FKVSUywTWXi gxragIWhZEqg9V/N1E0zdmzz9EYWMMF+53X9T+5nSiW5bC9DZ1KD3OXjbaEAiGsqUMUJ ZLOpmvtbZcm3NN7EbUyIaNqFgGaiC1LbT6nIApORR1/ESYX/mBURH2OixMUAGmGQUpna MJv/BZDRndrVRc0V+FDZgH5j13Z8CpSCAu/z75w2gbU77apZUDDTmeW52wEWJLA/SACL mT+Q== X-Gm-Message-State: APt69E0mBFFPCgwMZrgw0DkBBgnockDe8RrPZlRc185cBhmoqr8DcMtm zOW8TCxLAD0ij30CzJ2Vo86MKpk5fwTtjGVdBnl38h67OFc= X-Google-Smtp-Source: ADUXVKIE3R4yCKJUtR1+cThLil125j3AEaQ/QGBQQvOSw8sRzLcMBE/+3KwKbGEIJW9tCX3xWOIqVpPp48CeO8F17a4= X-Received: by 2002:a24:1d0e:: with SMTP id 14-v6mr9627995itj.50.1528710050728; Mon, 11 Jun 2018 02:40:50 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Mon, 11 Jun 2018 02:40:50 -0700 (PDT) In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BB55772@shsmsx102.ccr.corp.intel.com> References: <20180607091003.8687-1-ard.biesheuvel@linaro.org> <6f89e8bc-2aef-d7d8-bec4-b491506b2a34@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BB54B8C@shsmsx102.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BB55772@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Mon, 11 Jun 2018 11:40:50 +0200 Message-ID: To: "Zeng, Star" Cc: "Wu, Hao A" , "edk2-devel@lists.01.org" , Laszlo Ersek Subject: Re: [PATCH] MdeModulePkg/EmmcDxe: demote DEBUG print to DEBUG_BLKIO X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 09:40:52 -0000 Content-Type: text/plain; charset="UTF-8" On 11 June 2018 at 11:12, Zeng, Star wrote: > Let's go to use DEBUG_BLKIO to be consistent. > > Ard, Reviewed-by: Star Zeng . > Hao, you can submit ticket on bugzilla and submit patch for NvmExpressDxe. > Thanks all Pushed as 9dca2105ad96 > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Monday, June 11, 2018 4:54 PM > To: Wu, Hao A > Cc: Zeng, Star ; edk2-devel@lists.01.org; Laszlo Ersek > Subject: Re: [edk2] [PATCH] MdeModulePkg/EmmcDxe: demote DEBUG print to DEBUG_BLKIO > > On 11 June 2018 at 10:38, Wu, Hao A wrote: >> Hi Ard, >> >> After a quick check on the behavior of other storage device drivers, >> it seems to me that they are not using the same debug levels for this >> kind of debug >> message: >> >> ATA and USB mass storage - BLKIO >> NVM Express - VERBOSE >> SD/eMMC - INFO >> SCSI - actually no such debug message >> >> My preference is to use the 'BLKIO' for the SD/eMMC case, since >> literally, it seems the best fit and the majority of the drivers are using this level. >> Or maybe we can use a combination of (DEBUG_BLKIO | DEBUG_VERBOSE). >> >> Ard and Star, what's your thought? >> > > I am happy to stick with the patch as I proposed it, i.e., DEBUG_BLKIO only > >>> -----Original Message----- >>> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >>> Sent: Monday, June 11, 2018 4:15 PM >>> To: Zeng, Star >>> Cc: edk2-devel@lists.01.org; Laszlo Ersek; Wu, Hao A >>> Subject: Re: [edk2] [PATCH] MdeModulePkg/EmmcDxe: demote DEBUG print >>> to DEBUG_BLKIO >>> >>> On 8 June 2018 at 05:15, Zeng, Star wrote: >>> > Good patch. >>> > >>> > Another choice is to use DEBUG_VERBOSE. >>> > We see other driver uses DEBUG_VERBOSE for BlockIo service (Hao can >>> comment on that). >>> > We'd better to align them for consistency. >>> > >>> >>> Hao, >>> >>> Do you have any preference regarding the exact priority level we will >>> use for this particular DEBUG() print? >>> >>> Thanks, >>> Ard. >>> >>> >>> > -----Original Message----- >>> > From: Laszlo Ersek [mailto:lersek@redhat.com] >>> > Sent: Friday, June 8, 2018 1:23 AM >>> > To: Ard Biesheuvel ; >>> > edk2-devel@lists.01.org >>> > Cc: Zeng, Star >>> > Subject: Re: [edk2] [PATCH] MdeModulePkg/EmmcDxe: demote DEBUG >>> > print >>> to DEBUG_BLKIO >>> > >>> > On 06/07/18 11:10, Ard Biesheuvel wrote: >>> >> Lower the priority of the DEBUG print in EmmcReadWrite(), which is >>> >> emitted for each read or write operation to the eMMC device, which >>> >> clutters up the log output of builds created with DEBUG_INFO enabled. >>> >> >>> >> Suggested-by: Pipat Methavanitpong >>> >> >>> >> Contributed-under: TianoCore Contribution Agreement 1.1 >>> >> Signed-off-by: Ard Biesheuvel >>> >> --- >>> >> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 5 ++++- >>> >> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >> >>> >> diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c >>> >> b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c >>> >> index e1d0f394a954..f6b230514b71 100644 >>> >> --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c >>> >> +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c >>> >> @@ -901,7 +901,10 @@ EmmcReadWrite ( >>> >> if (EFI_ERROR (Status)) { >>> >> return Status; >>> >> } >>> >> - DEBUG ((EFI_D_INFO, "Emmc%a(): Part %d Lba 0x%x BlkNo 0x%x >>> Event %p with %r\n", IsRead ? "Read " : "Write", >>> Partition->PartitionType, Lba, BlockNum, (Token != NULL) ? >>> Token->Event : NULL, Status)); >>> >> + DEBUG ((DEBUG_BLKIO, >>> >> + "Emmc%a(): Part %d Lba 0x%x BlkNo 0x%x Event %p with %r\n", >>> >> + IsRead ? "Read " : "Write", Partition->PartitionType, Lba, BlockNum, >>> >> + (Token != NULL) ? Token->Event : NULL, Status)); >>> >> >>> >> Lba += BlockNum; >>> >> Buffer = (UINT8*)Buffer + BufferSize; >>> >> >>> > >>> > Reviewed-by: Laszlo Ersek