From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6CAE7210C1EC4 for ; Wed, 25 Jul 2018 03:02:51 -0700 (PDT) Received: by mail-it0-x242.google.com with SMTP id p81-v6so7847766itp.1 for ; Wed, 25 Jul 2018 03:02:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=62sWqlddleuBZ/08A5RtXwmRsCtmWH008kflYAc6Uro=; b=F7nLRx29PZPuQ+VXB9e/5PDvJhwPSer5jX3duSndKDsdYrA4yr9ASr+o43bZINXVx7 bCWJOfG9sLwoLxKl7IZLfzgpwFlzXMl6N73Rp22iIuLXz4xBhQOVyfKx5e2wBlUz58Ej lAA2g9J5j9a6M0YxpomSF9VcDgyqRyq2kPGK4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=62sWqlddleuBZ/08A5RtXwmRsCtmWH008kflYAc6Uro=; b=WT2xGR9FS4RufqJvrrTaezLB3WIAbS9yW54Ux2KaQd63FWIRRWXyCXg+KmxsKIHbSe drbkRumJ7iiU5NAPdnE2DSRYVhtcNT9yv7mXw4FDsRqadU7ke8LRMDIaC11uC/pVZrpo XLbCmo7JDjmi1pm5cQGK0qSukFo1Itutro9kA00+29uQCYQps7sIDzD+S3V+0nlVN2nq PBCjsUWuR7tQ6soKR/a+Zh7m7RU6Si66ldEXH6MwEFIBp5JaqV6qqsFwaN7VxGhOygXm uxg//eSeTAdz8w7Up/TxMXNLjgL4C0OCTKSm8Pw5pX0ZYt8gs/OiyX9+co5zWbYxGHU7 eFgw== X-Gm-Message-State: AOUpUlE5NSBDDwXOEjv9XoKxkQ5h6T9UYP5K8AQ5BUxQpN9BvPb6qYHc gz9kjni4+KMHpSUQd8NNyWPPc2hxKSPFg+sp7YMqzQ== X-Google-Smtp-Source: AAOMgpeY6PF/WWR8qwL/WBMImZzlTFTOiF6kQkH3Mi0xAF2EeaTj5GJ8oeXd8nqNdhd1MmsGPsKZVD6EWfzgD+G5hlo= X-Received: by 2002:a24:5242:: with SMTP id d63-v6mr1227132itb.138.1532512970619; Wed, 25 Jul 2018 03:02:50 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:ac05:0:0:0:0:0 with HTTP; Wed, 25 Jul 2018 03:02:50 -0700 (PDT) In-Reply-To: <1531490984-32491-1-git-send-email-mw@semihalf.com> References: <1531490984-32491-1-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Wed, 25 Jul 2018 12:02:50 +0200 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Nadav Haklai , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk Subject: Re: [platforms: PATCH 0/6] Armada7k8k ComPhy rework X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 10:02:51 -0000 Content-Type: text/plain; charset="UTF-8" On 13 July 2018 at 16:09, Marcin Wojtas wrote: > Hi, > > This patchset makes use of the feature present in newest, > publicly available ARM-TF of the Armada7k8k SoCs > (https://github.com/MarvellEmbeddedProcessors/atf-marvell/commits/atf-v1.4-armada-18.06) > which is a common configuration of the serdes lanes. > > It is triggered by the users (UEFI/U-Boot/OS) using > the dedicated smc calls. Thanks to that the library > could have been cleaned-up and reduced to the per-board > configuration parsing part and calling the according > sequences to be done in EL3. > > The patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/comphy-upstream-r20180713 > > I'm looking forward to review and any comments/remarks. > > Best regards, > Marcin > > Grzegorz Jaszczyk (6): > Marvell/Library: ComPhyLib: Configure SATA, SGMII and SFI in ARM-TF > Marvell/Library: ComPhyLib: Configure PCIE in ARM-TF > Marvell/Library: ComPhyLib: Configure RXAUI in ARM-TF > Marvell/Library: ComPhyLib: Configure USB in ARM-TF > Marvell/Library: ComPhyLib: Clean up the library after rework > Marvell/Library: ComPhyLib: Remove both PHY and PIPE selector config > This looks fine except for the remarks I made in reply to patches #1 and #2 > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 18 +- > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.inf | 2 +- > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSampleAtResetLib/Armada7k8kSampleAtResetLib.h | 22 - > Silicon/Marvell/Include/Library/SampleAtResetLib.h | 7 - > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.h | 545 +----- > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSampleAtResetLib/Armada7k8kSampleAtResetLib.c | 19 - > Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c | 1777 +------------------- > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.c | 41 +- > Silicon/Marvell/Library/ComPhyLib/ComPhyMux.c | 132 -- > 9 files changed, 116 insertions(+), 2447 deletions(-) > delete mode 100644 Silicon/Marvell/Library/ComPhyLib/ComPhyMux.c > > -- > 2.7.4 >