From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ArmPlatformPkg: remove ArmGetCpuCountPerCluster () from ArmPlatformLib
Date: Sat, 25 Nov 2017 22:50:23 +0000 [thread overview]
Message-ID: <CAKv+Gu8F2d5_fyA4-MC=u8=_5WNCTRuOwUskH=8-FdpyNSfogA@mail.gmail.com> (raw)
In-Reply-To: <20171124170445.gd2kzjhazdwwwmjw@bivouac.eciton.net>
On 24 November 2017 at 17:04, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Wed, Nov 15, 2017 at 02:20:48PM +0000, Ard Biesheuvel wrote:
>> The only user of ArmPlatformLib's ArmGetCpuCountPerCluster () is itself
>> an ArmPlatformLib implementation, i.e., ArmVExpressLibRTSM.
>>
>> Given that we'd prefer to get rid of ArmPlatformLib entirely, let's
>> remove ArmGetCpuCountPerCluster () from the API as a first step.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> I'm thinking this is technically a bit iffy. But the less iffy way
> would be to add a local .h file to hold the prototype, which feels a
> bit crazy for a transitional thing. So:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Thanks
Pushed as 4cebe0453fea40330afb6b8f2372287e723e6e3f
prev parent reply other threads:[~2017-11-25 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 14:20 [PATCH] ArmPlatformPkg: remove ArmGetCpuCountPerCluster () from ArmPlatformLib Ard Biesheuvel
2017-11-24 17:04 ` Leif Lindholm
2017-11-25 22:50 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu8F2d5_fyA4-MC=u8=_5WNCTRuOwUskH=8-FdpyNSfogA@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox