From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::229; helo=mail-io0-x229.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8F9382034710F for ; Sat, 25 Nov 2017 14:46:05 -0800 (PST) Received: by mail-io0-x229.google.com with SMTP id q101so32646037ioi.1 for ; Sat, 25 Nov 2017 14:50:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IsLuoQl1SmCecKRa5uniQFZTItXNzzVsPRd0+It/NXE=; b=CukjdjsBb4vFA4ocAC+EpDJoOO4LOPVi/bFTEPN7vlPQcKhGfeXqEUGUtOcL8GRUfN frt6iBVMCBsmeSz+u+6qR+sr3W6JgkL+TfafrRjFYkyYYsl+dNKMIwYRfSfj+kiq516E XrS2ZkMaBht4vP/pZaba6XUwDF0gVCRaby4w8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IsLuoQl1SmCecKRa5uniQFZTItXNzzVsPRd0+It/NXE=; b=KLj6TUb46PiqahKb3mFneex8HVHBity1Hj7bX400gjHT4NGNt98XZnYgxy0VL5DFKt CgTvET185ejpFAYIXWSYUsHmN/UDXGHp6gBIEWrIEsOi/E6QN6nvXan2/0Hqk2gb8hpm fH8c88vsuRJ+3vlPCm4yCdAnuZobvSaG6+Ki/6EMqekfKux/Ns2L6cZL7TlgT56qvq// ixcQCxJCSAbOg86Gwqv2PW9dzMIFcRXmN4tgDGt7kRx8iO3Dh2BoCyLXviWRIjrIWKxC XAOtONL0Z7DEuobSrrM3HO7KvCXYD54yf3PwfM0B3UCvXjjmhqXMZ4lYS8ZK26tQH8wT Ea8g== X-Gm-Message-State: AJaThX4EeLvckB1qFfgR8eKBSP9kvoB6jR7KXZbzConcxolijxbCAen2 qebMOUiTxsrCqzbBlkzamfKCJgI+aUcSYcbK+sQqbw== X-Google-Smtp-Source: AGs4zMZJYB0kB5zCWW5j7/U7vGXv9UnPp0OrodSukNm5ZLoSfy50ruCXsJaYhue9hwxwNwxEV+E9XJp/rsguBWNIooY= X-Received: by 10.107.69.17 with SMTP id s17mr33175920ioa.253.1511650224377; Sat, 25 Nov 2017 14:50:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Sat, 25 Nov 2017 14:50:23 -0800 (PST) In-Reply-To: <20171124170445.gd2kzjhazdwwwmjw@bivouac.eciton.net> References: <20171115142048.9928-1-ard.biesheuvel@linaro.org> <20171124170445.gd2kzjhazdwwwmjw@bivouac.eciton.net> From: Ard Biesheuvel Date: Sat, 25 Nov 2017 22:50:23 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] ArmPlatformPkg: remove ArmGetCpuCountPerCluster () from ArmPlatformLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Nov 2017 22:46:05 -0000 Content-Type: text/plain; charset="UTF-8" On 24 November 2017 at 17:04, Leif Lindholm wrote: > On Wed, Nov 15, 2017 at 02:20:48PM +0000, Ard Biesheuvel wrote: >> The only user of ArmPlatformLib's ArmGetCpuCountPerCluster () is itself >> an ArmPlatformLib implementation, i.e., ArmVExpressLibRTSM. >> >> Given that we'd prefer to get rid of ArmPlatformLib entirely, let's >> remove ArmGetCpuCountPerCluster () from the API as a first step. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > I'm thinking this is technically a bit iffy. But the less iffy way > would be to add a local .h file to hold the prototype, which feels a > bit crazy for a transitional thing. So: > Reviewed-by: Leif Lindholm > Thanks Pushed as 4cebe0453fea40330afb6b8f2372287e723e6e3f