From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CA38021199553 for ; Wed, 19 Dec 2018 07:31:17 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id z7so10256834iti.0 for ; Wed, 19 Dec 2018 07:31:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=AWjHFMUscy0GAJfpZEjseFDkc/stL6QSZuMbC2GTH0I=; b=XOBKmP8Swkmd/LF2rVGJa0G3/AgpsE723FaJtR0pJoNhgZFvz9syOvOXZgzy3pW97g izJTmFFKVXpOSbPTH4Jvd29k5mFkBp0icBWmoypolnGDFitKc7iwzQHzERXLbBQ23W8u g6+E9x0AVYQ9/ST/hqwqykdb6ktf+Xom/UK1s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=AWjHFMUscy0GAJfpZEjseFDkc/stL6QSZuMbC2GTH0I=; b=Y2Owoh1aiA94DMOsnR3F66E7HaTEc4d6YfRfFKA/4bTtIPH17q7hvAinbC9m+l/OXe uIdm4d4nLRxI6B4kYKJTcsaectyYbp2/4e9WR8FiMFuF557sSAxvdJb4sH9NC4eaTssH a2SSVhq5vUT9xzdVW13PLlR9W/niWeiCxYy6c+wdrULRPZ/pzPNC3+YajE0hiBae0eCH H7wrk1WpjmBdLaMEl8azIYNk+jz1X3oBmX7LHywZsxspiY3M8xgVqCQH6u4nm0cnx05H RZxEzdstzLmATBDukh9YnMbN4jOhq4jVUqvnDDPs9kcAB6UJREYkJkaFoB9jDM7GchWU LlCw== X-Gm-Message-State: AA+aEWY9afkrGxk9I3dIFOrHXHfJ8IyPB9xRa2umvh0RnvUK5L6Ye0sP SUmI9ZUM0x/+cKmdUAOTUD5O8RsFpyrgdftTjCJOHg== X-Google-Smtp-Source: AFSGD/UsKcI/2yDYzX14EFbaLTgi/8xqYir1FxFlSG2zZnYNZ5/urDHufaXfGOUhOsfEk2jw/ynqgxvJacl9wA+UxIo= X-Received: by 2002:a02:183:: with SMTP id 3mr20130188jak.130.1545233475712; Wed, 19 Dec 2018 07:31:15 -0800 (PST) MIME-Version: 1.0 References: <20181212124842.15968-1-ard.biesheuvel@linaro.org> <20181212150254.dyncmhmb43imrat3@bivouac.eciton.net> <20181212151729.cdqz6fmw6a4ez5hh@bivouac.eciton.net> <20181219152026.z37y3oa5thzd2fp6@bivouac.eciton.net> In-Reply-To: From: Ard Biesheuvel Date: Wed, 19 Dec 2018 16:31:03 +0100 Message-ID: To: Leif Lindholm , edk2-devel-01 , Andrew Fish Subject: Re: [PATCH] EmbeddedPkg: remove GdbDebugAgent library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 15:31:19 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 19 Dec 2018 at 16:30, Ard Biesheuvel wrote: > > On Wed, 19 Dec 2018 at 16:20, Leif Lindholm wrote: > > > > On Wed, Dec 12, 2018 at 03:17:29PM +0000, Leif Lindholm wrote: > > > > Considering the commit log from its introduction > > > > > > > > """ > > > > commit 969eba7b0df70c9aa261eaf005085568b88de87c > > > > Author: andrewfish > > > > Date: Sat Apr 3 00:41:42 2010 +0000 > > > > > > > > Add the beginning of a GDB based Debug Agent. IA-32 and X64 don't have > > > > low level interrupt code yet. I've been testing on ARM. > > > > > > > > git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10334 > > > > 6f19259b-4bc3-4df7-8a09-765794883524 > > > > """ > > > > > > > > the lack of low level interrupt code in this patch, and the following > > > > snippet from the .inf > > > > > > > > """ > > > > [Sources.X64] > > > > Ia32/Processor.c > > > > > > > > [Sources.Ia32] > > > > X64/Processor.c > > > > """ > > > > > > > > I think it is safe to say that this code was never used on anything but ARM. > > > > > > I believe the same, but since we have the author of both the code and > > > that commit message easily accessible, I would like to verify before > > > we nuke it. > > > > Well, he didn't speak up for a week, and is probably riding > > wilderbeest as I type this - so yeah, go ahead. > > > > We can always revert :) > > > > Reviewed-by: Leif Lindholm > > > > Thanks > > Pushed as 5f0b035f107d..3bdc111178e1 Now with the list and Andrew in cc