public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: Pete Batard <pete@akeo.ie>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v5 edk2-platforms 00/22] Platform/RaspberryPi: Add Raspberry Pi 3 support
Date: Fri, 15 Feb 2019 12:05:16 +0100	[thread overview]
Message-ID: <CAKv+Gu8FdfFB+SEVa=-ciYBM3NmmY6_fAr2m6yHwjj0M=fxYjQ@mail.gmail.com> (raw)
In-Reply-To: <CAKv+Gu9sMTAvLF5XbYRDwjOSEMqp=TT3Ch4UW8LWvBamVhxY9w@mail.gmail.com>

On Fri, 15 Feb 2019 at 11:27, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Wed, 13 Feb 2019 at 04:50, Jeremy Linton <jeremy.linton@arm.com> wrote:
> >
> > the
> > Hi,
> >
> > On 2/5/19 10:25 AM, Pete Batard wrote:
> > > Changes for v5:
> > >
> > > * Raspberry/Pi3 -> RaspberryPi/RPi3
> > > * Remove VirtualRealTimeClockLib as well as BUILD_EPOCH macro (use the upcoming
> > >    EmbeddedPkg Virtual RTC from EDK2 instead)
> > > * Use $(PLATFORM_NAME) where possible in .dsc and .fdf
> > > * Update Readme to remove build instructions, describe ACPI limitations, fix
> > >    ATF Readme link and split OS installation & test notes into a separate file.
> > > * Add -Wl,--fix-cortex-a53-843419 to LINK_FLAGS
> > >
> > > IMPORTANT: Due to the removal of VirtualRealTimeClockLib this series requires
> > > https://lists.01.org/pipermail/edk2-devel/2019-February/036301.html to have
> > > been applied to your edk2 repository.
> >
> > I would just like to congratulate everyone working on this port. It is
> > crazy awesome! I just applied these patches, followed the readme
> > instructions for the SD card. Then grabbed a USB DVD drive, and a USB
> > SSD, plugged in a keyboard/mouse/monitor/network and booted the fedora
> > 29 1.2 install ISO. The graphical installer ran as expected, system
> > installed as expected, and other than the nextboot not being reset (had
> > to update it via the BDS, as is documented) it "just worked".
> >
> > There are a few rough edges here/there but the idea that we have another
> > ARM machine that almost behaves like one expects a modern computing
> > device to behave, is wonderful. The only real gocha continues to be the
> > rpi's well known shortcomings, including the fact that it took nearly 6
> > hours to install.
> >
> >
> > so,
> >
> > Tested-by: Jeremy Linton <jeremy.linton@arm.com>
> >
>
> Thanks Jeremy.
>
> I fully agree, and I am quite happy to have an example to point to the
> next time someone wants to contribute some 96boards UEFI port that
> looks like u-boot and only runs on the serial port

For the series

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

edk2-non-osi pieces pushed as

863a3237a74c Platform/RaspberryPi/RPi3: Add ATF binaries
9c52bc5c0f14 Platform/RaspberryPi/RPi3: Add Device Tree binaries
635f97e09aaa Platform/RaspberryPi/RPi3: Add logo driver

edk2-platforms pieces pushed as 06454982de98..94d6843f1a90

Thanks again, Pete, and everyone else for the excellent work.

/me goes and updates his blog


  reply	other threads:[~2019-02-15 11:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05 16:25 [PATCH v5 edk2-platforms 00/22] Platform/RaspberryPi: Add Raspberry Pi 3 support Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 01/22] Silicon/Broadcom/Bcm283x: Add interrupt driver Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 02/22] Silicon/Broadcom/Bcm283x: Add GpioLib Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 03/22] Platform/RaspberryPi/RPi3: Add ACPI tables Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 04/22] Platform/RaspberryPi/RPi3: Add reset and memory init libraries Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 05/22] Platform/RaspberryPi/RPi3: Add platform library Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 06/22] Platform/RaspberryPi/RPi3: Add firmware driver Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 07/22] Platform/RaspberryPi/RPi3: Add platform config driver Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 08/22] Platform/RaspberryPi/RPi3: Add SMBIOS driver Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 09/22] Platform/RaspberryPi/RPi3: Add display driver Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 10/22] Platform/RaspberryPi/RPi3: Add console driver Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 11/22] Platform/RaspberryPi/RPi3: Add NV storage driver Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 12/22] Platform/RaspberryPi/RPi3: Add Device Tree driver Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 13/22] Platform/RaspberryPi/RPi3: Add base MMC driver Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 14/22] Platform/RaspberryPi/RPi3: Add Arasan " Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 15/22] Platform/RaspberryPi/RPi3: Add SD Host driver Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 16/22] Platform/RaspberryPi/RPi3: Add platform boot manager and helper libs Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 17/22] Platform/RaspberryPi/RPi3: Add USB host driver Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 18/22] Platform/RaspberryPi/RPi3 *NON-OSI*: Add ATF binaries Pete Batard
2019-02-06 22:39   ` Kinney, Michael D
2019-02-07  0:52     ` Pete Batard
2019-02-07  2:35       ` Kinney, Michael D
2019-02-07 11:26         ` Pete Batard
2019-02-07 14:25           ` Ard Biesheuvel
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 19/22] Platform/RaspberryPi/RPi3 *NON-OSI*: Add Device Tree binaries Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 20/22] Platform/RaspberryPi/RPi3 *NON-OSI*: Add logo driver Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 21/22] Platform/RaspberryPi/RPi3: Add platform Pete Batard
2019-02-05 16:25 ` [PATCH v5 edk2-platforms 22/22] Platform/RaspberryPi/RPi3: Add platform readme's Pete Batard
2019-02-14 18:42   ` Leif Lindholm
2019-02-13  3:41 ` [PATCH v5 edk2-platforms 00/22] Platform/RaspberryPi: Add Raspberry Pi 3 support Jeremy Linton
2019-02-15 10:27   ` Ard Biesheuvel
2019-02-15 11:05     ` Ard Biesheuvel [this message]
2019-02-15 14:56       ` Pete Batard
2019-02-14 18:45 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu8FdfFB+SEVa=-ciYBM3NmmY6_fAr2m6yHwjj0M=fxYjQ@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox