From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web09.6304.1582714270159981569 for ; Wed, 26 Feb 2020 02:51:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Ye8LER2u; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f66.google.com with SMTP id t23so2470023wmi.1 for ; Wed, 26 Feb 2020 02:51:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=4xzrGBhaOUKnSdomc59wFfHHdMY70qwp7tym1caicCE=; b=Ye8LER2upn8fkOGeD77BeqQwcPSUZNIEtep30RD0+GDdaIodUM/pDqoRBrMBSFLU3A nYbbLdFAeHeVuPrNo4KIo3EEDxG7N3YdEtvIcHwg/t9Azbn4SLcumbMhVrME84+ASEjQ FbTBkfZj9rn4FhhYyDMMDPmWC/tJOQbCQz5NfeGsWVaXnOb4kyqiQ3DxKEiuMzuBa2tA b0RGJsySsNO0t4BQ4GTEdHyTvVOn0pNku6DKB3wP4ohQaj4wZZnhhwD8W4n5VSpc2T3m VfiRUCkODYegtxPRMOFs9CXL3lKXFjKTkoCV1dA1QRsYntZsrWF8clLiQhaEs79b8v4s ETNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4xzrGBhaOUKnSdomc59wFfHHdMY70qwp7tym1caicCE=; b=cNsNETzHM3Se+fOjFDXisELZ8xJgPyyIHkfBs/ks5OOJYTqaGVrQ2BK1mKH2bivbAI 7zxmgK8kudilFN0rgq9I+LWYz5twTfFv0zMIxN7EkDplxPSeE9SakNifquU438iQI5ZH v9B2ZlGOOJi8e22eedwcK2wdP4Cop2H+o9hmuxpPGsfqxaeBvjs3BZh/3KgyN8h2xqn5 4FuvI35H/h14vOknpR6zluw87kUYgqLEKRS/zk9EHCJ8jnPXQ3HPteLhML1kUoPVBo7m TEV9cISrNyD99mGrq0mrVClRQ+OQxeQm0jEZvmL3xj6KDVgN4BdqFxJtmdEaoASEEKss dvwg== X-Gm-Message-State: APjAAAW5pSfGTzvWyupGjA8o95L5YtpOc4M2qcK5KIV2whOtMCl1FoYP 5f1MnLMZ2LI5GvBorxM6UKBlOuSskC2kt3gMcudzug== X-Google-Smtp-Source: APXvYqzLQ27YzkpayP7UcUjI3ZI+GRQk8FI6fvVk8lF/CjBnSG9KWj3Nuhnj1GLv/hG486egff6nFc8DfF00mUu0zLc= X-Received: by 2002:a1c:9d43:: with SMTP id g64mr4740962wme.62.1582714268501; Wed, 26 Feb 2020 02:51:08 -0800 (PST) MIME-Version: 1.0 References: <20200225104449.22453-1-ard.biesheuvel@linaro.org> <20200225104449.22453-6-ard.biesheuvel@linaro.org> <660bb2b6-5870-68b7-4324-ec1a16b58c94@redhat.com> <3d3968a8-5b7b-8fc9-c6d1-10a9896ecd68@redhat.com> In-Reply-To: <3d3968a8-5b7b-8fc9-c6d1-10a9896ecd68@redhat.com> From: "Ard Biesheuvel" Date: Wed, 26 Feb 2020 11:50:57 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH v2 5/5] ArmVirtPkg/ArmVirtQemu: add optional support for TPM2 measured boot To: Laszlo Ersek Cc: edk2-devel-groups-io , Auger Eric , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Stefan Berger , Leif Lindholm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 26 Feb 2020 at 11:49, Laszlo Ersek wrote: > > On 02/26/20 01:40, Laszlo Ersek wrote: > > On 02/25/20 11:44, Ard Biesheuvel wrote: > >> Duplicate the TPM2_ENABLE and TPM2_CONFIG_ENABLE build time flags that > >> already exist in OvmfPkg, and wire them up in the .DSC and .FDF so > >> that setting those flags produces a ArmVirtQemu build that implements > >> measured boot using a TPM provided by QEMU and described in the device > >> tree. > >> > >> Note that the TPM2 driver stack relies on a PEI phase being implemente= d, > >> so there is no point in enabling this for ArmVirtQemuKernel or ArmVirt= Xen. > >> > >> Also note that, despite ArmVirtQemuKernel being unaffected by this pat= ch, > >> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc is being modified, for keeping th= e > >> contexts of the referring !include directives simple. > >> > >> Signed-off-by: Ard Biesheuvel > >> --- > >> ArmVirtPkg/ArmVirtQemu.dsc | 75 ++++++++++++++++++++ > >> ArmVirtPkg/ArmVirtQemu.fdf | 6 ++ > >> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 10 +++ > >> 3 files changed, 91 insertions(+) > > > > Under a similar, recent patch from Marc-Andr=C3=A9 (which proposes enab= ling > > TPM-1.2 in OvmfPkg), I asked Marc-Andr=C3=A9 to build up the work in sm= all > > steps, practically mirroring the gradual TPM2.0 stuff from OvmfPkg: > > > > * [edk2-devel] [PATCH v2 3/3] Ovmf: enable TPM 1.2 support > > > > http://mid.mail-archive.com/bbf8cf87-9c90-5507-82b3-ae8534555a54@redhat= .com > > > > https://edk2.groups.io/g/devel/message/54473 > > > > I'd like to be consistent as a review (and I indeed prefer that > > approach), so I'd like to ask you for the same. > > Please see the approach here: > > [PATCH v3 0/6] Ovmf: enable TPM 1.2 > > https://edk2.groups.io/g/devel/message/54854 > http://mid.mail-archive.com/20200226093459.1131530-1-marcandre.lureau@red= hat.com > Ah ok. Apologies for missing the link I think I can emulate that - no worries.