From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C4D812243694D for ; Fri, 23 Feb 2018 07:56:48 -0800 (PST) Received: by mail-io0-x242.google.com with SMTP id l12so10270612ioc.10 for ; Fri, 23 Feb 2018 08:02:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UP1l5l0WhyKxNJGYie32hXz/qvyBFJbg7Q19Zlfkel4=; b=HuctSJOiHQNXhaQYnG4WSzNsgFzv0SDI6PjTHS2s9kz0mH7FuGUA1WKBVCHMJ6vk4X BOA0u5eAjcWjn7oVOc6ltqF5xc5CJzpWe9JJMTZn5hDcMFZ+fMqhtw9BJ8TldObWwWQo r/oSz0RAxM1uPri8IFu5RY2sz4QkGpqEFvgho= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UP1l5l0WhyKxNJGYie32hXz/qvyBFJbg7Q19Zlfkel4=; b=WkQWCvNP6B0p9Bhyk6Nm4nJAvEIsTb/qHyig1LF+TR4fbW6k0S3B0hcLGb+8JOsIt2 QXNLYzjeeCTLID9VtPO9XR/2vSMApgd3hZ6gG1NlR0h68RgUiCX1Yvc/wogeTdzEmzVy mb7IBxvagw3oLWRngFKmttKaTKdGDR0I4W9snoZZTOEZU5C8KsaUEi8RUdFTkq8WkvU2 bj+Kf5abjBOG7gObCPzaHUX+BM71f3VVPEHWfygznyQwh8eTnrIsSgL1IahVd+WX86Jc Dj18VJ95uUtCkXb23O7F4jk+3mRJ0wNwBoayFNFvCyGm3sWl0lO1qz6y9WOH5Xg8uxw/ 0yyg== X-Gm-Message-State: APf1xPBd151P58s+LahgoDuJRJeOKwArA1r8+GdchJXDCmHQVJTcwZ4a nShOhgoosupH0K2LKhsJ+jCIg9FIV0CN7LUWryaoCw== X-Google-Smtp-Source: AG47ELtdIAOMBaBNnLFgDVVmQK5eD0wLjLn1FL8CJKQ0nDWjOfWJMUiL+9MiiMk2yrxgqvy9r5sUG0Xia8BEHTuMGxE= X-Received: by 10.107.56.69 with SMTP id f66mr2271865ioa.170.1519401769911; Fri, 23 Feb 2018 08:02:49 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Fri, 23 Feb 2018 08:02:49 -0800 (PST) In-Reply-To: <20180223155638.72ef2rrv5r2wmeqj@bivouac.eciton.net> References: <20180223154052.9828-1-ard.biesheuvel@linaro.org> <20180223155638.72ef2rrv5r2wmeqj@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 23 Feb 2018 16:02:49 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms v3 0/6] Add Secure96 mezzanine support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2018 15:56:49 -0000 Content-Type: text/plain; charset="UTF-8" On 23 February 2018 at 15:56, Leif Lindholm wrote: > On Fri, Feb 23, 2018 at 03:40:46PM +0000, Ard Biesheuvel wrote: >> This v3 (as did v2) implements a complete split between the generic >> 96boards LS connector support and its associated plumbing (defining which >> I2C, SPI and GPIO controllers are connected) on the one hand, and support >> for the Secure96 mezzanine board in particular on the other. More >> specifically, all Secure96 PCDs were dropped, and the only platform >> specific configuration that remains is including the Secure96 driver >> and the driver for its peripherals to the build. >> >> v3: >> - The ATSHA204A driver has been merged, so it has been dropped from this >> series. >> - Rename Platform/NinetySixBoards back to Platform/96Boards. Note that in >> some places, using leading digits is problematic so the string does still >> occur in a couple of places. >> - Rebase onto EDK2 that has the MultiPhase.h VFR changes. > > All of my feedback has been addressed, so for the series: > Reviewed-by: Leif Lindholm > > If we get enum support in VfrCompile in the future, a minor cleanup to > the code introduced by 5/6 will be possible, but this is an excellent > start to a generic mezzanine infrastructure - thanks! Thank you Pushed as 487015fb23c1..d8e4d4565841