* [edk2-platforms][PATCH 1/1] Platform/RPi4/Acpi: Use "rgmii-rxid" phy-mode for Genet
@ 2020-02-25 10:27 Pete Batard
2020-02-25 10:39 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Pete Batard @ 2020-02-25 10:27 UTC (permalink / raw)
To: devel; +Cc: ard.biesheuvel, leif, philmd
"rgmii-rxid" is what the Linux folks use in their Device Tree so we follow
suit. This fixes packet losses and unreliable network connections which we
experienced when testing the Linux Genet driver.
Signed-off-by: Pete Batard <pete@akeo.ie>
---
Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl b/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl
index 12c3967fa9e1..8d2938a6596c 100644
--- a/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl
+++ b/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl
@@ -291,7 +291,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 5, "MSFT", "EDK2", 2)
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package () { "brcm,max-dma-burst-size", 0x08 },
- Package () { "phy-mode", "rgmii" },
+ Package () { "phy-mode", "rgmii-rxid" },
}
})
}
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-platforms][PATCH 1/1] Platform/RPi4/Acpi: Use "rgmii-rxid" phy-mode for Genet
2020-02-25 10:27 [edk2-platforms][PATCH 1/1] Platform/RPi4/Acpi: Use "rgmii-rxid" phy-mode for Genet Pete Batard
@ 2020-02-25 10:39 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2020-02-25 10:39 UTC (permalink / raw)
To: Pete Batard
Cc: edk2-devel-groups-io, Leif Lindholm, Philippe Mathieu-Daudé
On Tue, 25 Feb 2020 at 11:27, Pete Batard <pete@akeo.ie> wrote:
>
> "rgmii-rxid" is what the Linux folks use in their Device Tree so we follow
> suit. This fixes packet losses and unreliable network connections which we
> experienced when testing the Linux Genet driver.
>
> Signed-off-by: Pete Batard <pete@akeo.ie>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed as f1b7a923a037..5250e8b05e1a
Thanks Pete
> ---
> Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl b/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl
> index 12c3967fa9e1..8d2938a6596c 100644
> --- a/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl
> +++ b/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl
> @@ -291,7 +291,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 5, "MSFT", "EDK2", 2)
> ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> Package () {
> Package () { "brcm,max-dma-burst-size", 0x08 },
> - Package () { "phy-mode", "rgmii" },
> + Package () { "phy-mode", "rgmii-rxid" },
> }
> })
> }
> --
> 2.21.0.windows.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-25 10:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-25 10:27 [edk2-platforms][PATCH 1/1] Platform/RPi4/Acpi: Use "rgmii-rxid" phy-mode for Genet Pete Batard
2020-02-25 10:39 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox