From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9DB4521E0B9E0 for ; Tue, 6 Feb 2018 01:53:34 -0800 (PST) Received: by mail-io0-x241.google.com with SMTP id d13so1884620iog.5 for ; Tue, 06 Feb 2018 01:59:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2CxGXxH20VjdDSEnIUJPNPBrc3HjuDEMKnN50udAWlg=; b=QZorGooH2F2m95S5//s1u3bpLgavPJ0AY/0elzCICosr9uz0M+5BNm+6Qa4uBwMCA8 9asZgbU3Fsyu20RH3FB6RXuXr6CNKrpKxrxeCiXpi7tJ6ykVQhynZQKsKYgsjHn9pgG4 +6mUJIzRNJtHXhwJo33ThQWsY0xxbestkUPDc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2CxGXxH20VjdDSEnIUJPNPBrc3HjuDEMKnN50udAWlg=; b=q0dq9HKI4TdJAdNIgZjZqolsPnXVJIy7LJNsWBqqOYGFxj2X0OOATHsVB0TQyWIbZv 6lUbUhachgSVTv0q2DsWukQqqrXBwYFqkfqnlfonUI6he4xI84wg0P0B7sbL3tYpSaCI 75JAGOLPCnynmk423A+5tUsx1h7lckbrtBUgywr3mzFJQW2WRyqfXfrKUa9pNMve95Kc uxO4v42IFmrh2QqdWrSeQ42wTgjimoxReI3tfHPInxMfMn9x3qpn4NbdkjYP+o8wEh/X i6xGO/tbbJ9Cr59MQMDPRl5wpbQOvOVz9ZKUdJuiAuYZGTfd37WoMKqSpHopHdBb+Gkx G/tQ== X-Gm-Message-State: APf1xPDjSO7MDRd/Q7nMO0AIBrFmbFOsGramC9RBIi0HUXrgvRfqNigH IJZWbA2/qo6mfZF1y3TuRyJmdEC5cmfxMOoz/T5mgA== X-Google-Smtp-Source: AH8x2279CxRH+AKD5GFrmEstA0Wo6cT7663tWKJym5g+SSwONzY4gfBQvoI16sFD82ofyFSb21MCQ/TGg+h32k5F2zM= X-Received: by 10.107.20.194 with SMTP id 185mr2146706iou.127.1517911156612; Tue, 06 Feb 2018 01:59:16 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Tue, 6 Feb 2018 01:59:16 -0800 (PST) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1C7B37@SHSMSX104.ccr.corp.intel.com> References: <20180201111513.13572-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E1C7B37@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Tue, 6 Feb 2018 09:59:16 +0000 Message-ID: To: "Gao, Liming" Cc: Laszlo Ersek , "edk2-devel@lists.01.org" , "Zhu, Yonghong" Subject: Re: [PATCH v2] BaseTools/Conf: disable DTC legacy phandle format X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 09:53:35 -0000 Content-Type: text/plain; charset="UTF-8" On 6 February 2018 at 03:05, Gao, Liming wrote: > Reviewed-by: Liming Gao > Thanks. Pushed as 34a4ddda4d61ede41f575510dc5adcf933d3b6f5 >>-----Original Message----- >>From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >>Sent: Monday, February 05, 2018 9:59 PM >>To: Laszlo Ersek >>Cc: edk2-devel@lists.01.org; Gao, Liming ; Zhu, >>Yonghong >>Subject: Re: [PATCH v2] BaseTools/Conf: disable DTC legacy phandle format >> >>On 1 February 2018 at 16:53, Laszlo Ersek wrote: >>> On 02/01/18 12:15, Ard Biesheuvel wrote: >>>> By default, the device tree compiler emits phandle properties twice: >>>> one called 'phandle' and another called 'linux,phandle'. Given that >>>> Linux was updated in early 2010 [0] to accept the former (which is >>>> what is specified in the ePAPR and device tree specifications), there >>>> is no point in emitting both when compiling device trees for UEFI >>>> platforms. >>>> >>>> [0] 04b954a673dd02f585a2769c4945a43880faa989 >>>> "of/flattree: Make the kernel accept ePAPR style phandle information" >>>> >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> Signed-off-by: Ard Biesheuvel >>>> --- >>>> BaseTools/Conf/build_rule.template | 2 +- >>>> BaseTools/Conf/tools_def.template | 1 + >>>> 2 files changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/BaseTools/Conf/build_rule.template >>b/BaseTools/Conf/build_rule.template >>>> index 3e6aa8ff0f34..a5e471eb3c10 100755 >>>> --- a/BaseTools/Conf/build_rule.template >>>> +++ b/BaseTools/Conf/build_rule.template >>>> @@ -250,7 +250,7 @@ >>>> >>>> >>>> "$(PP)" $(DTCPP_FLAGS) $(INC) ${src} > ${d_path}(+)${s_base}.i >>>> - "$(DTC)" -I dts -O dtb -o ${dst} ${d_path}(+)${s_base}.i >>>> + "$(DTC)" $(DTC_FLAGS) -I dts -O dtb -o ${dst} ${d_path}(+)${s_base}.i >>>> >>>> [Visual-Form-Representation-File] >>>> >>>> diff --git a/BaseTools/Conf/tools_def.template >>b/BaseTools/Conf/tools_def.template >>>> index 482ef263c274..99ad271471d9 100755 >>>> --- a/BaseTools/Conf/tools_def.template >>>> +++ b/BaseTools/Conf/tools_def.template >>>> @@ -4467,6 +4467,7 @@ NOOPT_DDK3790xASL_IPF_DLINK_FLAGS = >>/NOLOGO /NODEFAULTLIB /LTCG /DLL /OPT:REF >>>> DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu- >>debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug >>>> RELEASE_*_*_OBJCOPY_ADDDEBUGFLAG = >>>> NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu- >>debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug >>>> +*_*_*_DTC_FLAGS = -H epapr >>>> >>>> DEFINE GCC_ALL_CC_FLAGS = -g -Os -fshort-wchar -fno-builtin -fno- >>strict-aliasing -Wall -Werror -Wno-array-bounds -include AutoGen.h -fno- >>common >>>> DEFINE GCC_IA32_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -m32 - >>malign-double -freorder-blocks -freorder-blocks-and-partition -O2 -mno- >>stack-arg-probe >>>> >>> >>> Reviewed-by: Laszlo Ersek >> >>Thank you. >> >>Liming, any comments?