From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1AEE2203564A6 for ; Tue, 28 Nov 2017 23:52:43 -0800 (PST) Received: by mail-io0-x241.google.com with SMTP id h12so2773628iof.6 for ; Tue, 28 Nov 2017 23:57:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=NTS/BR0YLfJAfT9fvbX/w4R1juYI+wXLZ6qMAMp9qNk=; b=VHdDSchpPiWU2PT7hzemVIOiMtxmTXR0zph9dv6Q6W/xhfPQY5Hq8Mue4GRPHYiPX6 LUeHRYVQq/wkrcSjDmwy30qkAIKJAs7GAY8bHGnLnQFHix6+cWZlYz1cu5Ra0H0tQX+2 AM2JNvIZF5ZcdPDTU4KtwiDplsCZ1LY5tmkVA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NTS/BR0YLfJAfT9fvbX/w4R1juYI+wXLZ6qMAMp9qNk=; b=kQrsQWrQLrWY4uVvav4eqR8BCu32hPauOASjS8XDzDDqN0u+8LnWZf1jV6TRwMguDE sut6JvwqDoopPP5agyXrcDhW4k0aKg7K0TBClpccwDgiflmP0Mui7Vt0kThs0sI5Pp+R Ps04bZXVqUwhlHtxrPsLNaY0kgunOwCPdCaBKRxUncFC8c3Ob9D1sHkD6yd9oJeMCv9n GISg+0AhmvR9dd4ONGP7cg6yZA3ZOgZRhyP1cV2zYOMzVTVwJF4ncgl2yzfb7+xx2L4W xQcBHG0HryNAbN5UW2QZLDlytO+YBZwfqRI/W8u7WimCHDxpOOQwOZDDm3NFzzNmuvA+ fTtQ== X-Gm-Message-State: AJaThX5DcTYY+73cws9zvWqEkb+d4jvxMbvHNfKFMXptHbGbM+iUaQMD 56BnnW/do2PCs0oLUbojnj/ikujNJZ6HZLTej/SOVg== X-Google-Smtp-Source: AGs4zMZPs9aW1wChSptj8WWllrqzz8hsP3PkP+aexay5TzvAz9v8+B//6xUEo/torYZI8Hlll3rxhZT7qo6xeb2ZWLs= X-Received: by 10.107.151.142 with SMTP id z136mr2381642iod.248.1511942226771; Tue, 28 Nov 2017 23:57:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Tue, 28 Nov 2017 23:57:06 -0800 (PST) In-Reply-To: <20171129005952.208940-5-ruiyu.ni@intel.com> References: <20171129005952.208940-1-ruiyu.ni@intel.com> <20171129005952.208940-5-ruiyu.ni@intel.com> From: Ard Biesheuvel Date: Wed, 29 Nov 2017 07:57:06 +0000 Message-ID: To: Ruiyu Ni Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH v3 4/6] BeagleBoardPkg: Fix build failure due to Tftp library removal X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 07:52:44 -0000 Content-Type: text/plain; charset="UTF-8" On 29 November 2017 at 00:59, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Leif Lindholm > Cc: Ard Biesheuvel > --- > BeagleBoardPkg/BeagleBoardPkg.dsc | 16 +++++++++------- > BeagleBoardPkg/BeagleBoardPkg.fdf | 3 ++- > 2 files changed, 11 insertions(+), 8 deletions(-) > > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc > index 4f7c0bd645..d67ccf377e 100644 > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc > @@ -2,7 +2,7 @@ > # Beagle board package. > # > # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.
> -# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
> # Copyright (c) 2016, Linaro Ltd. All rights reserved.
> # > # This program and the accompanying materials > @@ -355,11 +355,6 @@ [PcdsFixedAtBuild.common] > # OMAP Interrupt Controller > gEmbeddedTokenSpaceGuid.PcdInterruptBaseAddress|0x48200000 > > - # We want to use the Shell Libraries but don't want it to initialise > - # automatically. We initialise the libraries when the command is called by the > - # Shell. > - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > - Why are you moving this? The TFTP shell library is not the only user of this PCD. > gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|10 > > # GUID of the UEFI Shell > @@ -487,6 +482,14 @@ [Components.common] > NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf > } > + > + # > + # Shell > + # > + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { > + > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > + } > ShellPkg/Application/Shell/Shell.inf { > > ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf > @@ -497,7 +500,6 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > - NULL|ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf > diff --git a/BeagleBoardPkg/BeagleBoardPkg.fdf b/BeagleBoardPkg/BeagleBoardPkg.fdf > index c9c6afd714..71249c7eb3 100644 > --- a/BeagleBoardPkg/BeagleBoardPkg.fdf > +++ b/BeagleBoardPkg/BeagleBoardPkg.fdf > @@ -1,7 +1,7 @@ > # FLASH layout file for Beagle board. > # > # Copyright (c) 2009, Apple Inc. All rights reserved.
> -# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
> # Copyright (c) 2016, Linaro, Ltd. All rights reserved.
> # > # This program and the accompanying materials > @@ -178,6 +178,7 @@ [FV.FvMain] > # UEFI application (Shell Embedded Boot Loader) > # > INF ShellPkg/Application/Shell/Shell.inf > + INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > > # > # Bds > -- > 2.15.0.gvfs.1.preview.4 >