From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A1B8B203555F8 for ; Mon, 13 Nov 2017 02:11:16 -0800 (PST) Received: by mail-it0-x243.google.com with SMTP id n134so183910itg.3 for ; Mon, 13 Nov 2017 02:15:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=VbNpZU8tCvDCCmnF3Mf/KLwk6u6UiQGguIT+d30T/qk=; b=Ib8a5/cHu9td6UO5bnJhmRK7LYYnoqT9q1h7wK9OUdRRwJyGYluEk+et4wcX4GlyL8 ZBPP0IYMu0ZAfZpxSCwc17eiXwnZuu/z3mAsavh7LFZidGOQF3z/8Oxp0lgzR1cVpZk4 H8kqNFte/H1iEBusTQ6oZeXLlZ5kB0zQ4AaH8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VbNpZU8tCvDCCmnF3Mf/KLwk6u6UiQGguIT+d30T/qk=; b=mBYm47P477ErNcJdcb1RyN29ULX8WvyBVoNxSyfwXk8oJdKPxEgQj2UNhXDHzWiGbH N4CPxuNH/3AmjMxzBdJx7MrCaJC2NukHGlIt9RCkISNy1H1QFor2OFjefq42k1Baokwa I2BDLtY/uIfpXUlS++WuT1n0TfR+D/ioCbcOqkFU7nXpP/dLCHS2p4e1uMpXOCRIQw76 raL7X4jOaL3kM8G5+cWieWibwdNJedypjz+DiqknrbEGx/bTdUNu2YTIDpWltSFTqml5 58e5f5svon90Iz2EDw0EWCWxVwUHlxLccOXKF6Q8lGUrutt4ZFMRBvUIXymCLvXdn/fi eIVw== X-Gm-Message-State: AJaThX69PR6rqotHrMSzoaCD8wzwYzisS+/qM+G9aDzWGsu8xgYUMnqS hl5nbM9u0IMtgT6QXni6Xstnov7T9rd6misRh6NrUQ== X-Google-Smtp-Source: AGs4zMZbZKo0UTRpNeoFapB/xQnS8Gzky7AdBhuRfcfu+yklTdqO8f1OCVU3BIKiU93IhuFBdy6LxNWcGPsP5WMWtoY= X-Received: by 10.36.48.4 with SMTP id q4mr9800927itq.34.1510568121905; Mon, 13 Nov 2017 02:15:21 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.20 with HTTP; Mon, 13 Nov 2017 02:15:21 -0800 (PST) In-Reply-To: <1510299092-38746-2-git-send-email-huangming23@huawei.com> References: <1510299092-38746-1-git-send-email-huangming23@huawei.com> <1510299092-38746-2-git-send-email-huangming23@huawei.com> From: Ard Biesheuvel Date: Mon, 13 Nov 2017 10:15:21 +0000 Message-ID: To: Ming Huang Cc: Leif Lindholm , linaro-uefi , "edk2-devel@lists.01.org" , Graeme Gregory , "guoheyi@huawei.com" , wanghuiqiang , huangming , Jason Zhang , Mengfanrong , waip23@126.com, Liu Yi Subject: Re: [PATCH edk2-non-osi v2] Hisilicon D0x: Remove uncacheable attribute from memory resource HOB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2017 10:11:16 -0000 Content-Type: text/plain; charset="UTF-8" On 10 November 2017 at 07:31, Ming Huang wrote: Please do something about the name/email address. These should be in sync. > If uncacheable attribute is included in memory resource HOB, > GCD spaces will also have EFI_MEMORY_UC capability, > then NonCoherentPciIoAllocateBuffer of NonDiscoverablePciDeviceDxe > module will allocate DMA buffer of EFI_MEMORY_UC type, which will > cause alignment fault exception with BaseMemoryLibOptDxe. > > This not only affects NonDiscoverablePciDeviceDxe, it removes the > UC attribute from all DRAM regions in the UEFI memory map, > which makes much more sense on ARM > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liu Yi > Signed-off-by: Heyi Guo And here. The contents look fine. > --- > Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi | Bin 90272 -> 90336 bytes > Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi | Bin 152576 -> 152480 bytes > 2 files changed, 0 insertions(+), 0 deletions(-) > > diff --git a/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi > index 354abcc..31e2903 100644 > Binary files a/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi differ > diff --git a/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi > index b94e0cb..eb71c44 100644 > Binary files a/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi differ > -- > 1.9.1 >