From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=WvUWDqiH; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by groups.io with SMTP; Thu, 26 Sep 2019 05:16:41 -0700 Received: by mail-wm1-f65.google.com with SMTP id y21so2347101wmi.0 for ; Thu, 26 Sep 2019 05:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1THCbnAJ2titKwn3rTRT5FALNGQiRzxVpkWH6n96DEM=; b=WvUWDqiH1lZhsJyL7DQZeH4RG0kbflnQI8z8EUnq9oERcSYOAyTXGSjfg4XTXb6bhB tVS0LKKQpbUtqF124CWb8IeHNn+9UtYx75qHcGgLrusYFlqbfXQdMPVVN0uoXXBTNgEg VpQZ9DY9HMpqciKKVKhwgoYNT12StXDzWJUD/H5Z4WcSgjQ1pW9ZPNn0csD3SZ79enKB EZc3evElMyXlANIbrx6kYlagX1COgTpR538hitnE1zpzth1RoNn3yxzPWdVrr0MvjQGn GndvUI24y9XFjzvLxBJVca0l0cPlNk+O/TdxktI5Vv53FT2zw9UyHh5IdwxqtdvCDjps XbTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1THCbnAJ2titKwn3rTRT5FALNGQiRzxVpkWH6n96DEM=; b=jB30ldBj221690ErJkLv3xPzGAGi7FFGaU1HBJ0eLesdsMcB9ljYwHmaAdp0aGJ6Wl a7wngCI3dAuk2dHc6kb65rI3h156GlyBX8xtL6GOqL2phmPhZI6b0NgcUbneYu7km/7W s9/u8J9rNnsMc1KsfBLeul+1soZZJC0rQBVu8hf1HybZ5LPrnwknHxt+WKcLSIrVtCZQ IBAJEjobAUNnXX3kqyuygcJxmPmg+ke4TwD2Kyac8YzN4HMp056FzrNrYjvD6HxjOvo0 CII/R1AgV0ROL7Hvn4boJNOMYpc80I9wuXV+GkOtfqwBwCv3TtsZM6UmmCAGCxJYMqJT cybQ== X-Gm-Message-State: APjAAAXOgcgcmF9ry9kO6JZcZXU727+jY9MFHcjCGuR2GmsJagIjGbjR B0pyzAjYkF2RtD0XBVDpBLa2klRXqeINJ+7x3f3YeQ== X-Google-Smtp-Source: APXvYqzQ4ZwKm6zBhVFPqcjv22KWVpap5bYMslAgnyB5oR0vkI0V9IGxznGac0tb5SfcJEeloiyZCw9N5ztcJJS/I8g= X-Received: by 2002:a1c:e906:: with SMTP id q6mr2598492wmc.136.1569500199544; Thu, 26 Sep 2019 05:16:39 -0700 (PDT) MIME-Version: 1.0 References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-4-lersek@redhat.com> In-Reply-To: <20190917194935.24322-4-lersek@redhat.com> From: "Ard Biesheuvel" Date: Thu, 26 Sep 2019 14:16:28 +0200 Message-ID: Subject: Re: [PATCH 03/35] EmbeddedPkg/AndroidFastbootTransportTcpDxe: fix DestroyChild() call To: Laszlo Ersek Cc: edk2-devel-groups-io , Leif Lindholm Content-Type: text/plain; charset="UTF-8" On Tue, 17 Sep 2019 at 21:49, Laszlo Ersek wrote: > > - The 2nd parameter of EFI_SERVICE_BINDING_CREATE_CHILD is: > > IN OUT EFI_HANDLE *ChildHandle > > - The 2nd parameter of EFI_SERVICE_BINDING_DESTROY_CHILD is: > > IN EFI_HANDLE ChildHandle > > Fix the DestroyChild() call in TcpFastbootTransportStop(). > > This is an actual bugfix; I don't know why the current code doesn't crash. > Perhaps the function is never reached in practice? (It could be tied to an > error path.) > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Laszlo Ersek Acked-by: Ard Biesheuvel > --- > > Notes: > build-tested only > > EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > index 29f23a82c75f..34f9ba74e4db 100644 > --- a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > +++ b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > @@ -503,7 +503,7 @@ TcpFastbootTransportStop ( > Status = mTcpListener->Configure (mTcpListener, NULL); > ASSERT_EFI_ERROR (Status); > > - Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, &mTcpHandle); > + Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, mTcpHandle); > > // Free any data the user didn't pick up > Entry = (FASTBOOT_TCP_PACKET_LIST *) GetFirstNode (&mPacketListHead); > -- > 2.19.1.3.g30247aa5d201 > >