From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=jYtCdPCD;
 spf=pass (domain: linaro.org, ip: 209.85.166.68, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68])
 by groups.io with SMTP; Fri, 17 May 2019 08:44:52 -0700
Received: by mail-io1-f68.google.com with SMTP id s20so5840235ioj.7
        for <devel@edk2.groups.io>; Fri, 17 May 2019 08:44:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=0ffC7obgVKXCemaZDoJvQiO+ijVut5z7OJTm1YtWkI4=;
        b=jYtCdPCD44st1Q9qb/iHBZJgyrkJQIl1a5cXD/CutY4ygzqylADuEAqzfi0nUcR/Mw
         DeHMIZYexy7ZKndFMtT5nNlNsfyRg8i9mJSqGL22CO+X5ljCJvbKt3XcKMyxPydtlQAV
         W0kB2bAScSOam2pLITVPqy29V6lGhJvrJ2j24tE+VUvatudin3rTvHT2xbzDRt7yDQpb
         ewSTXwtaJRnyQp1LrYn+C0/MpZSc1RDfbdhuZGuFOPKY1QYCnbPIVkgrxE4K9edqFkIU
         CxJ8UNfZGqef7pqzTriU/XPgVo0PjUpHwufX5WqySkcc93SL3QXLD4SY1w3wpw+JoIg5
         E92w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=0ffC7obgVKXCemaZDoJvQiO+ijVut5z7OJTm1YtWkI4=;
        b=hfp4lb97gg6mDbI0zu4LDgGpNSJFZFETTnEW6Ued+Ftb/rQN/BKxgA3LUiZ6uxcXOo
         pPyEiPA1MqEpJlQgmuU5xWG9rQhaATbgdpJQiMClTE7rORyXcnc3sWoIaza0YtbwNqhk
         1l62Y/Q4zQeIUN1Gj4epDnhNLtSSa7PUeudgF9UTDpfCbxCi+GItRtrgdrmvmcIgPf4k
         eMB+KcUE8rjvRHZyBi501PAFUOJPEH73wFUjYK6DRFJ4CTSvqkuannVOajaNbi71beMc
         YGjv/zukHUTHY3A1v362I2B0s/EEjzFyUimrPlyceAM2f63+DXXxmbgEmQXioSWxZ3uf
         Q8rg==
X-Gm-Message-State: APjAAAWdrA7ASqpwgjGy97Dsfy6QN6OvahAts0y05dwOVB4reBX7G/rc
	s4xp3e7CzNBscx6u54f3iF9DU0BXkduPoUTooZK9dQ==
X-Google-Smtp-Source: APXvYqzIOO7twAV4v8K+ayQcRvEeLogAamM/dkUkYTZ900lXKLafX+86bilRlfew+grf4DwF+gzY4BiwcMUkSmnUeX0=
X-Received: by 2002:a5d:968e:: with SMTP id m14mr241990ion.49.1558107892012;
 Fri, 17 May 2019 08:44:52 -0700 (PDT)
MIME-Version: 1.0
References: <20190514020831.7728-1-hao.a.wu@intel.com> <20190514020831.7728-16-hao.a.wu@intel.com>
In-Reply-To: <20190514020831.7728-16-hao.a.wu@intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Fri, 17 May 2019 17:44:40 +0200
Message-ID: <CAKv+Gu8JU=_BYvPv0nbiC3eKh8p5L6VcqQcNH2Q4=mSx-_8C6A@mail.gmail.com>
Subject: Re: [edk2-platforms][PATCH v1 13/16] Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg
To: Hao A Wu <hao.a.wu@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif.lindholm@linaro.org>, 
	Michael D Kinney <michael.d.kinney@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 14 May 2019 at 04:08, Hao A Wu <hao.a.wu@intel.com> wrote:
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
>
> This commit will update the DSC file to consume the LzmaDecompressLib in
> MdeModulePkg, instead of using the one in IntelFrameworkModulePkg.
>
> Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no
> functional impact for this commit.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  Platform/LeMaker/CelloBoard/CelloBoard.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> index bc2f3e2076..bb68763743 100644
> --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> @@ -475,7 +475,7 @@ DEFINE NUM_CORES    = 4
>    MdeModulePkg/Universal/Variable/Pei/VariablePei.inf
>    MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
>      <LibraryClasses>
> -      NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> +      NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
>    }
>
>    #
> --
> 2.12.0.windows.1
>