Re: [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 12 April 2018 at 02:55, Laszlo Ersek <lersek@redhat.com> wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: depex_fixes
>
> ArmVirtQemu boots again, it just took a few more patches than I expected
> :)
>
> Some of these patches will have to be ported to edk2-platforms, I think.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Steve Capper <steve.capper@linaro.org>
> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
>
> Thanks,
> Laszlo
>
> Laszlo Ersek (10):
>   Omap35xxPkg/InterruptDxe: replace CPU Arch Protocol depex with notify
>   ArmPkg/ArmGicDxe: annotate protocol usage in "ArmGicDxe.inf"
>   ArmPkg/CpuDxe: order CpuDxe after ArmGicDxe via protocol depex
>   EmbeddedPkg: introduce NvVarStoreFormattedLib
>   ArmPlatformPkg/NorFlashDxe: initialize varstore headers eagerly
>   ArmPlatformPkg/NorFlashDxe: cue the variable driver with
>     NvVarStoreFormatted
>   ArmPlatformPkg/NorFlashDxe: depend on gEfiCpuArchProtocolGuid
>   ArmPlatformPkg/PL031RealTimeClockLib: depend on
>     gEfiCpuArchProtocolGuid
>   ArmVirtPkg/PlatformHasAcpiDtDxe: depend on
>     gEfiVariableArchProtocolGuid
>   ArmVirtPkg/ArmVirtQemu: hook NvVarStoreFormattedLib into
>     VariableRuntimeDxe
>

Laszlo,

Thanks a lot for taking care of this. I am glad we finally got rid of
the BEFORE depex in the NOR flash driver, which has been problematic
for years.

For the series,

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

but please allow some time for Leif to chime in as well.

Thanks,
Ard.



>  ArmPkg/ArmPkg.dec                                                      |  2 -
>  ArmPkg/Drivers/ArmGic/ArmGicDxe.inf                                    |  8 +-
>  ArmPkg/Drivers/CpuDxe/CpuDxe.inf                                       |  2 +-
>  ArmPlatformPkg/ArmPlatformPkg.dec                                      |  4 -
>  ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c                       | 13 +---
>  ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.h                       |  6 --
>  ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf                     |  7 +-
>  ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c                    | 22 +++---
>  ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf |  5 +-
>  ArmVirtPkg/ArmVirtQemu.dsc                                             |  1 +
>  ArmVirtPkg/ArmVirtQemuKernel.dsc                                       |  1 +
>  ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf               |  2 +-
>  EmbeddedPkg/EmbeddedPkg.dec                                            |  3 +
>  EmbeddedPkg/Include/Guid/NvVarStoreFormatted.h                         | 39 ++++++++++
>  EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.c    | 41 ++++++++++
>  EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf  | 52 +++++++++++++
>  Omap35xxPkg/InterruptDxe/HardwareInterrupt.c                           | 81 +++++++++++++++-----
>  Omap35xxPkg/InterruptDxe/InterruptDxe.inf                              |  6 +-
>  18 files changed, 230 insertions(+), 65 deletions(-)
>  create mode 100644 EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
>  create mode 100644 EmbeddedPkg/Include/Guid/NvVarStoreFormatted.h
>  create mode 100644 EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.c
>
> --
> 2.14.1.3.gb7cf6e02401b
>