From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 185A9226EAC87 for ; Thu, 12 Apr 2018 03:09:47 -0700 (PDT) Received: by mail-it0-x243.google.com with SMTP id x144-v6so1975225itc.0 for ; Thu, 12 Apr 2018 03:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1zMQ7CX0WWcU542/GTMmm92gj2GUNxe55K94n/ySmqI=; b=X+okQU3NYb4APCxeHZ6s4/z6PqKqzwuyHLSgbVZyxbW42YBqfU3NTif9QsC3r/EWbB zuVN7PHV3K2hf37S9K2XT4cKvp7H7VZUmy/Zy5daDy2PBsrsD086cOKMHpVnRkGmmf2B DdvRlwor3ZuuGxJPpsneIPM1An6/VR2h3pTLA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1zMQ7CX0WWcU542/GTMmm92gj2GUNxe55K94n/ySmqI=; b=SA1cX2OnT2uQoqRhSn2iD1Zd8JMYxslOoqPGrDUzUFSc7OVWGgDgzNyW6uhI5wmqQ7 5BSlQU25ZNs63vXD/ptW48wdn8pe4bZX+WjXuO6A/9I5Hi3l/4LjCDFWGyoRf0Kay0s3 zbJ3WouLhTmULSaOP9N9PpjKTriDN2lav/YtEU+Wqe+XNOc0LgYBEO4qTi5j4jjHu/00 JdIQi7HJ2srYJDsZaeRdxtxv42dFFcnwGP7fNxX5QlRp7wsqIH6J7c7giNhYTLZ4nDp/ rWqmTVrXNym0gXnJh3FNLhKHmMJm6RlnFkc+6PO4ARcUstveuOKkXF1YyEza4hpLiQq8 dMRQ== X-Gm-Message-State: ALQs6tBp1+NJEuTz+4uzEJhL82+9XhYOynN4C1fuCsvB10rO9/AmqOH6 ZHEshPdiM633AslBcTf2sSUU8vf66fP2FKye19wNUtz4 X-Google-Smtp-Source: AIpwx48JCwMvJ5ssAa/ArB3QwkcMdOLDv4VftZL2j9A83SMD8XPsT346w78jsuoDAE5vTSJbpn2zNN2HsGXAXEDwE30= X-Received: by 2002:a24:d98d:: with SMTP id p135-v6mr225926itg.106.1523527786464; Thu, 12 Apr 2018 03:09:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Thu, 12 Apr 2018 03:09:46 -0700 (PDT) In-Reply-To: <20180412005540.26651-1-lersek@redhat.com> References: <20180412005540.26651-1-lersek@redhat.com> From: Ard Biesheuvel Date: Thu, 12 Apr 2018 12:09:46 +0200 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Steve Capper , Supreeth Venkatesh Subject: Re: [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 10:09:47 -0000 Content-Type: text/plain; charset="UTF-8" On 12 April 2018 at 02:55, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: depex_fixes > > ArmVirtQemu boots again, it just took a few more patches than I expected > :) > > Some of these patches will have to be ported to edk2-platforms, I think. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Steve Capper > Cc: Supreeth Venkatesh > > Thanks, > Laszlo > > Laszlo Ersek (10): > Omap35xxPkg/InterruptDxe: replace CPU Arch Protocol depex with notify > ArmPkg/ArmGicDxe: annotate protocol usage in "ArmGicDxe.inf" > ArmPkg/CpuDxe: order CpuDxe after ArmGicDxe via protocol depex > EmbeddedPkg: introduce NvVarStoreFormattedLib > ArmPlatformPkg/NorFlashDxe: initialize varstore headers eagerly > ArmPlatformPkg/NorFlashDxe: cue the variable driver with > NvVarStoreFormatted > ArmPlatformPkg/NorFlashDxe: depend on gEfiCpuArchProtocolGuid > ArmPlatformPkg/PL031RealTimeClockLib: depend on > gEfiCpuArchProtocolGuid > ArmVirtPkg/PlatformHasAcpiDtDxe: depend on > gEfiVariableArchProtocolGuid > ArmVirtPkg/ArmVirtQemu: hook NvVarStoreFormattedLib into > VariableRuntimeDxe > Laszlo, Thanks a lot for taking care of this. I am glad we finally got rid of the BEFORE depex in the NOR flash driver, which has been problematic for years. For the series, Reviewed-by: Ard Biesheuvel but please allow some time for Leif to chime in as well. Thanks, Ard. > ArmPkg/ArmPkg.dec | 2 - > ArmPkg/Drivers/ArmGic/ArmGicDxe.inf | 8 +- > ArmPkg/Drivers/CpuDxe/CpuDxe.inf | 2 +- > ArmPlatformPkg/ArmPlatformPkg.dec | 4 - > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c | 13 +--- > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.h | 6 -- > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf | 7 +- > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c | 22 +++--- > ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf | 5 +- > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf | 2 +- > EmbeddedPkg/EmbeddedPkg.dec | 3 + > EmbeddedPkg/Include/Guid/NvVarStoreFormatted.h | 39 ++++++++++ > EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.c | 41 ++++++++++ > EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf | 52 +++++++++++++ > Omap35xxPkg/InterruptDxe/HardwareInterrupt.c | 81 +++++++++++++++----- > Omap35xxPkg/InterruptDxe/InterruptDxe.inf | 6 +- > 18 files changed, 230 insertions(+), 65 deletions(-) > create mode 100644 EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf > create mode 100644 EmbeddedPkg/Include/Guid/NvVarStoreFormatted.h > create mode 100644 EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.c > > -- > 2.14.1.3.gb7cf6e02401b >