From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::22a; helo=mail-it0-x22a.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x22a.google.com (mail-it0-x22a.google.com [IPv6:2607:f8b0:4001:c0b::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 408EE223CCEF5 for ; Thu, 1 Feb 2018 08:37:18 -0800 (PST) Received: by mail-it0-x22a.google.com with SMTP id b5so4956684itc.3 for ; Thu, 01 Feb 2018 08:42:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/mbz9xF5/N0G/PChJtHH4q8nWJUzp3bq2Ld+7AHvL7Q=; b=KydYlys2tSWRB2HTXP3SQfh1gomdSpgWw/Jh9Ngj6onJTz9tXm5LnLauRypAqE0guN gpd5RElFVcWViQK30BNp3vBj2IXpuiAUcAX3rVVGpnltCf2NscBACvnahkrhcckHaNfX 8e41Qw9p1nesOqSbOnyXaJNRzRIahUuaiEs4M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/mbz9xF5/N0G/PChJtHH4q8nWJUzp3bq2Ld+7AHvL7Q=; b=EcWBE9sCSqpT9N8jN2V7WahWFMkNfkOWcvKgxlQpD9GvLQdnGgwGfp3TctHBes7ZRl 748sT4C3mdYMksA0iN6Oj2E/mAFXXP+h4vPDT+afkup7dICe/iO7q49roVTtI3QYyyRn iuyw2IbvvkmZunpEbZ65ikZvxnRFnoRrX29Bj+3LSpQG7VwoPqCv2nz2vIXgXpE+fVtA gXcUaTm3+IdP83oP7VvlYecpH/sdWZNmN1zepgdr6888rhAFdA5036PXhVohAG26zwcy bAi6Zo2vJQByI8DWTsyaIsfv4TyP4Q1Q1ofGcsLSxGIGnel6fJ3SiWzIczQp7LSQOyNU VRTQ== X-Gm-Message-State: AKwxytd07717+MF1ZzWsi2mIgfJMgiP9CJZO4bUAPjS5k/HZazfxvCnP 8t0OV4hzrXVeh4aWZs8RCF4IChYXcbzzfbiAjPO9WrAh X-Google-Smtp-Source: AH8x226MMZzmjKTEPLfSeCG9+3KF6NaJBM3h7mnK7zTu+5loqas0euVozl88Ptdb8C242wz2TtttSSqNoiaqn8h16Yg= X-Received: by 10.36.139.134 with SMTP id g128mr10946280ite.59.1517503374307; Thu, 01 Feb 2018 08:42:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Thu, 1 Feb 2018 08:42:53 -0800 (PST) In-Reply-To: <20180201160435.3010-3-ard.biesheuvel@linaro.org> References: <20180201160435.3010-1-ard.biesheuvel@linaro.org> <20180201160435.3010-3-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Thu, 1 Feb 2018 16:42:53 +0000 Message-ID: To: "edk2-devel@lists.01.org" Cc: Leif Lindholm , Alan Ott , Marc Zyngier , Ard Biesheuvel Subject: Re: [PATCH edk2-non-osi 2/2] Silicon/AMD/Styx: update ArmTrustedFirmware.bin X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 16:37:18 -0000 Content-Type: text/plain; charset="UTF-8" On 1 February 2018 at 16:04, Ard Biesheuvel wrote: > The ARM Trusted Firmware build we have been using up until now was built > with optimizations disabled (which means every variable manipulation > involves a load, the operation itself and a store), and runs with the > MMU disabled, making it needlessly slow. > > This appears to be due to the fact that > a) the page tables are not set up correctly, so not all memory can be > accessed from EL3 > b) the handling of SMC service calls does not take into account that > these calls may be made with the MMU off (e.g., by UEFI PEI). > > These issues have been fixed in the source code, which should hopefully > remove any performance bottlenecks that may become more noticeable now > that we are going to call into the secure firmware more often to perform > Spectre variant 2 mitigations, which have been backported as well. > > So update the binary image to a RELEASE build that was created with > optimizations enabled, and has the above fixes incorporated. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Silicon/AMD/Styx/ArmTrustedFirmware.bin | Bin 75344 -> 34320 bytes > 1 file changed, 0 insertions(+), 0 deletions(-) > Note to Marc: this is the exact image I shared with you as bl31.bin-release earlier today, so if that works as expected, could you report back here please? Thanks.