From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=ffpO8EXH;
 spf=pass (domain: linaro.org, ip: 209.85.166.194, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f194.google.com (mail-it1-f194.google.com [209.85.166.194])
 by groups.io with SMTP; Tue, 28 May 2019 00:27:04 -0700
Received: by mail-it1-f194.google.com with SMTP id i63so2410957ita.3
        for <devel@edk2.groups.io>; Tue, 28 May 2019 00:27:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=YEb08XDtPecbUivFtBfNsVZ+jOVocJXw0S3QGc/pJEs=;
        b=ffpO8EXH92U/BeJY1ZyQ3hUsOCyqBC/5H1YMetqEb20XqcirH3QBpj5EvIk3eFc+xq
         n1Q4VmrwkPYpolTkb/oebsnyWhk9mqbZSlw05Q/Qlz+tQ+/IqsgPRqT/hRLgoXHawQX8
         krIgSXiZGmLlFeW3ExyOshG3TN/YXjfVBZrkKemMVNqG8y7dPTd/b1J95X9ajEy3n4US
         I/iFGMCPRCwtQBlHc0GqQa+Rk3gy5DG1AqoiqURZwMwOTZVOkn2/yMj24pkHzf/1EtIg
         j22HcuQBY4rwzHfFMbDKNceo1sbctSd658mvLcYfEj7hzcoTZQY5wJ1aaGDfVi3DgAB1
         tUtw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=YEb08XDtPecbUivFtBfNsVZ+jOVocJXw0S3QGc/pJEs=;
        b=E42s46TxL8zqQAcVV3Dl2ceZxibrrKoTdumLk2qb54JE0Sg1NV2+SYkW2u+qMEaA7e
         jI57l+fobyh3hsKuD/2fMJ8kdrex1Z8nLBr5zWuIZNfnu1fXd5o/p6iXp34l7XS2dmwm
         JQayp3H62CgLOybNcRCSsVmdhZuECj0BKOIfatkrGLKqm/jRBo3iGrMEAeQJMsjyLUKk
         3l0dJLhiCAgDnPyngUZWGxGO0Pq+1NXOawVc1gz5E5SLVs7Ka/goDoZbJ3EwsOrCmi7J
         laJL2HD4MYkpDQErtyWNWECDaZPKkVCDz/2ont9RVW7tD0FMZWbgWUIfkYyFQS35XRby
         82mQ==
X-Gm-Message-State: APjAAAVvMNvI9mb+F33aPr0RZtrj1b4gIJQJCgYRj36QPBw5PdjCYwE1
	F9nvv6SMPlsaz3Lj0sSgCBDE3mWE0gQfiBJyRgcQkg==
X-Google-Smtp-Source: APXvYqy2+opd2GUacHIpBuQ3AlbKoPrBvhQi814bRb5MzCr4I+5IP24wN6+Kdnpk1tGxzxAaQSKwaXhoR17vLnGskeY=
X-Received: by 2002:a24:ca84:: with SMTP id k126mr1971892itg.104.1559028424108;
 Tue, 28 May 2019 00:27:04 -0700 (PDT)
MIME-Version: 1.0
References: <20190528071711.18956-1-liming.gao@intel.com>
In-Reply-To: <20190528071711.18956-1-liming.gao@intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Tue, 28 May 2019 09:26:52 +0200
Message-ID: <CAKv+Gu8LKBDA4GsNb5sjsh0kx5eR5ErJatOkGH70GsWuLx-6hA@mail.gmail.com>
Subject: Re: [edk2-platform patch] Platform: Update DeveloperBox.dsc to remove unnecessary Network libraries
To: Liming Gao <liming.gao@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>
Content-Type: text/plain; charset="UTF-8"

On Tue, 28 May 2019 at 09:17, Liming Gao <liming.gao@intel.com> wrote:
>
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc     | 1 +
>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 9 ---------
>  2 files changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> index e100700f6e..e32309327f 100644
> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> @@ -26,6 +26,7 @@
>    # Network definition
>    #
>    DEFINE NETWORK_TLS_ENABLE      = FALSE

Please change this to TRUE: that was the situation before the
NetworkPkg change was applied.

> +  DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE
>
>    DEFINE DEBUG_ON_UART1          = FALSE
>    DEFINE SECURE_BOOT_ENABLE      = FALSE
> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> index fdb25f4566..a10e48ca07 100644
> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> @@ -40,12 +40,6 @@
>
>    BaseMemoryLib|MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf
>
> -  # Networking Requirements
> -  NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
> -  DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf
> -  UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf
> -  IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf
> -
>    # ARM Architectural Libraries
>    CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf
>    DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLib.inf
> @@ -104,9 +98,6 @@
>    SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
>    PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
>
> -  HttpLib|MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.inf
> -  TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf
> -
>    NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
>    NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>
> --
> 2.13.0.windows.1
>