From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::143; helo=mail-it1-x143.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x143.google.com (mail-it1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AEE292116821B for ; Thu, 20 Dec 2018 00:52:58 -0800 (PST) Received: by mail-it1-x143.google.com with SMTP id c9so1736007itj.1 for ; Thu, 20 Dec 2018 00:52:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MwugIQPouzZUsuYvyhTF5g165FdCde6P0t8wYIYuIN0=; b=bUrdBijbnRBnQAPnITmc43hjz7z2KXymX+YALe40ifwYLupW7FJ9kkWuuiO5b/vJve KoQ7r7+7dqoJXiYU1sgxRnNdptbLVPDu/engdjk7JJZSbQv5GyFoSkfqx09sDQyMI3nu rnRepCug14NmRZKuSJmWLGHXukqzQJSNLRmQs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MwugIQPouzZUsuYvyhTF5g165FdCde6P0t8wYIYuIN0=; b=h/wYoQaFycdXKhbdf2nSA7JkNoePBcTMd3SAka/j0RwbJwMAHD8nSUea/JE5RbNlga UD6MATuPYuZLt8C6IkMMNQDNVVu1flWRfC+DST0JslUmkiZ9UxSprZYtPRNJ531ahQ4f ge3jr4XWlhPPLPL/WKYb9tJFgrJ/fI1J/j5VPzx4bxa2qqssHpJ5ER/MbVmpaCRkwNec B+2vK+SM8WkDA1J6cdK6bkSsioulzmQWzvCW4t3eeD0mDqBSuHK7VDgKwZWaBz4kEpH1 mU/+H2bEee2pFXq6ZxLZ4EL4nT5AM320+v6a9oodYMQprOSPa6HkodNz+ZqebQy2uHvs b//Q== X-Gm-Message-State: AA+aEWaIoeHnS3TAEJYtcX37x5PGvoZbsWzNh6YD0frGDD3Qzo4NQBkq IS7H03E0wYbXDro4tSUpgVztwj9tLvUDVoIpypeyvA== X-Google-Smtp-Source: AFSGD/XU0u0iDQcAFtMmxHylfvLXd+qF6mjwt6KfTvCJ6CmHZGtncfF+ExHCqtEd8sSpclw+WchRmSbwRio/jWWCNcE= X-Received: by 2002:a24:710:: with SMTP id f16mr8420404itf.121.1545295977639; Thu, 20 Dec 2018 00:52:57 -0800 (PST) MIME-Version: 1.0 References: <1545284878-21417-1-git-send-email-sughosh.ganu@arm.com> <1545284878-21417-4-git-send-email-sughosh.ganu@arm.com> In-Reply-To: <1545284878-21417-4-git-send-email-sughosh.ganu@arm.com> From: Ard Biesheuvel Date: Thu, 20 Dec 2018 09:52:46 +0100 Message-ID: To: Sughosh Ganu Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH edk2-platforms v2 3/3] Platform/ARM/SgiPkg: Enable MmCommunication module on the platform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 08:52:58 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 20 Dec 2018 at 06:48, Sughosh Ganu wrote: > > The ArmMmCommunication module is used for communication between > non-secure and secure world using Arm's Management Mode > Specification. Enable this module on Sgi platforms. This would be used > subsequently by the RAS and SecureBoot features, support for which > is to be added on the platform. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sughosh Ganu > --- > Platform/ARM/SgiPkg/SgiPlatform.dsc | 18 ++++++++++++++++++ > Platform/ARM/SgiPkg/SgiPlatform.fdf | 5 +++++ > 2 files changed, 23 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc > index 7995c7d132d6..948b75631a00 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc > @@ -197,6 +197,20 @@ [PcdsFixedAtBuild.common] > gArmSgiTokenSpaceGuid.PcdVirtioNetSize|0x10000 > gArmSgiTokenSpaceGuid.PcdVirtioNetInterrupt|204 > > +!if $(ARM_STANDALONE_MM_ENABLE) == TRUE Why is this inclusion conditional (here and below)? I was under the impression that the communicate driver fails gracefully if the secure standalone MM is absent. If this is not the case, please propose how to fix the core driver so that it does. > + # > + # Set the base address and size of the buffer used > + # for communication between the Normal world edk2 > + # with StandaloneMm image at S-EL0 through MM_COMMUNICATE. > + # This buffer gets allocated in ATF and since we do not have > + # a mechanism currently to communicate the base address and > + # size of this buffer from ATF, hard-code it here > + # > + ## MM Communicate > + gArmTokenSpaceGuid.PcdMmBufferBase|0xFF600000 > + gArmTokenSpaceGuid.PcdMmBufferSize|0x10000 > +!endif > + > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform > @@ -331,3 +345,7 @@ [Components.common] > # SATA Controller > # > MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > + > +!if $(ARM_STANDALONE_MM_ENABLE) == TRUE > + ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > +!endif > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf b/Platform/ARM/SgiPkg/SgiPlatform.fdf > index 80c3412fd4ad..01799de8a0c8 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.fdf > +++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf > @@ -169,6 +169,11 @@ [FV.FvMain] > # > INF ShellPkg/Application/Shell/Shell.inf > > +!if $(ARM_STANDALONE_MM_ENABLE) == TRUE > + # MM Communicate > + INF ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > +!endif > + > # > # Platform driver > # > -- > 2.7.4 >