From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=pkYlW7U9;
 spf=pass (domain: linaro.org, ip: 209.85.166.193, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f193.google.com (mail-it1-f193.google.com [209.85.166.193])
 by groups.io with SMTP; Thu, 23 May 2019 09:36:16 -0700
Received: by mail-it1-f193.google.com with SMTP id u186so9489833ith.0
        for <devel@edk2.groups.io>; Thu, 23 May 2019 09:36:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=/sTKmzOnc8yw5uR5LQxnyma+HIUZKuGI5JbfJ5WSjlQ=;
        b=pkYlW7U9CKBdPTjDPB1KEXj5xHLOl85qfPauzCpv+SYaAbab+R4HO8XuPYni98axYv
         QWSfMDrBvGo9rob2FhOdbM1rYHSMrTjlJ7mPyBuBa3Y2NNuWi/apsMz25bFTALlp+GUo
         Zy1Kr80b6BwILW3cKhm9gcmJ6+roOMAYev5ZTXfJW2JxC6zc7GOC116JGZp7Y6eOeLVP
         8EmczC9zqwtFUTO2KOaBb2elg8BGIFqF7oKNyyAU7+Ph6oa8e+jYUrT+FdnmdFNPCSWB
         Lf0GY5ewcz+GGpOilPn+P7F4WBoemUzoruBVeIwsT688qEe1WNpeAN8tWioy55KR6AlU
         D0zQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=/sTKmzOnc8yw5uR5LQxnyma+HIUZKuGI5JbfJ5WSjlQ=;
        b=Bre6sT1LspWr9Cja19hDpLrQHWbAK1O+q98zeY1OvPj5CdSkzqbXmUKYc8vSUwIF5T
         5ILxQonIlOFTiuOspKLJW/xY5/zxNapXtHFPQMPO7GepWy6rId1VLLI93PpQ4If+krXj
         WfG25fUO1cGD/v9jK7gGT//bzIJvhyixrZAv+YsHlksLGt3LK7ac6zamN0OzPFMv47Af
         9YXCC9J/Ddpu6Tfdd8xr9cC9lqROMOFlsFXocgFL21Tu9aLNK+2K8hGJW9idcTjoMU3w
         df0OLfSUCQ+htwf0pymd6MsWfbu9PZ0qTi98CTnv2W2rB0wzV6adOW/MwtoXHCQbxWJu
         O0dg==
X-Gm-Message-State: APjAAAXfMZL3Ooybrq7KUdnxY0ET60IkDJbxR+k7V63HgIDdxmri0Eu/
	xX9x3dsOsYXaXWcb9v6JhOhzFKLgTLtP5QPld4LVsA==
X-Google-Smtp-Source: APXvYqxL7Ks8vvX+XhM94t/nMk8YIn4e/E6E3qQTmygfqGRrcDM9chOqSfp7dZsX+XH6xeQBY8xTpYTazJsrgIslJsk=
X-Received: by 2002:a24:d00e:: with SMTP id m14mr13079744itg.153.1558629375221;
 Thu, 23 May 2019 09:36:15 -0700 (PDT)
MIME-Version: 1.0
References: <20170419142520.16571-1-leif.lindholm@linaro.org>
 <CAKv+Gu_O20d=vrNb6pgXQRcforCZk=ocTMZEcY48=ECSxLxbQw@mail.gmail.com> <20190523162443.eqbgnfqbrndc3t7e@bivouac.eciton.net>
In-Reply-To: <20190523162443.eqbgnfqbrndc3t7e@bivouac.eciton.net>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Thu, 23 May 2019 17:36:03 +0100
Message-ID: <CAKv+Gu8MOxU8L7+9auObUzs16Sot6VZi4dmznJQjgm+ZUATUGg@mail.gmail.com>
Subject: Re: [edk2] [RFC PATCH] OptionRomPkg: import MarvelYukonDxe driver
To: Leif Lindholm <leif.lindholm@linaro.org>, 
	Thomas Panakamattam Abraham <thomas.abraham@arm.com>, edk2-devel-groups-io <devel@edk2.groups.io>, 
	Alan Ott <alan@softiron.co.uk>
Cc: Robin Murphy <robin.murphy@arm.com>, Ruiyu Ni <ruiyu.ni@intel.com>, 
	Michael D Kinney <michael.d.kinney@intel.com>, Andrew Fish <afish@apple.com>
Content-Type: text/plain; charset="UTF-8"

(cc the correct list)

On Thu, 23 May 2019 at 17:24, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Tue, May 21, 2019 at 02:38:47PM +0100, Ard Biesheuvel wrote:
> > (+ Robin)
> >
> > On Wed, 19 Apr 2017 at 15:25, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > >
> > > The Marvell Yukon Ethernet controller driver has existed in
> > > OpenPlatformPkg for a while now. The chip exists on plug-in cards,
> > > as well as (at least) the ARM Juno development board and the
> > > Softiron 1000 platform.
> > >
> > > Buildable as a standalone driver, also as EBC.
> > >
> > > Contributed-under: TianoCore Contribution Agreement 1.0
> > > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> >
> > Given that all of OptionRomPkg has been moved out of edk2 now, can we
> > resurrect this driver in edk2-platforms/Silicon/Marvell perhaps?
>
> Yes. The only thing holding it back was me wishing to either improve
> on its coding style conformance or at least separate the imported bits
> from the UEFI glue. The history of that driver isn't great.
>
> At the same time, as you commented on the DwEmax driver, separation
> between MAC and PHY would be a nice thing to have, and that driver
> also doesn't.
>

Yes, but since no generic abstraction exists today, this is going to
be a longer term effort anyway, and so it shouldn't block
reintroduction of this driver.

> Then again, the driver is fairly well tested and seems to work OK, so
> if someone was to resubmit the final version from
> https://git.linaro.org/uefi/OpenPlatformPkg.git, reworked for
> edk2-platforms, I might just go along with it.
>

OK, so taking the existing code and making it build in edk2-platforms
is not going to be a huge amount of work, and I'm happy to look into
that, provided that there is a point to doing so.

Robin brought this up so I assume he has an interest in this.

Thomas, Alan, could you comment as well, please?

Also, who is in charge of providing firmware updates to ARM Juno
updates these days, now that the Linaro ARM landing team is no longer
in charge of that?