From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::144; helo=mail-it1-x144.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC70521A02937 for ; Tue, 27 Nov 2018 02:05:39 -0800 (PST) Received: by mail-it1-x144.google.com with SMTP id h193so32870204ita.5 for ; Tue, 27 Nov 2018 02:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=msbMOF3F+z6e89PLSYVTEzzbfOvKW+Dh7BP1f/0Fizo=; b=UPsJHXHKTZWCCTSzQuUJjrjTSMfcNb1F9LDf3T/mibRQEEpaL/Zy4i+MY08AoyMgAH V9OD374m77WZmkLs+j7JrqaYg6ipJu+kLDsviPCzLbWvuDjKf81MLTvWNrksuW/WNNIb ZBJy92vCG9OssDbrPhPoYP5H8jwg0iml27jXg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=msbMOF3F+z6e89PLSYVTEzzbfOvKW+Dh7BP1f/0Fizo=; b=UJhvP+EYlEZ3R7SJBKgqWDlHuRQT+S7rR2CUE/g3V9oVzxJQC8AxFWcNReB6L7QHN1 oszX+2d8/Vr5ViExycZH47isY8k57K/b24rjX9xRe2UdBrnJoNo/SxmHrGyJGtTLNHy/ PRSA3BFWIQzjoIORj2WH6rYGbxjwEiYZjmn+k8G9zM6iP/WzRi6MDceSLFlotZIKRBWF npAdO3EekX9MfY1LRsL0LD8DEdkhzMqxVrwr4qQiwU3yFLD4iuJX+rpQwvi+bOTW79S1 ugwS3mSWB1fHqNXmAYTzEKL1PZYZFj49f9Ssllyo7F075yailFDnGUKxgDPFZQwEn8QH OOyA== X-Gm-Message-State: AGRZ1gJ0auZkjB92KGq+4c9ReNLYaN/C3xrJy7TOKBZ+cIvkXl3BvEpZ aW6IzHsBzypO+D5+icxzFi8/XGUGPdWDMYat+e/THw== X-Google-Smtp-Source: AJdET5fG2iFIhFt6WqURBnu0o3q8ruapIjRSO+SE7bcqe+Px3sQNzT7zqyUNN13WyTT/YiH7U8YGxuJf+kiIGgbZKJY= X-Received: by 2002:a05:660c:4b:: with SMTP id p11mr27687631itk.71.1543313138493; Tue, 27 Nov 2018 02:05:38 -0800 (PST) MIME-Version: 1.0 References: <1543299564-25266-1-git-send-email-sughosh.ganu@arm.com> <1543299564-25266-6-git-send-email-sughosh.ganu@arm.com> <20181127083603.GA27029@arm.com> <20181127085021.GB27029@arm.com> <20181127095843.GC27029@arm.com> <20181127100451.GD27029@arm.com> In-Reply-To: <20181127100451.GD27029@arm.com> From: Ard Biesheuvel Date: Tue, 27 Nov 2018 11:05:27 +0100 Message-ID: To: Sughosh Ganu Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH v4 5/5] ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 10:05:40 -0000 Content-Type: text/plain; charset="UTF-8" On Tue, 27 Nov 2018 at 11:04, Sughosh Ganu wrote: > > On Tue Nov 27, 2018 at 11:00:51AM +0100, Ard Biesheuvel wrote: > > On Tue, 27 Nov 2018 at 10:58, Sughosh Ganu wrote: > > > > > > On Tue Nov 27, 2018 at 10:28:50AM +0100, Ard Biesheuvel wrote: > > > > On Tue, 27 Nov 2018 at 09:50, Sughosh Ganu wrote: > > > > > > > > > > On Tue Nov 27, 2018 at 09:38:24AM +0100, Ard Biesheuvel wrote: > > > > > > On Tue, 27 Nov 2018 at 09:36, Sughosh Ganu wrote: > > > > > > > > > > > > > > hi Ard, > > > > > > > > > > > > > > On Tue Nov 27, 2018 at 09:14:52AM +0100, Ard Biesheuvel wrote: > > > > > > > > On Tue, 27 Nov 2018 at 07:20, Sughosh Ganu wrote: > > > > > > > > > > > > > > > > > > From: Achin Gupta > > > > > > > > > > > > > > > > > > The Standalone MM environment runs in S-EL0 in AArch64 on ARM Standard > > > > > > > > > Platforms. Privileged firmware e.g. ARM Trusted Firmware sets up its > > > > > > > > > architectural context including the initial translation tables for the > > > > > > > > > S-EL1/EL0 translation regime. The MM environment will still request ARM > > > > > > > > > TF to change the memory attributes of memory regions during > > > > > > > > > initialization. > > > > > > > > > > > > > > > > > > The Standalone MM image is a FV that encapsulates the MM foundation > > > > > > > > > and drivers. These are PE-COFF images with data and text segments. > > > > > > > > > To initialise the MM environment, Arm Trusted Firmware has to create > > > > > > > > > translation tables with sane default attributes for the memory > > > > > > > > > occupied by the FV. This library sends SVCs to ARM Trusted Firmware > > > > > > > > > to request memory permissions change for data and text segments. > > > > > > > > > > > > > > > > > > This patch adds a simple MMU library suitable for execution in S-EL0 and > > > > > > > > > requesting memory permissions change operations from Arm Trusted Firmware. > > > > > > > > > > > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > > > > > Signed-off-by: Sughosh Ganu > > > > > > > > > --- > > > > > > > > > ArmPkg/ArmPkg.dec | 1 + > > > > > > > > > ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/XenArmGenericTimerVirtCounterLib.inf => ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf | 23 +-- > > > > > > > > > ArmPkg/Include/Library/{ArmMmuLib.h => StandaloneMmMmuLib.h} | 38 +--- > > > > > > > > > ArmPkg/Library/StandaloneMmMmuLib/Aarch64/ArmMmuStandaloneMmLib.c | 185 ++++++++++++++++++++ > > > > > > > > > 4 files changed, 203 insertions(+), 44 deletions(-) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > +#endif /* __STANDALONEMM_MMU_LIB__ */ > > > > > > > > > diff --git a/ArmPkg/Library/StandaloneMmMmuLib/Aarch64/ArmMmuStandaloneMmLib.c b/ArmPkg/Library/StandaloneMmMmuLib/Aarch64/ArmMmuStandaloneMmLib.c > > > > > > > > > new file mode 100644 > > > > > > > > > index 000000000000..d7d87b7d5d69 > > > > > > > > > --- /dev/null > > > > > > > > > +++ b/ArmPkg/Library/StandaloneMmMmuLib/Aarch64/ArmMmuStandaloneMmLib.c > > > > > > > > > @@ -0,0 +1,185 @@ > > > > > > > > > +/** @file > > > > > > > > > +* File managing the MMU for ARMv8 architecture in S-EL0 > > > > > > > > > +* > > > > > > > > > +* Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. > > > > > > > > > +* > > > > > > > > > +* This program and the accompanying materials > > > > > > > > > +* are licensed and made available under the terms and conditions of the BSD License > > > > > > > > > +* which accompanies this distribution. The full text of the license may be found at > > > > > > > > > +* http://opensource.org/licenses/bsd-license.php > > > > > > > > > +* > > > > > > > > > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > > > > > > > > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > > > > > > > > > +* > > > > > > > > > +**/ > > > > > > > > > + > > > > > > > > > +#include > > > > > > > > > +#include > > > > > > > > > > > > > > > > Why do you need this include? If you can drop it, can you also make > > > > > > > > the library generic (i.e., supporting ARM as well as AArch64) ? > > > > > > > > > > > > > > > > (apologies for not spotting this before) > > > > > > > > > > > > > > I can remove the header file if it is superfluous. But regarding your > > > > > > > comment on making this code generic for Arm as well, i guess we > > > > > > > can work on refactoring the code when/if we actually require to > > > > > > > support this on Arm. I am not sure if we are going to have a use-case > > > > > > > for StandaloneMM on Arm. Currently, we are only supporting it on > > > > > > > Aarch64 based platforms. Is that fine. Please let me know. Thanks. > > > > > > > > > > > > > > > > > > > I'd strongly prefer this code to be generic if you are not using any > > > > > > AArch64 specific facilities. > > > > > > > > > > > > AFAICT, we'd simply need to move the file out of the AArch64 directory > > > > > > and rename [Sources.AARCH64] to [Sources] in the .inf file if the > > > > > > header dependency is indeed superfluous. > > > > > > > > > > There are a couple of places where we use something like > > > > > ARM_SVC_ID_SP_GET_MEM_ATTRIBUTES_AARCH64. Apart from this, it is > > > > > generic. > > > > > > > > > > > > > And how do these deviate from their AArch32 counterparts? > > > > > > ARM_SVC_ID_SP_GET_MEM_ATTRIBUTES_AARCH64 is passing a SMC64 based smc > > > call as an argument to S-EL1 shim layer, which will subsequently make > > > an smc call. We have a couple of functions (GetMemoryPermissions and > > > RequestMemoryPermissionChange) which are passing these SMC64 based smc > > > id's. I believe we would be required to define separate Function Id's > > > for Arm. Hence we would still be required to have these functions > > > defined under an Aarch64 directory. > > > > > > > > > > > I agree that ARM support is not essential right now, or perhaps never. > > > > But I would like to understand the differences before I sign off on > > > > this. > > > > > > Ok. I understand your argument to make this generic, but given that it > > > mostly would never be used on 32-bit Arm platforms, i thought we can > > > make these changes when we have that scenario. But if you insist, i > > > will make the changes. Please let me know. Thanks. > > > > > > > No that's fine. I was just trying to assess how many changes would be required. > > So, just for my understanding, i can post a v5 for this patch only > with removal of the header file, if superfluous. Is that right. > Yes