From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::136; helo=mail-it1-x136.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x136.google.com (mail-it1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5AE1D211963F0 for ; Mon, 10 Dec 2018 23:54:19 -0800 (PST) Received: by mail-it1-x136.google.com with SMTP id g76so2197059itg.2 for ; Mon, 10 Dec 2018 23:54:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=b6uBR+QtnRcI5rxTEIlGaVS/LJcIkvXjYici4WVRE9g=; b=WfJU07Qt2LA25XXtH+qmMh3SoRnIMrAlFGwzlG11V08e2/jJJJiHDD4VGlHcGV6Jvv iHx+42BSn6ZooMfZ0BB99YNVv97vjf5q9MKrZJhwc38lNTqUJzrby8e1D/Sf75SDL5vv QsL+iButuFK8/lS/dIvvqO55gxqh9GaAM7oeE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=b6uBR+QtnRcI5rxTEIlGaVS/LJcIkvXjYici4WVRE9g=; b=amebwEyLzrsERpEnCySETInLzQqneQ49z44TLLzLD/4aE6DANNNohRTXfXOd/VI1Kf 3DLFBB+MmIj04WK1WTSTTzZMw1ZyOVQCHGfhFaDwhI+7g5RnUp7z5GGkT2H3w0Hm6t1y 25NPyOjZUrkGt+9l88U1pPYd/HdNBZAHRC/Oe2ZxQ0119jYdMGCapChqSwQJgkQnbnNk 2GeySbJmF7T/QX+7l6wIFISG2cFxOdKgJru2hs1X2PUTH2qtXGjwqOMZJgxso13Rnb2V KbpHpaL/NKb+s46kbx9dvb896MfpWOLSlk6ndzAvHjN5WI9WujzBgJcho6OggnD9vci6 Bdlg== X-Gm-Message-State: AA+aEWaPVq6tCxFNcqadP8ykfiliNUSJAwl0rSQUbjK+yDsGahjjrcqP SA8lG0u8wVWaLym9fKg7cUGD/QgAy+Ii+z888hs0DK4pE+A= X-Google-Smtp-Source: AFSGD/X9yRuQJ2YAwx0U2Fn9b4Vu38n+Q+ZwbiIZiPB5k7tWgxOyfV3JFUI0IvDrE3Xt7P4U2N6s930afF7bWglX7xM= X-Received: by 2002:a24:edc4:: with SMTP id r187mr1472225ith.158.1544514859198; Mon, 10 Dec 2018 23:54:19 -0800 (PST) MIME-Version: 1.0 References: <20181205201049.10590-1-ard.biesheuvel@linaro.org> <20181210221441.2xwqqzgafxpvqguu@bivouac.eciton.net> <20181210233355.4v5guv5nwmbun5w3@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E389AA3@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E389AA3@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Tue, 11 Dec 2018 08:54:07 +0100 Message-ID: To: "Gao, Liming" Cc: Andrew Fish , Leif Lindholm , "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: fix byte order of default MAC addresses X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2018 07:54:20 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 11 Dec 2018 at 01:53, Gao, Liming wrote: > > If PCD is related to one structure in DEC/DSC, it can be refer as structu= re pointer in C source code. Here is wiki for its usage: https://github.com= /lgao4/edk2/wiki/StrucutrePcd-Usage > OK so I now have this in my .dec file [PcdsDynamic] gAmdStyxTokenSpaceGuid.PcdEthMacA|{0}|UINT8[6]|0x000d0001 gAmdStyxTokenSpaceGuid.PcdEthMacB|{0}|UINT8[6]|0x000d0002 and this in my .dsc file [PcdsDynamicDefault.common] gAmdStyxTokenSpaceGuid.PcdEthMacA|{0x2,0xA1,0xA2,0xA3,0xA4,0xA5} gAmdStyxTokenSpaceGuid.PcdEthMacB|{0x2,0xB1,0xB2,0xB3,0xB4,0xB5} and the build errors out immediately with: Processing meta-data ....... build.py... : error F015: /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_GCC5/= PcdValueInit/PcdValueInit.c:15:20: error: =E2=80=98gAmdStyxTokenSpaceGuid_PcdEthMacB_DEFAULT_STANDARD_Value=E2= =80=99 undeclared (first use in this function) /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_GCC5/PcdValueInit/Pc= dValueInit.c:41:16: error: =E2=80=98gAmdStyxTokenSpaceGuid_PcdEthMacB_DEFAULT_STANDARD_Value=E2= =80=99 undeclared (first use in this function) /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_GCC5/PcdValueInit/Pc= dValueInit.c:74:20: error: =E2=80=98gAmdStyxTokenSpaceGuid_PcdEthMacA_DEFAULT_STANDARD_Value=E2= =80=99 undeclared (first use in this function) /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_GCC5/PcdValueInit/Pc= dValueInit.c:100:16: error: =E2=80=98gAmdStyxTokenSpaceGuid_PcdEthMacA_DEFAULT_STANDARD_Value=E2= =80=99 undeclared (first use in this function)