public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: fix byte order of default MAC addresses
@ 2018-12-05 20:10 Ard Biesheuvel
  2018-12-10 22:14 ` Leif Lindholm
  0 siblings, 1 reply; 11+ messages in thread
From: Ard Biesheuvel @ 2018-12-05 20:10 UTC (permalink / raw)
  To: edk2-devel

The PCDs containing the default MAC addresses are of type UINT64,
and so the byte order needs to be inverted. As they are currently,
both default MAC addresses are invalid since they have the multicast
bit set.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index 05433d4472e8..2843e51f93f7 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -469,8 +469,8 @@ DEFINE DO_CAPSULE   = FALSE
   gAmdModulePkgTokenSpaceGuid.PcdPort1NetSpeed|1
 
 [PcdsDynamicDefault.common]
-  gAmdStyxTokenSpaceGuid.PcdEthMacA|0x02A1A2A3A4A5
-  gAmdStyxTokenSpaceGuid.PcdEthMacB|0x02B1B2B3B4B5
+  gAmdStyxTokenSpaceGuid.PcdEthMacA|0xA5A4A3A2A102
+  gAmdStyxTokenSpaceGuid.PcdEthMacB|0xB5B4B3B2B102
 
 [PcdsPatchableInModule]
   gAmdModulePkgTokenSpaceGuid.PcdXgbeUseMacFromIscp|TRUE
-- 
2.19.2



^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2018-12-11 13:57 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-05 20:10 [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: fix byte order of default MAC addresses Ard Biesheuvel
2018-12-10 22:14 ` Leif Lindholm
2018-12-10 22:51   ` Ard Biesheuvel
2018-12-10 23:33     ` Leif Lindholm
2018-12-10 23:38       ` Andrew Fish
2018-12-11  0:53         ` Gao, Liming
2018-12-11  7:54           ` Ard Biesheuvel
2018-12-11 13:15             ` Gao, Liming
2018-12-11 13:38               ` Feng, Bob C
2018-12-11 13:48                 ` Ard Biesheuvel
2018-12-11 13:57                   ` Feng, Bob C

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox