Re: [PATCH v2] ArmVirtPkg/PlatformHasAcpiDtDxe: allow guest level ACPI disable override

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 29 March 2017 at 20:35, Laszlo Ersek <lersek@redhat.com> wrote:
> On 03/29/17 21:10, Ard Biesheuvel wrote:
[...]
>>
>> How on earth is having two ways to disable ACPI rather than one going
>> to cause fragmentation? Unlike v1, this patch does not allow you to
>> expose both DT and ACPI tables at the same time.
>
> Oopsie daisy. You actually updated the commit message too. (I have now
> formally diffed v1 vs. v2, including commit msg -- I generally do that
> when reviewing incremental versions of patches, but it has been a very
> long day, and I failed to get my mind off the track set up by v1). I got
> really no good explanation for missing the fundamental logic change
> between v1 and v2. As you say, version 2 preserves the mutual exclusion
> between DT and ACPI that I'm so annoyingly obsessed about. Thank you for
> the update.
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>

Thanks Laszlo. I am glad we have a solution we can both live with.

I will wait for Marc to confirm that this works as expected for him.

Thanks,
Ard.