From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1E46321BC6ADC for ; Thu, 30 Mar 2017 01:40:14 -0700 (PDT) Received: by mail-io0-x234.google.com with SMTP id l7so14652579ioe.3 for ; Thu, 30 Mar 2017 01:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=SnXPcLMTaNi9ctdxIzSU/9l9oIKy7CZlePoyJJZFdEA=; b=i+WcPPa/wkJfsSh4R6UCpuWUY6rVWJsX1M2zR7EIlRPa/9K3JjyVwYHyaBpd2hit5b EQiw6FKJbYj10Z2AeDvG3QXLaTLM3vVhdQs8NaAoYz5SPMYczCKfF9lMAxh/HfZjRnS3 3p4SKg/8dsbCKlEAMuHUqhqJmTWsXziD4r2lc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SnXPcLMTaNi9ctdxIzSU/9l9oIKy7CZlePoyJJZFdEA=; b=DKeCzIZPmKLy/uRT2vm36NkIRaIo292QwZjPnmokcS6BLK4lLg20Frud9E+oCO5d3x y9djF74z5NJt2jr8Wtf32SeThJFvbIwtdeZgriPsENmrAq8mCqlxzU5skXhk9hPmFkrG 3HBn/RxpWkMEDZwDcXhefTk4ye+sSrZr8m+1KgtWgvICneN9jQ+3WYifiCWpp00V4dYb 9OCSvIvzlG5gDMoAAjDdgwDQ/HvKB0IMp9IR7ugp7/63edXFvZZj6T8rq1zLVdLgW+a8 EJE7cpjodE31EpsxxLrGzZWwNvUmBEd0ESegr4BgW3MuwCGU7sag6aRFwIaIpfgBB1ZP 9T9w== X-Gm-Message-State: AFeK/H0+ak3/Ls871wcreTCwBcqYLAlOyoZsEGbLgsWkFW1ePz9aeTiKDjpyT3zutXBj6nfomH9L3VUQpsSKZ3ix X-Received: by 10.107.141.134 with SMTP id p128mr5306513iod.83.1490863213422; Thu, 30 Mar 2017 01:40:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Thu, 30 Mar 2017 01:40:13 -0700 (PDT) In-Reply-To: <41a87740-7634-bfde-d2fb-3767a5c33140@redhat.com> References: <20170329175039.29635-1-ard.biesheuvel@linaro.org> <18095962-76eb-7337-969d-4f6080dff4d7@redhat.com> <41a87740-7634-bfde-d2fb-3767a5c33140@redhat.com> From: Ard Biesheuvel Date: Thu, 30 Mar 2017 09:40:13 +0100 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Marc Zyngier , Mark Rutland , Drew Jones , Jon Masters Subject: Re: [PATCH v2] ArmVirtPkg/PlatformHasAcpiDtDxe: allow guest level ACPI disable override X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 08:40:14 -0000 Content-Type: text/plain; charset=UTF-8 On 29 March 2017 at 20:35, Laszlo Ersek wrote: > On 03/29/17 21:10, Ard Biesheuvel wrote: [...] >> >> How on earth is having two ways to disable ACPI rather than one going >> to cause fragmentation? Unlike v1, this patch does not allow you to >> expose both DT and ACPI tables at the same time. > > Oopsie daisy. You actually updated the commit message too. (I have now > formally diffed v1 vs. v2, including commit msg -- I generally do that > when reviewing incremental versions of patches, but it has been a very > long day, and I failed to get my mind off the track set up by v1). I got > really no good explanation for missing the fundamental logic change > between v1 and v2. As you say, version 2 preserves the mutual exclusion > between DT and ACPI that I'm so annoyingly obsessed about. Thank you for > the update. > > Reviewed-by: Laszlo Ersek > Thanks Laszlo. I am glad we have a solution we can both live with. I will wait for Marc to confirm that this works as expected for him. Thanks, Ard.