From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::144; helo=mail-it1-x144.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DEDF2211CC3A3 for ; Tue, 26 Feb 2019 08:17:21 -0800 (PST) Received: by mail-it1-x144.google.com with SMTP id e24so4675471itl.1 for ; Tue, 26 Feb 2019 08:17:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gs0tYmHZWD7k4BQl9Yb62Z/zeG6L5C6FaSxCg8f/N6U=; b=Kl0Z/oaOtIthkUaABA8YjUtOta/yMh2NLurG1DMAwPluKL9804Ddd4rRNqtRasMbjL rA4BCr6W1g2QCQKV2Sj4NEyjg9ixwXmdZ3XpZMeAanTIl/f3iHikIcdiVVkcXzbnMxBy Fly92sSpVRPmYuFKC3abgEDaowLrZ8ZJY9KCMkDjSfvshrzcXhOYTZK9XrhFN6IAR2Ir +HgaOoTji89FbwoGil7smUDjzs9dR3vxFRt9amWOYKJmDxl+vEf5JVQx9Ehh9PnmYZSb rS06jQgFu96B75r5JHu3TTzCkd5TrrhvWhZ6wyghn8glkxmwhsxmZ1aiK1suGwWoaS6L /hMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gs0tYmHZWD7k4BQl9Yb62Z/zeG6L5C6FaSxCg8f/N6U=; b=n/KttFpsYJ86ozhaFRa3i6c2Ui34zxBKxVr31yoPtWPJrR+RNUHF5r/aHQavRaWs8D PJ2z1RvVoPWwKSgxJde/QNT9uwgM10V0hzmISXuj/qMR9Y9+Oq8lMDpgn6NGFOc4eJXG fzxT4n5mkCuyavUyAHkKRK+hqVqTdoPx4GxGC2zFCo/quixSaG/GFH1noykn6N7AZu0F FUUc7+FaTEWHYc41MwPguVkccwZbEnE8Ow6YJ9kABPzbTzt00/X4Cc9q77Cql2h4apMs K1lUpV7FInAzpEj62vKL1kr8BEmP1EhianeUG4ks+5OC5uJcKoQ7d/J0Ghlu9FLekk+i RySw== X-Gm-Message-State: AHQUAubyg4dR3E59Mj1j6LJCzZ+fsz5QKW4prtww05CknJJdaFgLh6ZA A3br/E1MhWhIlXmDiqNcjgIco+miI7+dGQIvGcuh/g== X-Google-Smtp-Source: APXvYqyBlJQMzZBV+1F8846WvtEzqvs/Mg3GOH1j1bOXoGcokT7XjfDEPdNDx9VEvBDnAXmOlgF2olSws7Kgo5z7Zv8= X-Received: by 2002:a24:2e90:: with SMTP id i138mr789742ita.158.1551197840787; Tue, 26 Feb 2019 08:17:20 -0800 (PST) MIME-Version: 1.0 References: <1544806699-25401-1-git-send-email-vijayenthiran.subramaniam@arm.com> <1544806699-25401-7-git-send-email-vijayenthiran.subramaniam@arm.com> In-Reply-To: From: Ard Biesheuvel Date: Tue, 26 Feb 2019 17:17:09 +0100 Message-ID: To: Vijayenthiran Subramaniam Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Thomas Abraham Subject: Re: [PATCH v2 edk2-platforms 6/8] SgiClark.Ares: AcpiTables: Add entry for virtio network device X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 16:17:22 -0000 Content-Type: text/plain; charset="UTF-8" On Tue, 26 Feb 2019 at 14:17, Vijayenthiran Subramaniam wrote: > > Hi Ard, > > This patch is part of the patch series "Platform/ARM/Sgi: Add support for virtio network device". While other seven patches are merged upstream, this patch is not yet merged. Please let me know if you have any comments on this patch. > Apologies for that, this wasn't intentional. Reviewed-by: Ard Biesheuvel Pushed as 54f98cb1789a..c63c3f071271 > On Fri, Dec 14, 2018 at 11:28 PM Vijayenthiran Subramaniam wrote: >> >> SgiClark Ares include an instance of the virtio network device. Add >> a representation for it in the ACPI tables. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Vijayenthiran Subramaniam >> --- >> Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf | 3 +++ >> Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl | 17 +++++++++++++++++ >> 2 files changed, 20 insertions(+) >> >> diff --git a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf >> index 10a805e07fd1..d4bacdbc8c85 100644 >> --- a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf >> +++ b/Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf >> @@ -58,5 +58,8 @@ [FixedPcd] >> gArmSgiTokenSpaceGuid.PcdVirtioBlkBaseAddress >> gArmSgiTokenSpaceGuid.PcdVirtioBlkSize >> gArmSgiTokenSpaceGuid.PcdVirtioBlkInterrupt >> + gArmSgiTokenSpaceGuid.PcdVirtioNetBaseAddress >> + gArmSgiTokenSpaceGuid.PcdVirtioNetSize >> + gArmSgiTokenSpaceGuid.PcdVirtioNetInterrupt >> >> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress >> diff --git a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl b/Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl >> index af4dc424a77c..69dc33c06b4d 100644 >> --- a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl >> +++ b/Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl >> @@ -118,5 +118,22 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARMSGI", >> } >> }) >> } >> + >> + // VIRTIO NET >> + Device (VR01) { >> + Name (_HID, "LNRO0005") >> + Name (_UID, 1) >> + Name (_CCA, 1) // mark the device coherent >> + >> + Name (_CRS, ResourceTemplate() { >> + Memory32Fixed (ReadWrite, >> + FixedPcdGet32 (PcdVirtioNetBaseAddress), >> + FixedPcdGet32 (PcdVirtioNetSize) >> + ) >> + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { >> + FixedPcdGet32 (PcdVirtioNetInterrupt) >> + } >> + }) >> + } >> } // Scope(_SB) >> } >> -- >> 2.7.4 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel