From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2FAD321164C49 for ; Mon, 11 Jun 2018 01:14:37 -0700 (PDT) Received: by mail-it0-x244.google.com with SMTP id l6-v6so9864630iti.2 for ; Mon, 11 Jun 2018 01:14:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zOx9+hocdbOxXp9jgbcDYMQnzm9sDCS1I6nEjnFiFzo=; b=KE6yKkXLGeQqFjkA2WBxX2WSHkKvEqTuetHB0wfigprWxxFgeEHewvVUCCnLa+8UHf yym+vP4g0yQra1nIpHEgoB6q6xShPi/wIGCcVSHtD4FQKqGxv49r6tkmiIDEmsoSgCjF glSbNakSPipLYnN5vFVjuglBvzVSo7sWpClq8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zOx9+hocdbOxXp9jgbcDYMQnzm9sDCS1I6nEjnFiFzo=; b=VAD/8YQCSJOvvzWS+w868hiNnT3bB/P5cF71unpFnQ9qOwUrAi90AHiRsOIa6xmX/j Y7t3RWhsKblJzPlbY6KbNBEyqjGUna2pNx9KoXUVeJklDuZh+V/xzIi13hoPljz1U6pG vy8KHnytYH4r4wvpPZKVye4jB1Hh2SuYqauRHf0H6kyCZHghukEYgZyAOqOLcwbQBcKC 6cBejiobueWMjq+t3RC/9TWNfPeWTvyF2N6MqWTGdRvJUqwbvHpn/+l20DVdPzJPlzzn Bo0s6DQcjZfvdDqdQu8PM/tkM9Pa03LHB4v0O9tpHr33bvdFKsGGhhqNj/48vN2q5psh lZQg== X-Gm-Message-State: APt69E33BIf+ustUN6faojR1XVHNsqILwRfzv7pPi/ODQ9OpLM/g0A+u Xb3xCKVq1qLZlvmYwn9e5TloQD0pwOl2M4NGJYKLjw== X-Google-Smtp-Source: ADUXVKLKjfuODGrj/b6YQVbuSAKnQJ+mMCcVlVymWjNgiWW8aMzYXiEVu6/fckQsdvZ+KP62OHiTYgKF/4WMCzsLLbY= X-Received: by 2002:a24:1d0e:: with SMTP id 14-v6mr9429336itj.50.1528704876771; Mon, 11 Jun 2018 01:14:36 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Mon, 11 Jun 2018 01:14:36 -0700 (PDT) In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BB54B8C@shsmsx102.ccr.corp.intel.com> References: <20180607091003.8687-1-ard.biesheuvel@linaro.org> <6f89e8bc-2aef-d7d8-bec4-b491506b2a34@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BB54B8C@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Mon, 11 Jun 2018 10:14:36 +0200 Message-ID: To: "Zeng, Star" Cc: "edk2-devel@lists.01.org" , Laszlo Ersek , "Wu, Hao A" Subject: Re: [PATCH] MdeModulePkg/EmmcDxe: demote DEBUG print to DEBUG_BLKIO X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 08:14:39 -0000 Content-Type: text/plain; charset="UTF-8" On 8 June 2018 at 05:15, Zeng, Star wrote: > Good patch. > > Another choice is to use DEBUG_VERBOSE. > We see other driver uses DEBUG_VERBOSE for BlockIo service (Hao can comment on that). > We'd better to align them for consistency. > Hao, Do you have any preference regarding the exact priority level we will use for this particular DEBUG() print? Thanks, Ard. > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Friday, June 8, 2018 1:23 AM > To: Ard Biesheuvel ; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: Re: [edk2] [PATCH] MdeModulePkg/EmmcDxe: demote DEBUG print to DEBUG_BLKIO > > On 06/07/18 11:10, Ard Biesheuvel wrote: >> Lower the priority of the DEBUG print in EmmcReadWrite(), which is >> emitted for each read or write operation to the eMMC device, which >> clutters up the log output of builds created with DEBUG_INFO enabled. >> >> Suggested-by: Pipat Methavanitpong >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> --- >> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c >> b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c >> index e1d0f394a954..f6b230514b71 100644 >> --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c >> +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c >> @@ -901,7 +901,10 @@ EmmcReadWrite ( >> if (EFI_ERROR (Status)) { >> return Status; >> } >> - DEBUG ((EFI_D_INFO, "Emmc%a(): Part %d Lba 0x%x BlkNo 0x%x Event %p with %r\n", IsRead ? "Read " : "Write", Partition->PartitionType, Lba, BlockNum, (Token != NULL) ? Token->Event : NULL, Status)); >> + DEBUG ((DEBUG_BLKIO, >> + "Emmc%a(): Part %d Lba 0x%x BlkNo 0x%x Event %p with %r\n", >> + IsRead ? "Read " : "Write", Partition->PartitionType, Lba, BlockNum, >> + (Token != NULL) ? Token->Event : NULL, Status)); >> >> Lba += BlockNum; >> Buffer = (UINT8*)Buffer + BufferSize; >> > > Reviewed-by: Laszlo Ersek