From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
"Tian, Feng" <feng.tian@intel.com>,
Ruiyu Ni <ruiyu.ni@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v3 0/2] quirks handling for SDHCI controllers
Date: Mon, 11 Dec 2017 23:15:38 +0000 [thread overview]
Message-ID: <CAKv+Gu8ParGde+Cg+MxPd7iX5XgpNoOVe_R11o=-25kRgkngeA@mail.gmail.com> (raw)
In-Reply-To: <CAKv+Gu_Bah3g5MswCon0kdM36qLRS5gAgYQV10eia7LXmPkHXQ@mail.gmail.com>
On 11 December 2017 at 23:12, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> On 5 December 2017 at 18:01, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>> Many SDHCI implementations exist that are almost spec complicant, and
>> could be driven by the generic SD/MMC host controller driver except
>> for some minimal necessary init time tweaks.
>>
>> Adding such tweaks to the generic driver is undesirable. On the other
>> hand, forking the driver for every platform that has such a SDHCI
>> controller is problematic when it comes to upstreaming and ongoing
>> maintenance (which is arguably the point of upstreaming in the first
>> place).
>>
>> So these patches propose a workaround that is minimally invasive on the
>> EDK2 side, but gives platforms a lot of leeway when it comes to applying
>> SDHCI quirks.
>>
>> Changes since v2:
>> - use a singleton instance of the SD/MMC protocol rather than one per
>> controller; this is needed to support 'reconnect -r', as pointed out
>> by Ray
>> - use EDKII prefixes for all types defined by the protocol
>> - replace 'hook' with 'notify', and tweak some other identifiers
>> - add missing function comment headers for factored out functions
>>
>> Changes since RFC/v1:
>> - add EFI_SD_MMC_PASS_THRU_PROTOCOL* member to override methods
>> - use UINT64* not VOID* to pass capability structure (which is always 64 bits
>> in size)
>>
>
> Comments anyone?
Please ignore - I thought I had sent out my v4 already, but apparently not.
prev parent reply other threads:[~2017-12-11 23:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 18:01 [PATCH v3 0/2] quirks handling for SDHCI controllers Ard Biesheuvel
2017-12-05 18:01 ` [PATCH v3 1/2] MdeModulePkg: introduce SD/MMC override protocol Ard Biesheuvel
2017-12-06 3:21 ` Ni, Ruiyu
2017-12-06 3:25 ` Zeng, Star
2017-12-06 3:42 ` Ni, Ruiyu
2017-12-05 18:01 ` [PATCH v3 2/2] MdeModulePkg/SdMmcPciHcDxe: allow HC capabilities to be overridden Ard Biesheuvel
2017-12-06 3:33 ` Ni, Ruiyu
2017-12-06 11:16 ` Ard Biesheuvel
2017-12-11 23:12 ` [PATCH v3 0/2] quirks handling for SDHCI controllers Ard Biesheuvel
2017-12-11 23:15 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu8ParGde+Cg+MxPd7iX5XgpNoOVe_R11o=-25kRgkngeA@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox