From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::22e; helo=mail-it0-x22e.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5FAD02214E32B for ; Mon, 11 Dec 2017 15:11:01 -0800 (PST) Received: by mail-it0-x22e.google.com with SMTP id x28so20092865ita.0 for ; Mon, 11 Dec 2017 15:15:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=lHSxj5s8NY9hmd4vmMeG2ezFXhff4ifKKjfP+WTuOBk=; b=AGDUAokVMNxhvyuP8f3OyxnnWI96KiRIo0khgZovqgsMOsGwDAJh2kscWGzVmAKoFK YlbijJJ7X9CASsZ9As7PscJvye6nHcTOy8KyyPa1TaoLX65KIrSLSyVXZ0vaZe0bwszZ 6XN/x4D1EMNsBZU+uW0htv6n63lGuCZCKgajQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=lHSxj5s8NY9hmd4vmMeG2ezFXhff4ifKKjfP+WTuOBk=; b=L5X/Z+I7P3+LxzgdgbtfWZeGEWdz93IMW4LspvcVpsrG0B13X9LriQl+bN/cYy5H8q 5s8Z0vggrZVempz+V9w3euxP+LnXsjqOGP3CkM8dFM85MDEartZvqUeqUCVuhZctCjOf 2PgaXiZoNvT46pLUF+PQijCwtedebcEzwy6vmfM64rjGr0JxSn6+tszJdtozsJRq4kz+ /BTzYuXla/FKJXWNS+E/5x9RCc9PdWgoPN570QtaBmwZEPOyHEy2SryCrdPboF//rG/p QMfTjxVS4OssiR/amUDMr/ziq4bZhrffHbfaFCxA8EKo2AkB5syUvklQWjRzWriX9Svj aCjw== X-Gm-Message-State: AKGB3mIKe6e9w/ckT3ZrIgU0xEzmSudUTi7/S0LHBrVxuYxoBb/igXIe v/EbxiEbSRcuInsn8flgL+4iR52I12eR2AS6/0pUusnl X-Google-Smtp-Source: ACJfBotWvjCoe5dBXi6h0eg5/11Vvtg1bpaD75IaEKemFkcZu+09w13trfySCJ+Q/v4mKl9zNvI+o2w7NOvT8votvhg= X-Received: by 10.107.151.142 with SMTP id z136mr2753583iod.248.1513034138780; Mon, 11 Dec 2017 15:15:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Mon, 11 Dec 2017 15:15:38 -0800 (PST) In-Reply-To: References: <20171205180152.15758-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Mon, 11 Dec 2017 23:15:38 +0000 Message-ID: To: "edk2-devel@lists.01.org" Cc: Leif Lindholm , "Kinney, Michael D" , "Zeng, Star" , "Tian, Feng" , Ruiyu Ni , "Wu, Hao A" , Ard Biesheuvel Subject: Re: [PATCH v3 0/2] quirks handling for SDHCI controllers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 23:11:01 -0000 Content-Type: text/plain; charset="UTF-8" On 11 December 2017 at 23:12, Ard Biesheuvel wrote: > On 5 December 2017 at 18:01, Ard Biesheuvel wrote: >> Many SDHCI implementations exist that are almost spec complicant, and >> could be driven by the generic SD/MMC host controller driver except >> for some minimal necessary init time tweaks. >> >> Adding such tweaks to the generic driver is undesirable. On the other >> hand, forking the driver for every platform that has such a SDHCI >> controller is problematic when it comes to upstreaming and ongoing >> maintenance (which is arguably the point of upstreaming in the first >> place). >> >> So these patches propose a workaround that is minimally invasive on the >> EDK2 side, but gives platforms a lot of leeway when it comes to applying >> SDHCI quirks. >> >> Changes since v2: >> - use a singleton instance of the SD/MMC protocol rather than one per >> controller; this is needed to support 'reconnect -r', as pointed out >> by Ray >> - use EDKII prefixes for all types defined by the protocol >> - replace 'hook' with 'notify', and tweak some other identifiers >> - add missing function comment headers for factored out functions >> >> Changes since RFC/v1: >> - add EFI_SD_MMC_PASS_THRU_PROTOCOL* member to override methods >> - use UINT64* not VOID* to pass capability structure (which is always 64 bits >> in size) >> > > Comments anyone? Please ignore - I thought I had sent out my v4 already, but apparently not.