From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9B7601A1DF8 for ; Mon, 22 Aug 2016 00:15:47 -0700 (PDT) Received: by mail-io0-x22f.google.com with SMTP id 38so101733923iol.0 for ; Mon, 22 Aug 2016 00:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=g7LqnznDA7wL0d+LmMr601Vqy6edt3y3XlgUObC2A+c=; b=LsCzVA6yzGoZXX1jMG6YgXkw1dmDuUDp3JuPFXx+5/A64YGNNdOhKMe9+HWS2UyjgS mC3Ilg2XkmwMpG7JzXhT6xdgxauCHZj4NoMdVIesSeMVQunol1X32olebr6hoozjbNaD T0mjv4Ea1WZ7hnSOrpf7jwBmpkAhCfidBoGvQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=g7LqnznDA7wL0d+LmMr601Vqy6edt3y3XlgUObC2A+c=; b=T42j/OyYNUYU5uWvL9Bg3hhlpoOudHi8qPhywh7t/4iE5Pnyyf3/ZIvjDI9Fodok2I M+Er5HZ/nWyLJayhZ50aiFLUl5HSqr/h5Kna/8XnjoG/tz585JjCZkPYSHefYk5hfYxf WiEM9SS/lh/eIW8Ztg8HnYGIQ3Zpx6/MhApywUfwGvQ7kcje8932cjdjHfCMrH3JmfTY U7Jm/5KYGQeCtXCetPKzWBrITrKixJ/b+dsqVVodpF5ypHInd+SJF+MR1ZyQfkVEyxbX Dg3NveqJXr7/JFFcL9zrsvk9tlEgw9L5U90U/+/Ip64opKzAsLG6UY/Zhel3s6xct9y3 rKKg== X-Gm-Message-State: AEkoouvhJ29aSng6fDtS9lgg1JVRgYZ6Ck7dHsWysNsXblEyNsHSVa66yQxWx3A4sAJLDIHckZmUJVOlbzOB3hJn X-Received: by 10.107.40.133 with SMTP id o127mr21249041ioo.183.1471850146851; Mon, 22 Aug 2016 00:15:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Mon, 22 Aug 2016 00:15:46 -0700 (PDT) In-Reply-To: References: <1471589755-24419-1-git-send-email-vikas.cha.sajjan@hpe.com> <09a7a387-da85-655f-c7bc-4904af75540c@redhat.com> From: Ard Biesheuvel Date: Mon, 22 Aug 2016 09:15:46 +0200 Message-ID: To: "Sajjan, Vikas C" Cc: Laszlo Ersek , "edk2-devel@ml01.01.org" , "leif.lindholm@linaro.org" , "Wei, Dong (Office of the CTO)" Subject: Re: [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg platforms X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2016 07:15:47 -0000 Content-Type: text/plain; charset=UTF-8 On 22 August 2016 at 09:07, Ard Biesheuvel wrote: > On 20 August 2016 at 05:01, Sajjan, Vikas C wrote: >> >> >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Friday, August 19, 2016 6:58 PM >> To: Sajjan, Vikas C ; edk2-devel@ml01.01.org; ard.biesheuvel@linaro.org; leif.lindholm@linaro.org >> Cc: Wei, Dong (Office of the CTO) >> Subject: Re: [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg platforms >> >> On 08/19/16 08:55, Vikas C Sajjan wrote: >>> This series adds ramdisk driver support to ArmVirtPkg platforms. >>> It actually ports OvmfPkg commit 259d87146b07 to ArmVirtPkg. >>> >>> changes since v2: >>> - Made changes as suggested by Laszlo Ersek >>> a] Moved inclusion of AcpiTableDxe.inf to end of file >>> b] Moved gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol to proper location >>> c] fixed minor nits >>> >>> changes since v1: >>> - Made changes as suggested by Laszlo Ersek >>> a] clarified in the commit message (including the subject line) >>> that this patch is actually about adding the RAM Disk driver to the >>> ArmVirtPkg platforms, not just the NFIT reporting feature of the driver >>> b] enabled feature for all of ArmVirtQemu, ArmVirtQemuKernel, and ArmVirtXen. >>> c] prepended a patch to the series that extracts >>> "MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf" >>> from all of the DSC files, into "ArmVirt.dsc.inc" >>> >>> >>> Vikas C Sajjan (2): >>> ArmVirtPkg: Move inclusion of AcpiTableDxe.inf to ArmVirt.dsc.inc >>> ArmVirtPkg: Add Ramdisk support to ArmVirtPkg platforms >>> >>> ArmVirtPkg/ArmVirt.dsc.inc | 17 +++++++++++++++++ >>> ArmVirtPkg/ArmVirtQemu.dsc | 1 - >>> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 5 +++++ >>> ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 - >>> ArmVirtPkg/ArmVirtRules.fdf.inc | 2 ++ >>> ArmVirtPkg/ArmVirtXen.dsc | 1 - >>> ArmVirtPkg/ArmVirtXen.fdf | 5 +++++ >>> 7 files changed, 29 insertions(+), 3 deletions(-) >>> >> >> Series >> Reviewed-by: Laszlo Ersek >> >> Thank you, Laszlo. >> >> Ard, can you please commit the series for Vikas? My brain is fried, I need to get out. :) >> >> Thanks! >> Laszlo > > Committed as > > fde03c8065ea ArmVirtPkg: Move inclusion of AcpiTableDxe.inf to ArmVirt.dsc.inc > d36447418d32 ArmVirtPkg: Add Ramdisk support to ArmVirtPkg platforms > These patches have no broken ArmVirtXen, since it has no resolution for FileExplorerLib, which RamDiskDxe depends on. Could you propose a fix please? -- Ard.