From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::22c; helo=mail-it0-x22c.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EDAF3224A9EB0 for ; Fri, 30 Mar 2018 08:28:12 -0700 (PDT) Received: by mail-it0-x22c.google.com with SMTP id r19-v6so12129888itc.0 for ; Fri, 30 Mar 2018 08:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vDrpuCcFK+J8aruwm8D7eLnnc1Yh8J9U0rZpQGcfmjY=; b=fDa6lKqLkvhDU/jm68+5URBpgTpgfPw6Fbu0c72CJkeFl5ehdt3oqJbXvyR+bPpVV0 ePaJNOEE0tZs4fcEfwurKWsi6OkQDshbYV+ptWnbQI52/xliLNmOyqk9vFj1MNQJjkqa Ko/WHDgQrY+g34t8fLN90BqcvI2vSfON21xKk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vDrpuCcFK+J8aruwm8D7eLnnc1Yh8J9U0rZpQGcfmjY=; b=uh3eMfegYpWCWYKuJTUtJiHZ197zRnsj9wsyjOqiVELY82ZqFgkKlWzOYR/WzzV6Cr VlnmY/SFq2RUX8etcJ+tArnXhPRzP1n4ipO7ZjjLrsg5qxJTXhooGUw3CV978NUIGFFK JBy0ZmbIOtMMuP9Mqh5JrVeNvCaKr1XRp3Df3y9S8wd3632wjMEcBBjlhVZZ+8bpSOWR xE/xv9f0ArBdlz5l/f+hdP0P16f6t/XKo9qYVEstvuhvc9udzLaJCb17ZXqk7jcOqIbn w1VTzalwZUw3XF3R2RmOEM3BTFupSYY5d+H6fLcBnQbMoumcZe6n5oC4EIHcV4JnrIxd 0ERQ== X-Gm-Message-State: ALQs6tC+uKZdRCf6ssjO2oZSsc1KFKBzNbL0alPLD6GAYXIMkqJMwxCt R1DzpXlC28rnAxgkh54Uv3RJT5slouwUat92914QHn7D X-Google-Smtp-Source: AIpwx48kTjEFdRQu0g0Ps/+09HSIJDGIn0c7LFGzxK2tw1Yi4jNKQ4jmJxW7bKa6RjHSLrLqtn08jpL1vNIYHjAvHYA= X-Received: by 2002:a24:67d7:: with SMTP id u206-v6mr3480718itc.138.1522423692050; Fri, 30 Mar 2018 08:28:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Fri, 30 Mar 2018 08:28:11 -0700 (PDT) In-Reply-To: <1521594198-52523-8-git-send-email-heyi.guo@linaro.org> References: <1521594198-52523-1-git-send-email-heyi.guo@linaro.org> <1521594198-52523-8-git-send-email-heyi.guo@linaro.org> From: Ard Biesheuvel Date: Fri, 30 Mar 2018 16:28:11 +0100 Message-ID: To: Heyi Guo Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Michael D Kinney Subject: Re: [PATCH edk2-platforms 07/12] Hisilicon: add PciHostBridgeLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 15:28:13 -0000 Content-Type: text/plain; charset="UTF-8" On 21 March 2018 at 01:03, Heyi Guo wrote: > This is to prepare for switching to generic PciHostBridge, and > PciHostBridgeLib is needed by PciHostBridge driver. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Heyi Guo > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > Platform/Hisilicon/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 51 ++++ > Platform/Hisilicon/Library/PciHostBridgeLib/PciHostBridgeLib.c | 304 ++++++++++++++++++++ > 2 files changed, 355 insertions(+) > > diff --git a/Platform/Hisilicon/Library/PciHostBridgeLib/PciHostBridgeLib.inf b/Platform/Hisilicon/Library/PciHostBridgeLib/PciHostBridgeLib.inf > new file mode 100644 > index 000000000000..dd451cff332c > --- /dev/null > +++ b/Platform/Hisilicon/Library/PciHostBridgeLib/PciHostBridgeLib.inf > @@ -0,0 +1,51 @@ > +## @file > +# PCI Host Bridge Library instance for Hisilicon D0x > +# > +# Copyright (c) 2018, Hisilicon Limited. All rights reserved.
> +# Copyright (c) 2017 - 2018, Linaro Ltd. All rights reserved.
> +# > +# This program and the accompanying materials are licensed and made available > +# under the terms and conditions of the BSD License which accompanies this > +# distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > +# IMPLIED. > +# > +# > +## > + > +[Defines] > + INF_VERSION = 0x0001000A > + BASE_NAME = PciHostBridgeLib > + FILE_GUID = e5c91e8a-0b2b-11e8-9533-286ed489ee9b > + MODULE_TYPE = DXE_DRIVER > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = PciHostBridgeLib|DXE_DRIVER > + > +# > +# The following information is for reference only and not required by the build > +# tools. > +# > +# VALID_ARCHITECTURES = AARCH64 ARM > +# > + > +[Sources] > + PciHostBridgeLib.c > + > +[Packages] > + MdeModulePkg/MdeModulePkg.dec > + MdePkg/MdePkg.dec > + Silicon/Hisilicon/HisiPkg.dec > + > +[LibraryClasses] > + BaseLib > + BaseMemoryLib > + DebugLib > + DevicePathLib > + MemoryAllocationLib > + OemMiscLib > + > +[Pcd] > + gHisiTokenSpaceGuid.PcdPcieRootBridgeMask > + gHisiTokenSpaceGuid.PcdPcieRootBridgeMask2P > diff --git a/Platform/Hisilicon/Library/PciHostBridgeLib/PciHostBridgeLib.c b/Platform/Hisilicon/Library/PciHostBridgeLib/PciHostBridgeLib.c > new file mode 100644 > index 000000000000..6aff5cdd3d76 > --- /dev/null > +++ b/Platform/Hisilicon/Library/PciHostBridgeLib/PciHostBridgeLib.c > @@ -0,0 +1,304 @@ > +/** @file > + PCI Host Bridge Library instance for Hisilicon D0x > + > + Copyright (c) 2018, Hisilicon Limited. All rights reserved.
> + Copyright (c) 2017 - 2018, Linaro Ltd. All rights reserved.
> + > + This program and the accompanying materials are licensed and made available > + under the terms and conditions of the BSD License which accompanies this > + distribution. The full text of the license may be found at > + http://opensource.org/licenses/bsd-license.php. > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, WITHOUT > + WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > + > +**/ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > + > +#pragma pack(1) > +typedef struct { > + ACPI_HID_DEVICE_PATH AcpiDevicePath; > + EFI_DEVICE_PATH_PROTOCOL EndDevicePath; > +} EFI_PCI_ROOT_BRIDGE_DEVICE_PATH; > +#pragma pack () > + > +STATIC EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mEfiPciRootBridgeDevicePath = { > + { > + { > + ACPI_DEVICE_PATH, > + ACPI_DP, > + { > + (UINT8) (sizeof(ACPI_HID_DEVICE_PATH)), > + (UINT8) ((sizeof(ACPI_HID_DEVICE_PATH)) >> 8) > + } > + }, > + EISA_PNP_ID(0x0A03), // PCI > + 0 > + }, { > + END_DEVICE_PATH_TYPE, > + END_ENTIRE_DEVICE_PATH_SUBTYPE, > + { > + END_DEVICE_PATH_LENGTH, > + 0 > + } > + } > +}; > + > +STATIC PCI_ROOT_BRIDGE mRootBridgeTemplate = { > + 0, // Segment > + 0, // Supports > + 0, // Attributes > + TRUE, // DmaAbove4G > + FALSE, // NoExtendedConfigSpace > + FALSE, // ResourceAssigned > + EFI_PCI_HOST_BRIDGE_COMBINE_MEM_PMEM | // AllocationAttributes > + EFI_PCI_HOST_BRIDGE_MEM64_DECODE, > + { > + // Bus > + 0, > + 0 > + }, { > + // Io > + 0, > + 0, > + 0 > + }, { > + // Mem > + MAX_UINT64, > + 0, > + 0 > + }, { > + // MemAbove4G > + MAX_UINT64, > + 0, > + 0 > + }, { > + // PMem > + MAX_UINT64, > + 0, > + 0 > + }, { > + // PMemAbove4G > + MAX_UINT64, > + 0, > + 0 > + }, > + (EFI_DEVICE_PATH_PROTOCOL *)&mEfiPciRootBridgeDevicePath > +}; > + > +STATIC > +EFI_STATUS > +ConstructRootBridge ( > + PCI_ROOT_BRIDGE *Bridge, > + PCI_ROOT_BRIDGE_RESOURCE_APPETURE *Appeture > + ) > +{ > + EFI_PCI_ROOT_BRIDGE_DEVICE_PATH *DevicePath; > + CopyMem (Bridge, &mRootBridgeTemplate, sizeof *Bridge); > + Bridge->Segment = Appeture->Segment; > + Bridge->Bus.Base = Appeture->BusBase; > + Bridge->Bus.Limit = Appeture->BusLimit; > + Bridge->Io.Base = Appeture->IoBase; > + // According to UEFI 2.7, device address = host address + translation > + Bridge->Io.Translation = Appeture->IoBase - Appeture->CpuIoRegionBase; > + // IoLimit is actually an address in CPU view > + // TODO: improve the definition of PCI_ROOT_BRIDGE_RESOURCE_APPETURE > + Bridge->Io.Limit = Appeture->IoLimit + Bridge->Io.Translation; Does this mean we incorporate the type translation into the I/O address translation? In other words, are the CPU memory addresses equal to the CPU I/O addresses when using this translation? If so, I think that is incorrect. The translated I/O windows should make up a coherent I/O space in the CPU view, and the fact that we access I/O regions via a CPU MMIO window that involves type translation is an implementation detail. > + if (Appeture->PciRegionBase > MAX_UINT32) { > + Bridge->MemAbove4G.Base = Appeture->PciRegionBase; > + Bridge->MemAbove4G.Limit = Appeture->PciRegionLimit; > + Bridge->MemAbove4G.Translation = Appeture->PciRegionBase - Appeture->CpuMemRegionBase; > + } else { > + Bridge->Mem.Base = Appeture->PciRegionBase; > + Bridge->Mem.Limit = Appeture->PciRegionLimit; > + Bridge->Mem.Translation = Appeture->PciRegionBase - Appeture->CpuMemRegionBase; > + } > + > + DevicePath = AllocateCopyPool(sizeof mEfiPciRootBridgeDevicePath, &mEfiPciRootBridgeDevicePath); > + if (DevicePath == NULL) { > + DEBUG ((DEBUG_ERROR, "[%a]:[%dL] AllocatePool failed!\n", __FUNCTION__, __LINE__)); > + return EFI_OUT_OF_RESOURCES; > + } > + > + DevicePath->AcpiDevicePath.UID = Bridge->Segment; > + Bridge->DevicePath = (EFI_DEVICE_PATH_PROTOCOL *)DevicePath; > + return EFI_SUCCESS; > +} > + > +/** > + Return all the root bridge instances in an array. > + > + @param Count Return the count of root bridge instances. > + > + @return All the root bridge instances in an array. > + The array should be passed into PciHostBridgeFreeRootBridges() > + when it's not used. > +**/ > +PCI_ROOT_BRIDGE * > +EFIAPI > +PciHostBridgeGetRootBridges ( > + UINTN *Count > + ) > +{ > + EFI_STATUS Status; > + UINTN Loop1; > + UINTN Loop2; > + UINT32 PcieRootBridgeMask; > + UINTN RootBridgeCount = 0; > + PCI_ROOT_BRIDGE *Bridges; > + > + // Set default value to 0 in case we got any error. > + *Count = 0; > + > + > + if (!OemIsMpBoot()) > + { > + PcieRootBridgeMask = PcdGet32(PcdPcieRootBridgeMask); > + } > + else > + { > + PcieRootBridgeMask = PcdGet32(PcdPcieRootBridgeMask2P); > + } > + > + for (Loop1 = 0; Loop1 < PCIE_MAX_HOSTBRIDGE; Loop1++) { > + if (((PcieRootBridgeMask >> (PCIE_MAX_ROOTBRIDGE * Loop1)) & 0xFF ) == 0) { > + continue; > + } > + > + for (Loop2 = 0; Loop2 < PCIE_MAX_ROOTBRIDGE; Loop2++) { > + if (!(((PcieRootBridgeMask >> (PCIE_MAX_ROOTBRIDGE * Loop1)) >> Loop2 ) & 0x01)) { > + continue; > + } > + RootBridgeCount++; > + } > + } > + > + Bridges = AllocatePool (RootBridgeCount * sizeof *Bridges); > + if (Bridges == NULL) { > + DEBUG ((DEBUG_ERROR, "[%a:%d] - AllocatePool failed!\n", __FUNCTION__, __LINE__)); > + return NULL; > + } > + > + for (Loop1 = 0; Loop1 < PCIE_MAX_HOSTBRIDGE; Loop1++) { > + if (((PcieRootBridgeMask >> (PCIE_MAX_ROOTBRIDGE * Loop1)) & 0xFF ) == 0) { > + continue; > + } > + > + for (Loop2 = 0; Loop2 < PCIE_MAX_ROOTBRIDGE; Loop2++) { > + if (!(((PcieRootBridgeMask >> (PCIE_MAX_ROOTBRIDGE * Loop1)) >> Loop2 ) & 0x01)) { > + continue; > + } > + Status = ConstructRootBridge (&Bridges[*Count], &mResAppeture[Loop1][Loop2]); > + if (EFI_ERROR (Status)) { > + continue; > + } > + (*Count)++; > + } > + } > + > + if (*Count == 0) { > + FreePool (Bridges); > + return NULL; > + } > + return Bridges; > +} > + > +/** > + Free the root bridge instances array returned from PciHostBridgeGetRootBridges(). > + > + @param Bridges The root bridge instances array. > + @param Count The count of the array. > +**/ > +VOID > +EFIAPI > +PciHostBridgeFreeRootBridges ( > + PCI_ROOT_BRIDGE *Bridges, > + UINTN Count > + ) > +{ > + UINTN Index; > + > + for (Index = 0; Index < Count; Index++) { > + FreePool (Bridges[Index].DevicePath); > + } > + > + if (Bridges != NULL) { > + FreePool (Bridges); > + } > +} > + > + > +#ifndef MDEPKG_NDEBUG > +STATIC CONST CHAR16 mPciHostBridgeLibAcpiAddressSpaceTypeStr[][4] = { > + L"Mem", L"I/O", L"Bus" > +}; > +#endif > + > +/** > + Inform the platform that the resource conflict happens. > + > + @param HostBridgeHandle Handle of the Host Bridge. > + @param Configuration Pointer to PCI I/O and PCI memory resource > + descriptors. The Configuration contains the resources > + for all the root bridges. The resource for each root > + bridge is terminated with END descriptor and an > + additional END is appended indicating the end of the > + entire resources. The resource descriptor field > + values follow the description in > + EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL > + .SubmitResources(). > +**/ > +VOID > +EFIAPI > +PciHostBridgeResourceConflict ( > + EFI_HANDLE HostBridgeHandle, > + VOID *Configuration > + ) > +{ > + EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor; > + UINTN RootBridgeIndex; > + DEBUG ((DEBUG_ERROR, "PciHostBridge: Resource conflict happens!\n")); > + > + RootBridgeIndex = 0; > + Descriptor = (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *) Configuration; > + while (Descriptor->Desc == ACPI_ADDRESS_SPACE_DESCRIPTOR) { > + DEBUG ((DEBUG_ERROR, "RootBridge[%d]:\n", RootBridgeIndex++)); > + for (; Descriptor->Desc == ACPI_ADDRESS_SPACE_DESCRIPTOR; Descriptor++) { > + ASSERT (Descriptor->ResType < > + ARRAY_SIZE (mPciHostBridgeLibAcpiAddressSpaceTypeStr) > + ); > + DEBUG ((DEBUG_ERROR, " %s: Length/Alignment = 0x%lx / 0x%lx\n", > + mPciHostBridgeLibAcpiAddressSpaceTypeStr[Descriptor->ResType], > + Descriptor->AddrLen, Descriptor->AddrRangeMax > + )); > + if (Descriptor->ResType == ACPI_ADDRESS_SPACE_TYPE_MEM) { > + DEBUG ((DEBUG_ERROR, " Granularity/SpecificFlag = %ld / %02x%s\n", > + Descriptor->AddrSpaceGranularity, Descriptor->SpecificFlag, > + ((Descriptor->SpecificFlag & > + EFI_ACPI_MEMORY_RESOURCE_SPECIFIC_FLAG_CACHEABLE_PREFETCHABLE > + ) != 0) ? L" (Prefetchable)" : L"" > + )); > + } > + } > + // > + // Skip the END descriptor for root bridge > + // > + ASSERT (Descriptor->Desc == ACPI_END_TAG_DESCRIPTOR); > + Descriptor = (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *)( > + (EFI_ACPI_END_TAG_DESCRIPTOR *)Descriptor + 1 > + ); > + } > +} > -- > 2.7.4 >