From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 17FBA21CA3585 for ; Thu, 22 Jun 2017 04:07:37 -0700 (PDT) Received: by mail-io0-x22e.google.com with SMTP id e63so12034755iod.3 for ; Thu, 22 Jun 2017 04:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+g61afd8suJhpqNfo/YB9NKk5WP69ZnTsZtt82oQ2AE=; b=gX6zukLF5ZXc4Y7mvPYmqWDpv3ljWppI2U3N5S5m1ENJGWJSpnMrvCvtnS1zz5ynt3 S68nwc9r0s9g/HAMMQpOV8U/IrD1NC5m4jqwXINDfGgYybQox9lagvpELtEycIhZSG2A hZrXBj9uX4laRSshOVloN2Md8rcQTqlCWvur0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+g61afd8suJhpqNfo/YB9NKk5WP69ZnTsZtt82oQ2AE=; b=Qj0Rxcptj+fxNo9FiRgizEwjPjh+CxDhwB+CJuv7vIZa21+H5RbxfDVIyoSYlsLoS8 vkl3bk5iBVeN8HL3dzep0WW1qr1sV7u/4hxsMcYNsddhu9rvU0IwBpnpLnU9zhhw6aMP jqbhUB9/Z57j8Vw6+uugGTEsuZ5xfepRdLLz+AYDz8S3cq3s4kvhNg+pAHu5LfWT0FN3 M3asXBGAIPLvHtBr26GwgL/PRsC5/bPyTTUMTq2oNhycL+UXPuUlSf/8I5436WxDilTJ jzZYnGpG79Qq+h7QjIAzuZBYVHt2+my5wbRlZ+TMMOXU6dr2EwOxgMJAzCHj7BsDgDJ3 yr8Q== X-Gm-Message-State: AKS2vOyhBZAnsR658kG0EyQ/ZM3JeQ3hFMDp4jISYE1sbF/ChxqOZ/Xw gJGMEVvCQVBXEhkISqKETKpKuW+afRHG X-Received: by 10.107.63.139 with SMTP id m133mr1749193ioa.87.1498129741287; Thu, 22 Jun 2017 04:09:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.164.76 with HTTP; Thu, 22 Jun 2017 04:09:00 -0700 (PDT) In-Reply-To: <20170621124231.GF26676@bivouac.eciton.net> References: <1497984234-19871-1-git-send-email-ard.biesheuvel@linaro.org> <20170621124231.GF26676@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 22 Jun 2017 11:09:00 +0000 Message-ID: To: Leif Lindholm Cc: Laszlo Ersek , "edk2-devel@lists.01.org" , "Gao, Liming" , "Zhu, Yonghong" Subject: Re: [PATCH 1/2] BaseTools/tools_def GCC: ARM/AARCH64: replace -save-temps with -pipe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2017 11:07:37 -0000 Content-Type: text/plain; charset="UTF-8" On 21 June 2017 at 12:42, Leif Lindholm wrote: > On Wed, Jun 21, 2017 at 01:31:15PM +0200, Ard Biesheuvel wrote: >> > "-pipe" isn't used anywhere else in "tools_def.template". Can we imagine >> > a platform where cross-compiling to aarch64 with gcc works otherwise, >> > but "-pipe" might break that? Cygwin perhaps? (No clue, honestly.) >> > >> > For consistency with the rest of "tools_def.template", I'd suggest >> > simply dropping "-save-temps", and thinking about "-pipe" separately >> > (and then for all the GCC toolchains and for all arches). But, I don't >> > feel particularly strongly about this. >> > >> >> Yeah, that's a fair point. The fact that -save-temps is specific to >> ARM does not mean we should perpetuate that with -pipe. >> >> Leif, if you agree, I will drop the addition of -pipe from this patch, >> and we can revisit it later for all GCC flavors. > > Much as I would like to find out if there really are any platforms > that still have issues with -pipe (in which case, why wouldn't GCC > just use temp files anyway?), I guess that is a sensible approach. > > Reviewed-by: Leif Lindholm > for the dropping of -save-temps. > Thanks, pushed as fa6080138c08