Re: [PATCH] Platform/Armada/Pp2Dxe: switch to ArmDmaLib

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 29 August 2017 at 18:01, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> On 29 August 2017 at 16:53, Marcin Wojtas <mw@semihalf.com> wrote:
>> 2017-08-29 17:48 GMT+02:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:
>>> On 29 August 2017 at 16:47, Marcin Wojtas <mw@semihalf.com> wrote:
>>>> 2017-08-29 17:46 GMT+02:00 Leif Lindholm <leif.lindholm@linaro.org>:
>>>>> On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote:
>>>>>> Instead of hardcoding the non-cache coherent nature of this device
>>>>>> by invoking UncachedMemoryAllocationLib directly for allocating
>>>>>> shared buffers, switch to DmaLib, which encapsulates this at a
>>>>>> more abstract level. This allows the driver to be shared with
>>>>>> platforms that are cache coherent (by simply switching to another
>>>>>> DmaLib implementation), and removes the hardcoded dependency on
>>>>>> UncachedMemoryAllocationLib, which will be removed from upstream
>>>>>> EDK2.
>>>>>>
>>>>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>>>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>>>>
>>>>> Ah, and there is the non-bogus fix :)
>>>>> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>>>>
>>>> Please let me just run this on the HW before merge - I'll do it tomorrow.
>>>>
>>>
>>> Sure. Note that you will need to sync EDK2 after I merged the DmaLib
>>> changes (which I will do today)
>>
>> Ok, please let know once it's available and also it would be great if
>> this patch could be shared via github repo.
>>
>
> The prerequisite patches for DmaLib are in EDK2 now.
>
> https://git.linaro.org/people/ard.biesheuvel/edk2-platforms.git/log/?h=mvpp2-dmalib

Note that I just updated this branch to use NonCoherentDmaLib rather
than ArmDmaLib