From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x236.google.com (mail-it0-x236.google.com [IPv6:2607:f8b0:4001:c0b::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0969421E95E16 for ; Wed, 30 Aug 2017 06:23:45 -0700 (PDT) Received: by mail-it0-x236.google.com with SMTP id f1so5989988ith.0 for ; Wed, 30 Aug 2017 06:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KxGVvK2wMfHQHrf9u4jAXFTBq5a4+SU2RSWcbjv7wfQ=; b=ks82ANDyXNGGGdl+1iBnSRQ/61w4g09aq7Y4alDK51N3g1F5wvPT8RFpSjC7ZKSQbt bHnXXpmFGIq+bKlSiebPTue/jZpWa2Z+BzFCokpppDLaI9Slip53DTYp8VMicPZq14MR j1nZmC+PZwGD74DxtaPUaGIIizinyLAF0RHTg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KxGVvK2wMfHQHrf9u4jAXFTBq5a4+SU2RSWcbjv7wfQ=; b=lNQAVyU7LOH8p24ren75WOQhaFT3vqBmGMOnSRgo8OkanTft6Fggge89n1VwFst+Iz WR/o/iKMywMgr0G800NiZUeAkI6vFJjSNnZHbEZXCIieB6wng0+sfRcWwLKqAxUhuPu2 knjN3eiY/iWQQwuWhT2VZo+0A+5JXfbItRBzAiS/QpJYcmYxVuM+CRKkh1ed1t7QNnMB hLeY9BL/IJaf41d252JXwRdPZqXq6eHh6j3G53ILjB0SnxIAJ4fquNLvsFoSej7ZMgJK kYDBXOIJecpojr2PmR0aoY6ArK6Ozbq/6VhV+2ljBQHhnD/unSL9AckwGKPexyYBlpqy FLfg== X-Gm-Message-State: AHYfb5g8+T4sN4yTiCPXaaHoc7A6WsrXuOu8pcLp1f/OlZj9zBeQ5sBG I+OJqnC2XbNL6Pt7uEdZZaHMTCf4FeZL X-Received: by 10.36.201.70 with SMTP id h67mr1425309itg.162.1504099586009; Wed, 30 Aug 2017 06:26:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Wed, 30 Aug 2017 06:26:25 -0700 (PDT) In-Reply-To: References: <20170825122554.17819-1-ard.biesheuvel@linaro.org> <20170829154603.fvhfwp66asipxnoe@bivouac.eciton.net> From: Ard Biesheuvel Date: Wed, 30 Aug 2017 14:26:25 +0100 Message-ID: To: Marcin Wojtas Cc: Leif Lindholm , edk2-devel-01 Subject: Re: [PATCH] Platform/Armada/Pp2Dxe: switch to ArmDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 13:23:45 -0000 Content-Type: text/plain; charset="UTF-8" On 29 August 2017 at 18:01, Ard Biesheuvel wrote: > On 29 August 2017 at 16:53, Marcin Wojtas wrote: >> 2017-08-29 17:48 GMT+02:00 Ard Biesheuvel : >>> On 29 August 2017 at 16:47, Marcin Wojtas wrote: >>>> 2017-08-29 17:46 GMT+02:00 Leif Lindholm : >>>>> On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote: >>>>>> Instead of hardcoding the non-cache coherent nature of this device >>>>>> by invoking UncachedMemoryAllocationLib directly for allocating >>>>>> shared buffers, switch to DmaLib, which encapsulates this at a >>>>>> more abstract level. This allows the driver to be shared with >>>>>> platforms that are cache coherent (by simply switching to another >>>>>> DmaLib implementation), and removes the hardcoded dependency on >>>>>> UncachedMemoryAllocationLib, which will be removed from upstream >>>>>> EDK2. >>>>>> >>>>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>>>> Signed-off-by: Ard Biesheuvel >>>>> >>>>> Ah, and there is the non-bogus fix :) >>>>> Reviewed-by: Leif Lindholm >>>> >>>> Please let me just run this on the HW before merge - I'll do it tomorrow. >>>> >>> >>> Sure. Note that you will need to sync EDK2 after I merged the DmaLib >>> changes (which I will do today) >> >> Ok, please let know once it's available and also it would be great if >> this patch could be shared via github repo. >> > > The prerequisite patches for DmaLib are in EDK2 now. > > https://git.linaro.org/people/ard.biesheuvel/edk2-platforms.git/log/?h=mvpp2-dmalib Note that I just updated this branch to use NonCoherentDmaLib rather than ArmDmaLib