From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2E1BE210C1B9E for ; Wed, 25 Jul 2018 02:33:35 -0700 (PDT) Received: by mail-it0-x243.google.com with SMTP id s7-v6so7724495itb.4 for ; Wed, 25 Jul 2018 02:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KN/BLYlW0W6MS0HeymxoHnPZgYFjex+c3kHudz6e7E4=; b=WdGf4A2F28u75M4A9fXRgQIdKH4e1BziM8MOJDqacGnqtPJ+ZHY3WvExQdx1utR+EE /8vFqoIfTVxU0bSeES4jF4tv+lLJ/2wWdLvEO4K3q3uDwXwQbGxUiN+F0KBYblXHRi1n WOn6YdSNCszAjulZuuPiZUAg5KLB0gaHzZZRs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KN/BLYlW0W6MS0HeymxoHnPZgYFjex+c3kHudz6e7E4=; b=unkegP6hsWjCBRHTn7nVCoShj4XbDaRNL9k/NH5LA0DB83oG5Z6rpQRxmAude8GadX 1L/S8FWW0RnJfFSzukfPorelzrfjqFCvew8//H/7YKq0Cpo+Z8k7Wwa+OrG4IjqX9U0o tnKCxMu3b+wrbIZ0O6YtcRmE2tda9kWr8qpKin8OpJbDB6dmqhH7GcZbj02V0T4/27rz fRio5dURK+fQ1iSlqTwUhI8V0+sJZPKbKqU6ntsmjMCvjMf7++qmtLtCk8zE6q7tBzmA qjd6LgavkFALWXq/c3zDn68+Ot1lxob5pr6xF43aaN2ScbqUIvjUdDBfvCnVbJ/5v6z3 PbAQ== X-Gm-Message-State: AOUpUlGfpDpTbiS1rDObXips3H9sEjlOcuRHDVpF3XlVa+ZG6BOoKQkc s3LKOnNfeeONMXDwMjNVThWFzs9bz/EdmOqsiju98Q== X-Google-Smtp-Source: AAOMgpckTgGc2GouhZygm2/MKQfJzRGLCXsO7F++nxcM/jNX6FdnTUuc3PqO/QNhpvmszOmAFU4nnfvX69ow/Aza+aA= X-Received: by 2002:a02:bb04:: with SMTP id y4-v6mr19230693jan.5.1532511214598; Wed, 25 Jul 2018 02:33:34 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:ac05:0:0:0:0:0 with HTTP; Wed, 25 Jul 2018 02:33:34 -0700 (PDT) In-Reply-To: <1531469533-31787-1-git-send-email-mw@semihalf.com> References: <1531469533-31787-1-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Wed, 25 Jul 2018 11:33:34 +0200 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Nadav Haklai , Hanna Hawa , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk Subject: Re: [platforms: PATCH v2 0/6] Armada7k8k ICU support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 09:33:36 -0000 Content-Type: text/plain; charset="UTF-8" On 13 July 2018 at 10:12, Marcin Wojtas wrote: > Hi, > > The second version of the ICU patchset brings all corrections > according to all review remarks. They were mostly style / naming > - detailed list can be found in the changelog below. > > The patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/icu-upstream-r20180713 > > I'm looking forward to review and any comments/remarks. > > Best regards, > Marcin > > Changelog > v1 -> v2 > * 1,6 > - Add Ard's RB > > * 2 > - Change ICU_IRQ_TYPE to IcuIrqTypeLevel / IcuIrqTypeEdge > > * 3 > - Use EFI_PHYSICAL_ADDRESS > > * 4 > - Put a space after { and before } > - Change enum values to IcuGroupXxx format > > * 5 > - Use ICU_GROUP_REGISTER_BASE_OFFSET instead of a raw value in macros > - Add missing parentheses and use sizeof (UINT32) in ICU_INT_CFG macro > - Use mEfiExitBootServicesEvent - not initialized and STATIC > - s/IcuConfigDefault/IcuInitialConfig/ > - Break to long lines > > Marcin Wojtas (6): > Marvell/Armada70x0Db: Set correct CP110 count > Marvell/Library: Introduce ArmadaIcuLib class > Marvell/Library: Armada7k8kSoCDescLib: Enable getting CP base address > Marvell/Library: Armada7k8kSoCDescLib: Introduce ICU information > Marvell/Library: Implement common ArmadaIcuLib > Marvell/Armada7k8k: Enable ICU configuration > Reviewed-by: Ard Biesheuvel Pushed as 80f6be6eb12b..bd325517ba42 (with 5/6 updated to the v3 version) > Silicon/Marvell/Marvell.dec | 1 + > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + > Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 7 +- > Silicon/Marvell/Armada7k8k/Drivers/PlatInitDxe/PlatInitDxe.inf | 1 + > Silicon/Marvell/Library/IcuLib/IcuLib.inf | 38 +++ > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 12 + > Silicon/Marvell/Include/Library/ArmadaIcuLib.h | 45 +++ > Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h | 39 +++ > Silicon/Marvell/Library/IcuLib/IcuLib.h | 47 +++ > Silicon/Marvell/Armada7k8k/Drivers/PlatInitDxe/PlatInitDxe.c | 2 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 50 +++ > Silicon/Marvell/Library/IcuLib/IcuLib.c | 317 ++++++++++++++++++++ > 12 files changed, 558 insertions(+), 2 deletions(-) > create mode 100644 Silicon/Marvell/Library/IcuLib/IcuLib.inf > create mode 100644 Silicon/Marvell/Include/Library/ArmadaIcuLib.h > create mode 100644 Silicon/Marvell/Library/IcuLib/IcuLib.h > create mode 100644 Silicon/Marvell/Library/IcuLib/IcuLib.c > > -- > 2.7.4 >