From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::144; helo=mail-it1-x144.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 055D021959CB2 for ; Wed, 19 Dec 2018 02:08:59 -0800 (PST) Received: by mail-it1-x144.google.com with SMTP id m62so8798353ith.5 for ; Wed, 19 Dec 2018 02:08:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JOEuIXKjjPL8zvHqgXpJoY+msbKteepc0GO8iZeB5Bo=; b=H8UvI9+P2c53MfOacDBHHaAgi4HcZg1MeGGwhPtq6owEsWebx/VvpE9JDkZTGCg51L ScEaNx1woy4HgvNc6GpsT0i8MFQ4LiAf3nCX1uGKiOd0UfgaEEzZdZn3rOPLNGjv/SRy D3VB9TwezU98OJ138+FbAK6MuMKHl1CuprltE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JOEuIXKjjPL8zvHqgXpJoY+msbKteepc0GO8iZeB5Bo=; b=m3DMCX8zRVkIbA0ZFFpgDzFDM2nOesy3oe/DjRPMy4w+GE1vM4jJ3gCvaa1w36UVv5 w0yktf3xrIS9QRUJBGnjfUykUxEaTpTyxs1bfd8KwnlIFXBcU04P1L2J12ziJ3q2nT9k OgTMSH9Q4BIJbU1dTSW3SFegdlSNQAXP24oj1CWZINmpUdLacF2oWevnq4xmWk+u2Rr/ 8sT4efXDCRsB6ZOUrhyKt5QoyY7e8Zw1ilOgpL1Wy6+WKiQ5Luz/sB2hl2p/zIbinO7j Bg1/jsj6RnkUNH8lmKDkw99Ruycz8dBPXYxWxmYbAuOfx582Vr9m82g4KLpnhspxaaEx SOrw== X-Gm-Message-State: AA+aEWZ3ovlJ+aOVyOEPcVFIDCHjwD4GTInw86BLjvD2MQe8xwm0RBzH KT20gMu2r06vG11sgpE+uuZ/p6sPX67eOixEynWFT6cd6B7YKQ== X-Google-Smtp-Source: AFSGD/XTSXXznLMB1DS0d76c1nHxRueQkyfqK+pHJ+27AYfs5umtk41nEoBVMZ0dHw0rvPQaM10PhdCQXAlVWa4xhjw= X-Received: by 2002:a05:660c:4b:: with SMTP id p11mr6155826itk.71.1545214138985; Wed, 19 Dec 2018 02:08:58 -0800 (PST) MIME-Version: 1.0 References: <20181218183846.31999-1-leif.lindholm@linaro.org> In-Reply-To: <20181218183846.31999-1-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Wed, 19 Dec 2018 11:08:48 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] ArmPkg: drop ArmBds remnant Pcds from .dec X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 10:09:00 -0000 Content-Type: text/plain; charset="UTF-8" On Tue, 18 Dec 2018 at 19:38, Leif Lindholm wrote: > > The following Pcds > - gArmTokenSpaceGuid.PcdArmLinuxSpinTable > - gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset > - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset > - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment > remained defined, without actual users. > So get rid of them. > > One reference to be deleted separately from edk2-platforms. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel > --- > ArmPkg/ArmPkg.dec | 20 -------------------- > 1 file changed, 20 deletions(-) > > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec > index d99eb6769f..0ec5e8efd6 100644 > --- a/ArmPkg/ArmPkg.dec > +++ b/ArmPkg/ArmPkg.dec > @@ -80,10 +80,6 @@ [PcdsFeatureFlag.common] > # it has been configured by the CPU DXE > gArmTokenSpaceGuid.PcdDebuggerExceptionSupport|FALSE|BOOLEAN|0x00000032 > > - # Define if the spin-table mechanism is used by the secondary cores when booting > - # Linux (instead of PSCI) > - gArmTokenSpaceGuid.PcdArmLinuxSpinTable|FALSE|BOOLEAN|0x00000033 > - > # Define if the GICv3 controller should use the GICv2 legacy > gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042 > > @@ -173,16 +169,6 @@ [PcdsFixedAtBuild.ARM] > # By default we do not do a transition to non-secure mode > gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x0|UINT32|0x0000003E > > - # The Linux ATAGs are expected to be under 0x4000 (16KB) from the beginning of the System Memory > - gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset|0x4000|UINT32|0x00000020 > - > - # If the fixed FDT address is not available, then it should be loaded below the kernel. > - # The recommendation from the Linux kernel is to have the FDT below 16KB. > - # (see the kernel doc: Documentation/arm/Booting) > - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x4000|UINT32|0x00000023 > - # The FDT blob must be loaded at a 64bit aligned address. > - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x8|UINT32|0x00000026 > - > # Non Secure Access Control Register > # - BIT15 : NSASEDIS - Disable Non-secure Advanced SIMD functionality > # - BIT14 : NSD32DIS - Disable Non-secure use of D16-D31 > @@ -221,12 +207,6 @@ [PcdsFixedAtBuild.AARCH64] > # Other modes include using SP0 or switching to Aarch32, but these are > # not currently supported. > gArmTokenSpaceGuid.PcdArmNonSecModeTransition|0x3c9|UINT32|0x0000003E > - # If the fixed FDT address is not available, then it should be loaded above the kernel. > - # The recommendation from the AArch64 Linux kernel is to have the FDT below 512MB. > - # (see the kernel doc: Documentation/arm64/booting.txt) > - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset|0x20000000|UINT32|0x00000023 > - # The FDT blob must be loaded at a 2MB aligned address. > - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment|0x00200000|UINT32|0x00000026 > > > # > -- > 2.11.0 >