From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BE7782270D358 for ; Wed, 11 Apr 2018 23:17:58 -0700 (PDT) Received: by mail-it0-x243.google.com with SMTP id 19-v6so5664285itw.3 for ; Wed, 11 Apr 2018 23:17:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=z0s4TYENFjjWurH/aNulhBKrOoqBwCQpVXZb7cMcBoM=; b=Q9dut/SQepTywyYUY82sBCqiINYIfGuLdDxOO7YjJcr2Gj72r9hOrzslLk0fxy6NYl E7pkaYEbZZTuw2MvKZMxIfZhTW0qOPWJDO+Sd5wwE5UwSCRh99Xi1npnM71rqYT874xi YTs7BrsRhGCQj4dpHO0rjyp/32IOytvb1z0ig= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=z0s4TYENFjjWurH/aNulhBKrOoqBwCQpVXZb7cMcBoM=; b=O27mQnT/MIWai3VzdQz43UK5kTSehB/dc956w/ehcdNpECeHHfs74lcSidIbGp6ZOe tFxwhwFceSBQysc8uk2GRw05rbqsuybezN31HTfg/kd+2F0mxZN8SfTpVXnSiLnGkaCr jDFzeZmscK9OI2/PvsNEU+EAjG6FMPwBJizVBWknOtFDZg1y3TVnneAKSnE53ELdOiz1 lOIY7japh+UGFFSv924RIt6utKhTzko71EwybDkeO4AbLgrmkKtBdrSrfRICyLnJZYHW L4I/45AgAqlYefq/VLbRIZSljoVJopwIsGQ6PsDKujhPGxpmBzJPrctJMeb1OFZQY0iT Akcw== X-Gm-Message-State: ALQs6tBv7h1MZZiAXHry4H621Bap46ff4m9u93nuxp05Po8PHScue2ko Q6B5RbFmR3jxjmsYwHG+syeeYJWYkC74rGg8/NKnvQ== X-Google-Smtp-Source: AIpwx4/C1O3bzHwTewdSlja088l5fWHUp3Gvt3iRl0bAnJTdd6LBoDOMwzQ2/L7o7zy6s9t7ChgTILTvvtgGfgDTzcs= X-Received: by 2002:a24:30c:: with SMTP id e12-v6mr7152385ite.50.1523513877607; Wed, 11 Apr 2018 23:17:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Wed, 11 Apr 2018 23:17:57 -0700 (PDT) In-Reply-To: <20180412010131.21848-4-michael.d.kinney@intel.com> References: <20180412010131.21848-1-michael.d.kinney@intel.com> <20180412010131.21848-4-michael.d.kinney@intel.com> From: Ard Biesheuvel Date: Thu, 12 Apr 2018 08:17:57 +0200 Message-ID: To: "Kinney, Michael D" Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [edk2-platforms Patch V2 3/6] SynQuacer/PlatformFlashAccessLib: Add progress API X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 06:17:59 -0000 Content-Type: text/plain; charset="UTF-8" On 12 April 2018 at 03:01, Kinney, Michael D wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=801 > > Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. > This allows the platform to inform the user of progress when a > firmware storage device is being updated with a new firmware > image. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 IIUC, this is the bare minimum to get it building again, and we'll need to replace the existing progress indicator implementation with calls into the generic on, right? That's fine, but it would be useful to mention this in the commit log. > --- > .../SynQuacerPlatformFlashAccessLib.c | 78 +++++++++++++++++++--- > 1 file changed, 67 insertions(+), 11 deletions(-) > > diff --git a/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c b/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c > index fbb8f1f9e4..4cf8318a93 100644 > --- a/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c > +++ b/Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c > @@ -2,6 +2,7 @@ > Platform flash device access library for Socionext SynQuacer > > Copyright (c) 2016, Linaro, Ltd. All rights reserved.
> + Copyright (c) 2018, Intel Corporation. All rights reserved.
> > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD License > @@ -117,13 +118,29 @@ GetFvbByAddress ( > } > > /** > - Perform flash write operation. > + Perform flash write operation with progress indicator. The start and end > + completion percentage values are passed into this function. If the requested > + flash write operation is broken up, then completion percentage between the > + start and end values may be passed to the provided Progress function. The > + caller of this function is required to call the Progress function for the > + start and end completion percentage values. This allows the Progress, > + StartPercentage, and EndPercentage parameters to be ignored if the requested > + flash write operation can not be broken up > > @param[in] FirmwareType The type of firmware. > @param[in] FlashAddress The address of flash device to be accessed. > @param[in] FlashAddressType The type of flash device address. > @param[in] Buffer The pointer to the data buffer. > @param[in] Length The length of data buffer in bytes. > + @param[in] Progress A function used report the progress of the > + firmware update. This is an optional parameter > + that may be NULL. > + @param[in] StartPercentage The start completion percentage value that may > + be used to report progress during the flash > + write operation. > + @param[in] EndPercentage The end completion percentage value that may > + be used to report progress during the flash > + write operation. > > @retval EFI_SUCCESS The operation returns successfully. > @retval EFI_WRITE_PROTECTED The flash device is read only. > @@ -132,12 +149,15 @@ GetFvbByAddress ( > **/ > EFI_STATUS > EFIAPI > -PerformFlashWrite ( > - IN PLATFORM_FIRMWARE_TYPE FirmwareType, > - IN EFI_PHYSICAL_ADDRESS FlashAddress, > - IN FLASH_ADDRESS_TYPE FlashAddressType, > - IN VOID *Buffer, > - IN UINTN Length > +PerformFlashWriteWithProgress ( > + IN PLATFORM_FIRMWARE_TYPE FirmwareType, > + IN EFI_PHYSICAL_ADDRESS FlashAddress, > + IN FLASH_ADDRESS_TYPE FlashAddressType, > + IN VOID *Buffer, > + IN UINTN Length, > + IN EFI_FIRMWARE_MANAGEMENT_UPDATE_IMAGE_PROGRESS Progress, OPTIONAL > + IN UINTN StartPercentage, > + IN UINTN EndPercentage > ) > { > EFI_FIRMWARE_VOLUME_BLOCK_PROTOCOL *Fvb; > @@ -150,7 +170,7 @@ PerformFlashWrite ( > EFI_GRAPHICS_OUTPUT_BLT_PIXEL_UNION Black; > EFI_GRAPHICS_OUTPUT_BLT_PIXEL_UNION White; > UINTN Resolution; > - UINTN Progress; > + UINTN CurrentProgress; > BOOLEAN HaveBootGraphics; > > Black.Raw = 0x00000000; > @@ -228,7 +248,7 @@ PerformFlashWrite ( > > if (HaveBootGraphics) { > Resolution = (BlockSize * 100) / Length + 1; > - Progress = 0; > + CurrentProgress = 0; > > Status = BootLogoUpdateProgress (White.Pixel, Black.Pixel, > L"Updating firmware - please wait", Black.Pixel, 100, 0); > @@ -268,8 +288,8 @@ PerformFlashWrite ( > if (HaveBootGraphics) { > Status = BootLogoUpdateProgress (White.Pixel, Black.Pixel, > L"Updating firmware - please wait", White.Pixel, > - Progress + Resolution, Progress); > - Progress += Resolution; > + CurrentProgress + Resolution, CurrentProgress); > + CurrentProgress += Resolution; > } else { > Print (L"."); > } > @@ -284,3 +304,39 @@ PerformFlashWrite ( > > return EFI_SUCCESS; > } > + > +/** > + Perform flash write operation. > + > + @param[in] FirmwareType The type of firmware. > + @param[in] FlashAddress The address of flash device to be accessed. > + @param[in] FlashAddressType The type of flash device address. > + @param[in] Buffer The pointer to the data buffer. > + @param[in] Length The length of data buffer in bytes. > + > + @retval EFI_SUCCESS The operation returns successfully. > + @retval EFI_WRITE_PROTECTED The flash device is read only. > + @retval EFI_UNSUPPORTED The flash device access is unsupported. > + @retval EFI_INVALID_PARAMETER The input parameter is not valid. > +**/ > +EFI_STATUS > +EFIAPI > +PerformFlashWrite ( > + IN PLATFORM_FIRMWARE_TYPE FirmwareType, > + IN EFI_PHYSICAL_ADDRESS FlashAddress, > + IN FLASH_ADDRESS_TYPE FlashAddressType, > + IN VOID *Buffer, > + IN UINTN Length > + ) > +{ > + return PerformFlashWriteWithProgress ( > + FirmwareType, > + FlashAddress, > + FlashAddressType, > + Buffer, > + Length, > + NULL, > + 0, > + 0 > + ); > +} > -- > 2.14.2.windows.3 >