Re: [PATCH edk2-staging 07/20] IntelUndiPkg/XGigUndiDxe: drop definition of gImageHandle

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On Wed, 30 Jan 2019 at 17:05, Ryszard Knop <ryszard.knop@linux.intel.com> wrote:
>
> Hmm, is there a list/something I can generate to see which globals
> build tools emit? There are some more variables I'd happily get rid
> of, eg if I could drop gSystemTable and others.
>

You can look at the contents of the various AutoGen.h files in the Build/ folder


> Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
>
> On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> > Remove duplicate definition of gImageHandle, which is emitted by
> > the build tools as well.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> > ---
> >  IntelUndiPkg/XGigUndiDxe/Init.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/IntelUndiPkg/XGigUndiDxe/Init.c
> > b/IntelUndiPkg/XGigUndiDxe/Init.c
> > index 84e06ea071c5..03e3942a1944 100644
> > --- a/IntelUndiPkg/XGigUndiDxe/Init.c
> > +++ b/IntelUndiPkg/XGigUndiDxe/Init.c
> > @@ -47,7 +47,6 @@ UINT16             mActiveChildren    = 0;
> >  EFI_EVENT          gEventNotifyExitBs;
> >  EFI_EVENT          gEventNotifyVirtual;
> >
> > -EFI_HANDLE        gImageHandle;
> >  EFI_SYSTEM_TABLE *gSystemTable;
> >
> >  EFI_GUID gEfiNiiPointerGuid = EFI_NII_POINTER_PROTOCOL_GUID;
> > @@ -502,7 +501,6 @@ InitializeXGigUndiDriver (
> >  {
> >    EFI_STATUS                 Status;
> >
> > -  gImageHandle  = ImageHandle;
> >    gSystemTable  = SystemTable;
> >
> >    Status = EfiLibInstallDriverBinding (ImageHandle, SystemTable,
> > &gUndiDriverBinding, ImageHandle);
>