From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d43; helo=mail-io1-xd43.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1C88F211BFCC8 for ; Wed, 30 Jan 2019 08:06:43 -0800 (PST) Received: by mail-io1-xd43.google.com with SMTP id m19so50921ioh.3 for ; Wed, 30 Jan 2019 08:06:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=68aon2w9UrJ/srYrFb2kUel+XmczTANBIjs33c+bSVg=; b=k1iCAdssTgcv8hrJH/KQ5eUSphCE8RJFxL61Bt7t3T9A+cAkYEu3N+bt102ar0Jyex bWgoisBjpkNXNsUa8zSYhqnh5XqXhr8aiiBNr9tqbbh+lvvUNt0McJSpIKF/nA41W6dE ROL8lvv/MVi0rzhMupFKFibsikg4fuh2btnYc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=68aon2w9UrJ/srYrFb2kUel+XmczTANBIjs33c+bSVg=; b=d1XghD0mF6YGXlMAOMLpBs78oHt60tvkO4ouqXmJVzv9mojTKVsHhtP8Zjl07R/lSN KkEu1mE7y+L9vWPk3MGKXyJhuCxDvgy+wbzeq45CkexpiJEkijL2k9wV/K+SSqJuoHKb pcjX9ihXun97D5c8bMWa6nVMOtL3kbwhUsFntxcdgkmhb2PDqFxDI11NOFcTHWRpuIn0 UFwF6XCnGbdlGOBmeCGQpR1c5Ug7td7Bb3QLXpESIqOMmXipQ8JPVoW1EsAHjFM+F29e 6G+1AuvjL2iwzZ0ahacJwwXg4/ibBR4cksjBxNsC9al8GpL5TgDj9SNF7M5cSXcTKGuM KHkQ== X-Gm-Message-State: AHQUAuaeKb1ZaSuXotbIZeDUKAfdAJa1JmubAW0uMDYn9LDLNEmfyMST OZcNeVAgq2c1QQmA9Zj4lLcxL+h7dfRjAmev9NVSWw== X-Google-Smtp-Source: AHgI3Ia9KRhiBdMJdVY63emBYvVuO+RhI71/ReBKE3pmkt19+V1B3kz5MtmE8691P/I1A/OeACVmlLEQP5rv7Mt/9YM= X-Received: by 2002:a6b:5d01:: with SMTP id r1mr3101015iob.170.1548864402114; Wed, 30 Jan 2019 08:06:42 -0800 (PST) MIME-Version: 1.0 References: <20181115023353.20159-1-ard.biesheuvel@linaro.org> <20181115023353.20159-8-ard.biesheuvel@linaro.org> <609fae1744b07f3256d768680a50585683e3817d.camel@linux.intel.com> In-Reply-To: <609fae1744b07f3256d768680a50585683e3817d.camel@linux.intel.com> From: Ard Biesheuvel Date: Wed, 30 Jan 2019 17:06:29 +0100 Message-ID: To: Ryszard Knop Cc: "edk2-devel@lists.01.org" , "Kacperski, Kamil" , "Jin, Eric" , "Orlowski, Pawel" , "Kinney, Michael D" , "Hsiung, Harry L" Subject: Re: [PATCH edk2-staging 07/20] IntelUndiPkg/XGigUndiDxe: drop definition of gImageHandle X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:06:43 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 30 Jan 2019 at 17:05, Ryszard Knop wrote: > > Hmm, is there a list/something I can generate to see which globals > build tools emit? There are some more variables I'd happily get rid > of, eg if I could drop gSystemTable and others. > You can look at the contents of the various AutoGen.h files in the Build/ folder > Reviewed-by: Ryszard Knop > > On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote: > > Remove duplicate definition of gImageHandle, which is emitted by > > the build tools as well. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > --- > > IntelUndiPkg/XGigUndiDxe/Init.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/IntelUndiPkg/XGigUndiDxe/Init.c > > b/IntelUndiPkg/XGigUndiDxe/Init.c > > index 84e06ea071c5..03e3942a1944 100644 > > --- a/IntelUndiPkg/XGigUndiDxe/Init.c > > +++ b/IntelUndiPkg/XGigUndiDxe/Init.c > > @@ -47,7 +47,6 @@ UINT16 mActiveChildren = 0; > > EFI_EVENT gEventNotifyExitBs; > > EFI_EVENT gEventNotifyVirtual; > > > > -EFI_HANDLE gImageHandle; > > EFI_SYSTEM_TABLE *gSystemTable; > > > > EFI_GUID gEfiNiiPointerGuid = EFI_NII_POINTER_PROTOCOL_GUID; > > @@ -502,7 +501,6 @@ InitializeXGigUndiDriver ( > > { > > EFI_STATUS Status; > > > > - gImageHandle = ImageHandle; > > gSystemTable = SystemTable; > > > > Status = EfiLibInstallDriverBinding (ImageHandle, SystemTable, > > &gUndiDriverBinding, ImageHandle); >