From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d43; helo=mail-io1-xd43.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 97EDB21A02937 for ; Tue, 27 Nov 2018 04:07:27 -0800 (PST) Received: by mail-io1-xd43.google.com with SMTP id n9so16755035ioh.7 for ; Tue, 27 Nov 2018 04:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zX6V7cs3Me+6p3s13I1CcW12nwldiic3/DOnSh1C3Xg=; b=g5XOVsP9TNiLYB9HXNIZ4DgOdHHbjxCyfwHuCGgzp9BWaM2JIpEGsIfYFQGeilR+dP PyJZmcKwvQZiCIOmTypztG5HVx9FHJqGiZAY4jIK5ax4aOP8JLav3nGOFtxJRfGU49uu x3kDCJXphiArLQ9oLPKAp3ZfW3on3nSQ4qRvQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zX6V7cs3Me+6p3s13I1CcW12nwldiic3/DOnSh1C3Xg=; b=dQX1Z1LiopIeeVUPV0l/YXCvb/JiKDAq/97l+5+5yVlJuLNuHH5pwui7YJjpKKWWqj ONfHX+Z60fQiOwVeG4J7zGio7swLis10UJtl+p87FjpObRE1Jd+8CSZAOfHM0eaApIXC l9g2mnhM+dWQQr0WNiO5RNt48Zx5ryzCqgl/2c7GboDWPe2qVbT7Azj1PCSfLI/IHo8F siYd2/HfMNCK/vd7CazV/Ovqh5G74yWR8OMB3dL3/dod7jFZwdbjlCtOU0cOYmwWLpek hg2rtXGA10nQ/xQSnCweaHrJ4h6WNvCgBSos+1Uce7ySVPwxNOkH4GlZLbEC2eangQpo sL0Q== X-Gm-Message-State: AA+aEWZ0tqcaB67Nip4pnXwUms7DNAU0odz6M0db0Y2VvpLIVB6IYczU NKoW5BPq1Uk16HB+HssJJhZjg+DPlhwrJ4flsIV0k9Rv5Y8= X-Google-Smtp-Source: AFSGD/Vj8avX+KXe5E9AqVT/Da4di2husshRCPceyLer0e7JxJtLgEmJPK7MNDd/CC9TshWJ+3vrQ+oQkz5YFfzy7rs= X-Received: by 2002:a5d:8402:: with SMTP id i2mr15743501ion.173.1543320446153; Tue, 27 Nov 2018 04:07:26 -0800 (PST) MIME-Version: 1.0 References: <20181121115828.3026-1-ard.biesheuvel@linaro.org> In-Reply-To: From: Ard Biesheuvel Date: Tue, 27 Nov 2018 13:07:14 +0100 Message-ID: To: "edk2-devel@lists.01.org" Cc: Leif Lindholm , Laszlo Ersek , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Hongbo Zhang , Nariman Poushin , Thomas Panakamattam Abraham Subject: Re: [PATCH v2 0/5] ArmPlatformPkg, ArmVirtPkg: discover NOR flash banks from DTB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 12:07:27 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 26 Nov 2018 at 18:02, Ard Biesheuvel wrote: > > On Mon, 26 Nov 2018 at 18:00, Ard Biesheuvel wrote: > > > > On Wed, 21 Nov 2018 at 12:58, Ard Biesheuvel wrote: > > > > > > This series fixes an issue reported by Hongbo and Philippe, where > > > ArmVirtQemuKernel will crash on an attempt to access flash bank #0, > > > which is secure-only when running QEMU with support for EL3. > > > > > > So let's switch to discovering the NOR flash banks from the device tree > > > instead. This requires some preparatory changes in the NOR flash driver > > > to avoid having to invent GUIDs on the fly. > > > > > > Changes since v1: > > > - split ArmPlatformPkg for clarity > > > - move DT node status check into FdtClientDxe where it belongs > > > - use correct UINT32* type for DT property values, and be pedantic about > > > their potential misalignment when casting to UINT64* > > > - add patch to remove the 'Guid' member from NOR_FLASH_DESCRIPTION > > > - add some acks > > > > > > Ard Biesheuvel (5): > > > ArmPlatformPkg/NorFlashDxe: prepare for devicepath format change > > > ArmPlatformPkg/NorFlashDxe: use one GUID plus index to identify flash > > > banks > > > ArmVirtPkg/FdtClientDxe: take DT node 'status' properties into account > > > ArmVirtPkg/NorFlashQemuLib: discover NOR flash banks dynamically > > > ArmPlatformPkg/NorFlashPlatformLib: remove unused Guid member from > > > struct > > > > > > .../Drivers/NorFlashDxe/NorFlashDxe.c | 15 ++-- > > > .../Drivers/NorFlashDxe/NorFlashDxe.h | 3 + > > > .../Include/Library/NorFlashPlatformLib.h | 1 - > > > ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 38 +++++++-- > > > .../Library/NorFlashQemuLib/NorFlashQemuLib.c | 78 ++++++++++++++----- > > > .../NorFlashQemuLib/NorFlashQemuLib.inf | 12 +++ > > > 6 files changed, 114 insertions(+), 33 deletions(-) > > > > > > > Pushed as 1ec194b21c0e..72e514c90730 > > > > Thanks all > > Forgot to add: minus the 5th patch, which I will push once the > dependent changes in edk2-platforms have been pushed. #5 now pushed as 13d5d0a56e486be39f95c5e0883e64698ed02714