From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=hIO5ZM0m;
 spf=pass (domain: linaro.org, ip: 209.85.166.65, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65])
 by groups.io with SMTP; Mon, 17 Jun 2019 10:21:37 -0700
Received: by mail-io1-f65.google.com with SMTP id e5so22979045iok.4
        for <devel@edk2.groups.io>; Mon, 17 Jun 2019 10:21:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=Vt8KO48G5nfnaF/0cLit1TozO3Qh2DslcAPdy6kSauc=;
        b=hIO5ZM0mtsfLRJxzNjI3lpNO/ChQ2XAegICbcLc3RCCaYAwAyyFi4+cTsqWZwiEVcD
         nh/NptOVEBdHXCigNgxYlwOoQEA0zeNIFaHh5q73gWThenZgGQ1wit8PYwJMCOj//zCE
         QX9mqz/qRFJxAQErt7d7e82q9dnIQnYzUi1W6TLWGFDaYLUVi11SwFZ/zh1OLvqVhFT1
         +nIErtD5XUg5dk/Bf89mY7t1m9QFPj0pxU+ujOW/xlv3UpF/IwNlQ+CH+0w9WRmr3FiE
         VWRhniMPfNEnGDCeW2xtG8zwfgZsOILX6ixlLrhvx1wpmVnt0mVQe1vc9QWU/lIQNAGa
         ChMw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=Vt8KO48G5nfnaF/0cLit1TozO3Qh2DslcAPdy6kSauc=;
        b=fBh2WzpQGu5Y7IcN+FYx74JZPOdC6jNSeNtasjNa8xS5aFlaDzbDczqtqFz13VQbi7
         yC8dpEr4jZrcdtd1Kc0I5go6jXJp1DE2511T5FY3IUGUU7NVO1sBRd2wMxtlnnOFR3GW
         KSdrWoZfPUOjHXlQlZhucRAsYjHH+nf4x9XCpcfoKmEA0DZJg6YbLOrwuUgdV+ThBnX+
         KOPSOM2NDali4WKEL9/UPlW/QznCXOpJm0wH7c8QJwn3WULV3lhb9ULP3SIoaKpvsy9P
         9CWaaIbpbkHw7OX38fjwnxALANv+0rozsolMDfsC117WuKZ+AEppwnH+hFc42W0uyTuL
         mg2A==
X-Gm-Message-State: APjAAAXaKQBV3IAB9v4c5pEk430hZwt+wPgCQJImvZWM5plgppIlfM10
	AoZgkW1UM6FJlgOHRsrVGYvDd9H03uAakYvuQ0Xj9g==
X-Google-Smtp-Source: APXvYqwheaQgPDLCzbtOl89coIs4l9RHE+qFa3lsTznBOFAdmzzZ9FTatmgnH0dPZqXQ4tw4xE4ApdGou93ChCdFa3o=
X-Received: by 2002:a5d:9d97:: with SMTP id 23mr27620897ion.204.1560791205953;
 Mon, 17 Jun 2019 10:06:45 -0700 (PDT)
MIME-Version: 1.0
References: <20190617065146.32648-1-dandan.bi@intel.com> <20190617065146.32648-2-dandan.bi@intel.com>
 <20190617164823.uxnoamz34ft24ak3@bivouac.eciton.net>
In-Reply-To: <20190617164823.uxnoamz34ft24ak3@bivouac.eciton.net>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Mon, 17 Jun 2019 19:06:33 +0200
Message-ID: <CAKv+Gu8TiX=SRwioFHHyvE4BG1vEZMnxSfUJQSNKX0efS9rH+w@mail.gmail.com>
Subject: Re: [edk2-devel] [edk2-platforms] [patch v2 1/2] Platform/Intel: Add UserInterfaceFeaturePkg
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Dandan Bi <dandan.bi@intel.com>, 
	Eric Dong <eric.dong@intel.com>, Liming Gao <liming.gao@intel.com>, 
	Michael D Kinney <michael.d.kinney@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 17 Jun 2019 at 18:48, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> Hi Dandan,
>
> On Mon, Jun 17, 2019 at 02:51:45PM +0800, Dandan Bi wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1545
> >
> > Add new package UserInterfaceFeaturePkg in Platform/Intel/
> > folder. It will keep UI related modules in this package.
> >
> > We plan add UserAuthentication modules in Platform/Intel.
> > Firstly we add a new package UserInterfaceFeaturePkg where
> > add the UserAuthentication modules into.
> > Package name follows the discussion in:
> > https://edk2.groups.io/g/devel/message/42286
> >
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> > ---
> >  Maintainers.txt                               |  4 ++++
> >  .../UserInterfaceFeaturePkg.dec               | 19 +++++++++++++++
> >  .../UserInterfaceFeaturePkg.dsc               | 23 +++++++++++++++++++
> >  3 files changed, 46 insertions(+)
> >  create mode 100644 Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dec
> >  create mode 100644 Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index cb9e15e880..c55a285fa1 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -71,10 +71,14 @@ R: Liming Gao <liming.gao@intel.com>
> >
> >  Platform/Intel/DebugFeaturePkg
> >  M: Eric Dong <eric.dong@intel.com>
> >  R: Liming Gao <liming.gao@intel.com>
> >
> > +Platform/Intel/UserInterfaceFeaturePkg
> > +M: Dandan Bi <dandan.bi@intel.com>
> > +R: Liming Gao <liming.gao@intel.com>
> > +
>
> Could you please cc all of the top-level maintainers (me, Ard and
> Mike) when modifying Maintainers.txt?
> Once the GetMaintainer.py we'll be able to do all of this more cleanly.
>
> I'm not saying you need all of our Reviewed-by:, but I'd like to not
> miss when new maintainerships are being added.
>

What is Intel specific about these user interface features? Do they
belong in Platform/Intel?