From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65])
 by mx.groups.io with SMTP id smtpd.web10.3847.1581670558392633016
 for <devel@edk2.groups.io>;
 Fri, 14 Feb 2020 00:55:58 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=wQ11c3YD;
 spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wm1-f65.google.com with SMTP id a9so9686528wmj.3
        for <devel@edk2.groups.io>; Fri, 14 Feb 2020 00:55:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=bP42QMY7aESPeIdT1ZKvUFbJnnAA3pjencDjodq6fQg=;
        b=wQ11c3YDhq/cvwtGO9KapQvEfZVrg6dPvLV7KcEtdc4Hhnt/cpOBggWB0AAfTrrRgb
         kOAZf0UGz6gqx0n8K6g8eS27ZMqRcbsahEogTmtUxGzsH7t0Ly9ePV5Zbly5vcg/K4dd
         bSyLw0h1I8fwVVBBBAk9ctBRtVkbmlKrN1x0scAbiMHNr75tVjl2hfKaa91OJqXJmPU6
         q3CNSmKLOmlb3xzuJQzHcqXA26BkYHy7HCzOqZQbvW3WwsfGm4qMUoF+iqMVlan/GO7r
         blBaxww1gAfha2C/jhPGtuc4aouHdfcglkSkmRnMJ/nbn5XVLvSuJdRcvjuUkM/SkZ4s
         vx6Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=bP42QMY7aESPeIdT1ZKvUFbJnnAA3pjencDjodq6fQg=;
        b=Oxy+5BJDJqzq0h6S3DpGs3YkvAp3sSD97LIydfAJM6A2IU5ousGM7CDATSgKq8BKnJ
         e+Xi1RC5klXJuxI3VKgRL0wrOM9EbmJzXJe6QzOWT37unPKo2ymbBhlL2xlMrtD+nCwo
         H12d7UEBkSJ/VdrOsR83T6Gx2M9EOF07+GB1e4THGyexHtKXApRMe43RehVckkuxhGud
         Qo9zO5NlwekO7xPoEEn7dQxDqntBgqVvqikju+8Wam2sekerIledfEj66C81wRd/F3HR
         HN978phBq7THUQb4uJ2/C/rSAdeu5D1jP967FLfrcMaS+HPYURMiTtlBDmG7D+U5Mm94
         3n2w==
X-Gm-Message-State: APjAAAXd3/VFs5gl2tabOitPq2aHo6Luy+O2/VckewavUIMIWh37JpYe
	1NQSXfjdOz0bFqx6slEDf6Y5zuNOXzX5V0la9G5J8g==
X-Google-Smtp-Source: APXvYqxD3i4MTeMu5laZF7CTOSl2l15Y0m9a04cmDBEqmf3IBlXgDVsag0WKWz1QSO0gNyUQpFd2TxKhd5o0jfGfGMQ=
X-Received: by 2002:a05:600c:248:: with SMTP id 8mr3415701wmj.1.1581670556711;
 Fri, 14 Feb 2020 00:55:56 -0800 (PST)
MIME-Version: 1.0
References: <20200203134010.12144-1-pete@akeo.ie>
In-Reply-To: <20200203134010.12144-1-pete@akeo.ie>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Fri, 14 Feb 2020 08:55:45 +0000
Message-ID: <CAKv+Gu8TkN3ca34YeHaLPX4yqRBnyhxA1wv6G2t-CjHzXMJnJQ@mail.gmail.com>
Subject: Re: [edk2-platforms][PATCH 1/1] Platform/RPi4: Add ACPI entry for Genet network interface
To: Pete Batard <pete@akeo.ie>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif@nuviainc.com>, 
	=?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= <philmd@redhat.com>, 
	Jeremy Linton <lintonrjeremy@gmail.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 3 Feb 2020 at 14:40, Pete Batard <pete@akeo.ie> wrote:
>
> The Raspberry Pi 4 platforms uses a Broadcom Genet network interface, for
> which we need ACPI entries in order to make it usable under Linux.
>
> This patch adds these entries, including a max-dma-burst-size DSD attribute
> aimed at simplifying support for Genet on distros that use older kernels,
> such as Debian.
>
> Note that we ran these settings through someone working for Broadcom, who
> okayed the proposed values including ownership of max-dma-burst-size (which
> we expect to also require for Device Tree usage on older kernels, hence the
> requirement for a designated owner).
>
> Signed-off-by: Pete Batard <pete@akeo.ie>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as 2f1cb7447690..cc7a0c68618c


> ---
>  Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl | 29 ++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl b/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl
> index b2f1d3439211..12c3967fa9e1 100644
> --- a/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl
> +++ b/Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl
> @@ -267,6 +267,35 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 5, "MSFT", "EDK2", 2)
>        }
>      }
>
> +    Device (ETH0)
> +    {
> +      Name (_HID, "BCM6E4E")
> +      Name (_CID, "BCM6E4E")
> +      Name (_UID, 0x0)
> +      Name (_CCA, 0x0)
> +      Method (_STA)
> +      {
> +        Return (0xf)
> +      }
> +      Method (_CRS, 0x0, Serialized)
> +      {
> +        Name (RBUF, ResourceTemplate ()
> +        {
> +          Memory32Fixed (ReadWrite, 0xfd580000, 0x10000, )
> +          Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0xBD }
> +          Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0xBE }
> +        })
> +        Return (RBUF)
> +      }
> +      Name (_DSD, Package () {
> +        ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> +        Package () {
> +          Package () { "brcm,max-dma-burst-size", 0x08 },
> +          Package () { "phy-mode", "rgmii" },
> +        }
> +      })
> +    }
> +
>      // Description: I2C
>      Device (I2C1)
>      {
> --
> 2.21.0.windows.1
>